* [PATCH] ALSA: hda/cs35l56: Remove dependency on COMPILE_TEST
@ 2025-04-28 9:41 Richard Fitzgerald
2025-04-30 5:35 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Richard Fitzgerald @ 2025-04-28 9:41 UTC (permalink / raw)
To: tiwai; +Cc: linux-sound, linux-kernel, patches, Richard Fitzgerald
Change the Kconfig dependency on ACPI || COMPILE_TEST to only depend on
ACPI.
The alternate dependency on COMPILE_TEST was a fudge to enable building
KUnit tests for modules that are selected by the CS35L56 driver but don't
depend on ACPI. This was based on a misunderstanding that KUNIT_ALL_TESTS
meant "all tests". Actually KUNIT_ALL_TESTS only means "tests for modules
that have satisfied dependencies" so it shouldn't be overriding
dependencies.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
sound/pci/hda/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
index 15cc46032583..25fb60b0428b 100644
--- a/sound/pci/hda/Kconfig
+++ b/sound/pci/hda/Kconfig
@@ -151,7 +151,7 @@ config SND_HDA_SCODEC_CS35L56
config SND_HDA_SCODEC_CS35L56_I2C
tristate "Build CS35L56 HD-audio side codec support for I2C Bus"
depends on I2C
- depends on ACPI || COMPILE_TEST
+ depends on ACPI
depends on SND_SOC
select FW_CS_DSP
imply SERIAL_MULTI_INSTANTIATE
@@ -167,7 +167,7 @@ config SND_HDA_SCODEC_CS35L56_I2C
config SND_HDA_SCODEC_CS35L56_SPI
tristate "Build CS35L56 HD-audio side codec support for SPI Bus"
depends on SPI_MASTER
- depends on ACPI || COMPILE_TEST
+ depends on ACPI
depends on SND_SOC
select FW_CS_DSP
imply SERIAL_MULTI_INSTANTIATE
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda/cs35l56: Remove dependency on COMPILE_TEST
2025-04-28 9:41 [PATCH] ALSA: hda/cs35l56: Remove dependency on COMPILE_TEST Richard Fitzgerald
@ 2025-04-30 5:35 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-04-30 5:35 UTC (permalink / raw)
To: Richard Fitzgerald; +Cc: tiwai, linux-sound, linux-kernel, patches
On Mon, 28 Apr 2025 11:41:26 +0200,
Richard Fitzgerald wrote:
>
> Change the Kconfig dependency on ACPI || COMPILE_TEST to only depend on
> ACPI.
>
> The alternate dependency on COMPILE_TEST was a fudge to enable building
> KUnit tests for modules that are selected by the CS35L56 driver but don't
> depend on ACPI. This was based on a misunderstanding that KUNIT_ALL_TESTS
> meant "all tests". Actually KUNIT_ALL_TESTS only means "tests for modules
> that have satisfied dependencies" so it shouldn't be overriding
> dependencies.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-30 5:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-28 9:41 [PATCH] ALSA: hda/cs35l56: Remove dependency on COMPILE_TEST Richard Fitzgerald
2025-04-30 5:35 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox