Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET
@ 2024-08-09 10:38 胡连勤
  2024-08-10  8:45 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: 胡连勤 @ 2024-08-09 10:38 UTC (permalink / raw)
  To: perex@perex.cz, tiwai@suse.com, mbarriolinares@gmail.com,
	wangdicheng@kylinos.cn, sean@mess.org, alexander@tsoy.me,
	xristos.thes@gmail.com, knuesel@gmail.com
  Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	opensource.kernel, akpm@linux-foundation.org

From: Lianqin Hu <hulianqin@vivo.com>

Audio control requests that sets sampling frequency sometimes fail on
this card. Adding delay between control messages eliminates that problem.

Signed-off-by: Lianqin Hu <hulianqin@vivo.com>
---
 sound/usb/quirks.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index ea063a14cdd8..4c7f0f9d15de 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -2119,6 +2119,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
 	DEVICE_FLG(0x07fd, 0x000b, /* MOTU M Series 2nd hardware revision */
 		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
+	DEVICE_FLG(0x2d95, 0x8021, /* VIVO USB-C-XE710 HEADSET */
+		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
 	DEVICE_FLG(0x08bb, 0x2702, /* LineX FM Transmitter */
 		   QUIRK_FLAG_IGNORE_CTL_ERROR),
 	DEVICE_FLG(0x0951, 0x16ad, /* Kingston HyperX */
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET
  2024-08-09 10:38 [PATCH] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET 胡连勤
@ 2024-08-10  8:45 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-08-10  8:45 UTC (permalink / raw)
  To: 胡连勤
  Cc: perex@perex.cz, tiwai@suse.com, mbarriolinares@gmail.com,
	wangdicheng@kylinos.cn, sean@mess.org, alexander@tsoy.me,
	xristos.thes@gmail.com, knuesel@gmail.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	opensource.kernel, akpm@linux-foundation.org

On Fri, 09 Aug 2024 12:38:52 +0200,
胡连勤 wrote:
> 
> From: Lianqin Hu <hulianqin@vivo.com>
> 
> Audio control requests that sets sampling frequency sometimes fail on
> this card. Adding delay between control messages eliminates that problem.
> 
> Signed-off-by: Lianqin Hu <hulianqin@vivo.com>
> ---
>  sound/usb/quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index ea063a14cdd8..4c7f0f9d15de 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2119,6 +2119,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
>  		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
>  	DEVICE_FLG(0x07fd, 0x000b, /* MOTU M Series 2nd hardware revision */
>  		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
> +	DEVICE_FLG(0x2d95, 0x8021, /* VIVO USB-C-XE710 HEADSET */
> +		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
>  	DEVICE_FLG(0x08bb, 0x2702, /* LineX FM Transmitter */
>  		   QUIRK_FLAG_IGNORE_CTL_ERROR),
>  	DEVICE_FLG(0x0951, 0x16ad, /* Kingston HyperX */

The quirk table entry is sorted in the ID number order.
Could you try to put the new entry at the right position?


thanks,

Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-10  8:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-09 10:38 [PATCH] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET 胡连勤
2024-08-10  8:45 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox