[PATCH 0/7] ALSA: Add missing module description

[PATCH 0/7] ALSA: Add missing module description

[Takashi Iwai]

Hi,

here is a trivial patch series for adding the missing
MODULE_DESCRIPTION() to the code that can be built as modules
where make W=1 starts complaining the lack of MODULE_DESCRIPTION()
since recently.

Fixes for ASoC follow later.


Takashi

===

Takashi Iwai (7):
  ALSA: ac97: legacy: Add missing module description
  ALSA: ac97: bus: Add missing module description
  ALSA: pcm_dmaengine: Add missing module description
  ALSA: kunit: Add missing module descriptions
  ALSA: pcmtest: Add missing module descriptions
  ALSA: hda: cirrus_scodec_test: Add missing module descriptions
  sound: oss: dmasound: Add missing module descriptions

 sound/ac97/bus.c                    | 1 +
 sound/ac97_bus.c                    | 1 +
 sound/core/pcm_dmaengine.c          | 1 +
 sound/core/sound_kunit.c            | 1 +
 sound/drivers/pcmtest.c             | 1 +
 sound/oss/dmasound/dmasound_atari.c | 2 ++
 sound/oss/dmasound/dmasound_paula.c | 1 +
 sound/pci/hda/cirrus_scodec_test.c  | 1 +
 8 files changed, 9 insertions(+)

-- 
2.43.0

[PATCH 1/7] ALSA: ac97: legacy: Add missing module description

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/ac97_bus.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/ac97_bus.c b/sound/ac97_bus.c
index 7ea274c55900..1484fc178fa4 100644
--- a/sound/ac97_bus.c
+++ b/sound/ac97_bus.c
@@ -95,4 +95,5 @@ module_exit(ac97_bus_exit);
 
 EXPORT_SYMBOL(ac97_bus_type);
 
+MODULE_DESCRIPTION("Legacy AC97 bus interface");
 MODULE_LICENSE("GPL");
-- 
2.43.0

[PATCH 2/7] ALSA: ac97: bus: Add missing module description

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/ac97/bus.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/ac97/bus.c b/sound/ac97/bus.c
index 5e46b972a3da..40e88d79c483 100644
--- a/sound/ac97/bus.c
+++ b/sound/ac97/bus.c
@@ -551,5 +551,6 @@ static void __exit ac97_bus_exit(void)
 }
 module_exit(ac97_bus_exit);
 
+MODULE_DESCRIPTION("AC97 bus interface");
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Robert Jarzmik <robert.jarzmik@free.fr>");
-- 
2.43.0

[PATCH 3/7] ALSA: pcm_dmaengine: Add missing module description

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/core/pcm_dmaengine.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/core/pcm_dmaengine.c b/sound/core/pcm_dmaengine.c
index 494ec0c207fa..12aa1cef11a1 100644
--- a/sound/core/pcm_dmaengine.c
+++ b/sound/core/pcm_dmaengine.c
@@ -470,4 +470,5 @@ int snd_dmaengine_pcm_refine_runtime_hwparams(
 }
 EXPORT_SYMBOL_GPL(snd_dmaengine_pcm_refine_runtime_hwparams);
 
+MODULE_DESCRIPTION("PCM dmaengine helper APIs");
 MODULE_LICENSE("GPL");
-- 
2.43.0

[PATCH 4/7] ALSA: kunit: Add missing module descriptions

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/core/sound_kunit.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/core/sound_kunit.c b/sound/core/sound_kunit.c
index 165bd0f5338a..bfed1a25fc8f 100644
--- a/sound/core/sound_kunit.c
+++ b/sound/core/sound_kunit.c
@@ -308,5 +308,6 @@ static struct kunit_suite sound_utils_suite = {
 };
 
 kunit_test_suite(sound_utils_suite);
+MODULE_DESCRIPTION("Sound core KUnit test");
 MODULE_AUTHOR("Ivan Orlov");
 MODULE_LICENSE("GPL");
-- 
2.43.0

[PATCH 5/7] ALSA: pcmtest: Add missing module descriptions

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/drivers/pcmtest.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/drivers/pcmtest.c b/sound/drivers/pcmtest.c
index b8bff5522bce..21cefaf5419a 100644
--- a/sound/drivers/pcmtest.c
+++ b/sound/drivers/pcmtest.c
@@ -772,6 +772,7 @@ static void __exit mod_exit(void)
 	platform_device_unregister(&pcmtst_pdev);
 }
 
+MODULE_DESCRIPTION("Virtual ALSA driver for PCM testing/fuzzing");
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Ivan Orlov");
 module_init(mod_init);
-- 
2.43.0

Re: [PATCH 5/7] ALSA: pcmtest: Add missing module descriptions

[Ivan Orlov]

On 5/8/24 10:11, Takashi Iwai wrote:
> Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
> let's add the missing information.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>   sound/drivers/pcmtest.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/drivers/pcmtest.c b/sound/drivers/pcmtest.c
> index b8bff5522bce..21cefaf5419a 100644
> --- a/sound/drivers/pcmtest.c
> +++ b/sound/drivers/pcmtest.c
> @@ -772,6 +772,7 @@ static void __exit mod_exit(void)
>   	platform_device_unregister(&pcmtst_pdev);
>   }
>   
> +MODULE_DESCRIPTION("Virtual ALSA driver for PCM testing/fuzzing");
>   MODULE_LICENSE("GPL");
>   MODULE_AUTHOR("Ivan Orlov");
>   module_init(mod_init);

Hi Takashi,

Thank you for doing this.

Acked-by: Ivan Orlov <ivan.orlov0322@gmail.com>

-- 
Kind regards,
Ivan Orlov

[PATCH 6/7] ALSA: hda: cirrus_scodec_test: Add missing module descriptions

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/hda/cirrus_scodec_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/cirrus_scodec_test.c b/sound/pci/hda/cirrus_scodec_test.c
index 8ae373676bd1..e925ebe21ccb 100644
--- a/sound/pci/hda/cirrus_scodec_test.c
+++ b/sound/pci/hda/cirrus_scodec_test.c
@@ -366,5 +366,6 @@ static struct kunit_suite cirrus_scodec_test_suite = {
 kunit_test_suite(cirrus_scodec_test_suite);
 
 MODULE_IMPORT_NS(SND_HDA_CIRRUS_SCODEC);
+MODULE_DESCRIPTION("KUnit test for the Cirrus side-codec library");
 MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>");
 MODULE_LICENSE("GPL");
-- 
2.43.0

[PATCH 7/7] sound: oss: dmasound: Add missing module descriptions

[Takashi Iwai]

Now that make W=1 starts complaining the lack of MODULE_DESCRIPTION(),
let's add the missing information.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/ZjpQm-hxLQtpgkUx@smile.fi.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/oss/dmasound/dmasound_atari.c | 2 ++
 sound/oss/dmasound/dmasound_paula.c | 1 +
 2 files changed, 3 insertions(+)

diff --git a/sound/oss/dmasound/dmasound_atari.c b/sound/oss/dmasound/dmasound_atari.c
index 81c6a9830727..6188469de8af 100644
--- a/sound/oss/dmasound/dmasound_atari.c
+++ b/sound/oss/dmasound/dmasound_atari.c
@@ -1618,4 +1618,6 @@ static void __exit dmasound_atari_cleanup(void)
 
 module_init(dmasound_atari_init);
 module_exit(dmasound_atari_cleanup);
+
+MODULE_DESCRIPTION("Atari TT and Falcon DMA Sound Driver");
 MODULE_LICENSE("GPL");
diff --git a/sound/oss/dmasound/dmasound_paula.c b/sound/oss/dmasound/dmasound_paula.c
index 3a593da09280..b8fad12f9e5f 100644
--- a/sound/oss/dmasound/dmasound_paula.c
+++ b/sound/oss/dmasound/dmasound_paula.c
@@ -740,5 +740,6 @@ static struct platform_driver amiga_audio_driver __refdata = {
 
 module_platform_driver_probe(amiga_audio_driver, amiga_audio_probe);
 
+MODULE_DESCRIPTION("Amiga Paula DMA Sound Driver");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:amiga-audio");
-- 
2.43.0

Re: [PATCH 0/7] ALSA: Add missing module description

[Dragan Simic]

Hello Takashi,

On 2024-05-08 11:11, Takashi Iwai wrote:
> here is a trivial patch series for adding the missing
> MODULE_DESCRIPTION() to the code that can be built as modules
> where make W=1 starts complaining the lack of MODULE_DESCRIPTION()
> since recently.
> 
> Fixes for ASoC follow later.

The changes are looking good to me.  Thus, please add for the
entire series:

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

> ===
> 
> Takashi Iwai (7):
>   ALSA: ac97: legacy: Add missing module description
>   ALSA: ac97: bus: Add missing module description
>   ALSA: pcm_dmaengine: Add missing module description
>   ALSA: kunit: Add missing module descriptions
>   ALSA: pcmtest: Add missing module descriptions
>   ALSA: hda: cirrus_scodec_test: Add missing module descriptions
>   sound: oss: dmasound: Add missing module descriptions
> 
>  sound/ac97/bus.c                    | 1 +
>  sound/ac97_bus.c                    | 1 +
>  sound/core/pcm_dmaengine.c          | 1 +
>  sound/core/sound_kunit.c            | 1 +
>  sound/drivers/pcmtest.c             | 1 +
>  sound/oss/dmasound/dmasound_atari.c | 2 ++
>  sound/oss/dmasound/dmasound_paula.c | 1 +
>  sound/pci/hda/cirrus_scodec_test.c  | 1 +
>  8 files changed, 9 insertions(+)

Re: [PATCH 0/7] ALSA: Add missing module description

[Andy Shevchenko]

On Wed, May 08, 2024 at 11:11:19AM +0200, Takashi Iwai wrote:
> Hi,
> 
> here is a trivial patch series for adding the missing
> MODULE_DESCRIPTION() to the code that can be built as modules
> where make W=1 starts complaining the lack of MODULE_DESCRIPTION()
> since recently.
> 
> Fixes for ASoC follow later.

Probably Reported-by: fits better, but I'm fine with either.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/7] ALSA: Add missing module description

[Andy Shevchenko]

On Wed, May 08, 2024 at 12:36:10PM +0300, Andy Shevchenko wrote:
> On Wed, May 08, 2024 at 11:11:19AM +0200, Takashi Iwai wrote:
> > Hi,
> > 
> > here is a trivial patch series for adding the missing
> > MODULE_DESCRIPTION() to the code that can be built as modules
> > where make W=1 starts complaining the lack of MODULE_DESCRIPTION()
> > since recently.
> > 
> > Fixes for ASoC follow later.
> 
> Probably Reported-by: fits better, but I'm fine with either.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

In case you decide to switch to Reported-by, replace also Link by Closes tag.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/7] ALSA: Add missing module description

[Takashi Iwai]

On Wed, 08 May 2024 11:45:57 +0200,
Andy Shevchenko wrote:
> 
> On Wed, May 08, 2024 at 12:36:10PM +0300, Andy Shevchenko wrote:
> > On Wed, May 08, 2024 at 11:11:19AM +0200, Takashi Iwai wrote:
> > > Hi,
> > > 
> > > here is a trivial patch series for adding the missing
> > > MODULE_DESCRIPTION() to the code that can be built as modules
> > > where make W=1 starts complaining the lack of MODULE_DESCRIPTION()
> > > since recently.
> > > 
> > > Fixes for ASoC follow later.
> > 
> > Probably Reported-by: fits better, but I'm fine with either.
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> In case you decide to switch to Reported-by, replace also Link by Closes tag.

OK, I updated in that way and applied now.


thanks,

Takashi