Re: [PATCH] ALSA: hda/realtek: Add quirk for HP ProBook 450 G8

[Takashi Iwai <tiwai@suse.de>]

On Thu, 20 Nov 2025 20:15:47 +0100,
Ilyas Gasanov wrote:
> 
> My laptop, HP ProBook 450 G8 (32M40EA), has Realtek ALC236 codec on its
> integrated sound card, and uses GPIO pins 0x2 and 0x1 for speaker mute
> and mic mute LEDs correspondingly, as found out by me through hda-verb
> invocations. This matches the GPIO masks used by the
> alc236_fixup_hp_gpio_led() function.
> 
> PCI subsystem vendor and device IDs happen to be 0x103c and 0x8a75,
> which has not been covered in the ALC2xx driver code yet.
> 
> Signed-off-by: Ilyas Gasanov <torso.nafi@gmail.com>

The code change looks good, but the patch isn't cleanly applicable due
to the line breaks by your mailer.
Could you try to resubmit with the proper setup?


thanks,

Takashi

> ---
>  sound/hda/codecs/realtek/alc269.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c
> b/sound/hda/codecs/realtek/alc269.c
> index 6748057e6a14..10c83cd3460e 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -6590,6 +6590,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x8a4f, "HP Victus 15-fa0xxx (MB 8A4F)",
> ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
>  	SND_PCI_QUIRK(0x103c, 0x8a6e, "HP EDNA 360", ALC287_FIXUP_CS35L41_I2C_4),
>  	SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC",
> ALC236_FIXUP_HP_GPIO_LED),
> +	SND_PCI_QUIRK(0x103c, 0x8a75, "HP ProBook 450 G8 Notebook PC",
> ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One",
> ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)",
> ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)",
> ALC236_FIXUP_HP_GPIO_LED),
> -- 
> 2.51.0