* [PATCH] ALSA: hda/realtek: Add quirk for HP ProBook 450 G8 @ 2025-11-20 19:15 Ilyas Gasanov 2025-11-21 9:36 ` Takashi Iwai 2025-11-25 23:54 ` [PATCH v2] " Ilyas Gasanov 0 siblings, 2 replies; 5+ messages in thread From: Ilyas Gasanov @ 2025-11-20 19:15 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai; +Cc: linux-sound, alsa-devel My laptop, HP ProBook 450 G8 (32M40EA), has Realtek ALC236 codec on its integrated sound card, and uses GPIO pins 0x2 and 0x1 for speaker mute and mic mute LEDs correspondingly, as found out by me through hda-verb invocations. This matches the GPIO masks used by the alc236_fixup_hp_gpio_led() function. PCI subsystem vendor and device IDs happen to be 0x103c and 0x8a75, which has not been covered in the ALC2xx driver code yet. Signed-off-by: Ilyas Gasanov <torso.nafi@gmail.com> --- sound/hda/codecs/realtek/alc269.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c index 6748057e6a14..10c83cd3460e 100644 --- a/sound/hda/codecs/realtek/alc269.c +++ b/sound/hda/codecs/realtek/alc269.c @@ -6590,6 +6590,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8a4f, "HP Victus 15-fa0xxx (MB 8A4F)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT), SND_PCI_QUIRK(0x103c, 0x8a6e, "HP EDNA 360", ALC287_FIXUP_CS35L41_I2C_4), SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8a75, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED), -- 2.51.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add quirk for HP ProBook 450 G8 2025-11-20 19:15 [PATCH] ALSA: hda/realtek: Add quirk for HP ProBook 450 G8 Ilyas Gasanov @ 2025-11-21 9:36 ` Takashi Iwai 2025-11-21 10:03 ` Ilyas Gasanov 2025-11-25 23:54 ` [PATCH v2] " Ilyas Gasanov 1 sibling, 1 reply; 5+ messages in thread From: Takashi Iwai @ 2025-11-21 9:36 UTC (permalink / raw) To: Ilyas Gasanov; +Cc: Jaroslav Kysela, Takashi Iwai, linux-sound, alsa-devel On Thu, 20 Nov 2025 20:15:47 +0100, Ilyas Gasanov wrote: > > My laptop, HP ProBook 450 G8 (32M40EA), has Realtek ALC236 codec on its > integrated sound card, and uses GPIO pins 0x2 and 0x1 for speaker mute > and mic mute LEDs correspondingly, as found out by me through hda-verb > invocations. This matches the GPIO masks used by the > alc236_fixup_hp_gpio_led() function. > > PCI subsystem vendor and device IDs happen to be 0x103c and 0x8a75, > which has not been covered in the ALC2xx driver code yet. > > Signed-off-by: Ilyas Gasanov <torso.nafi@gmail.com> The code change looks good, but the patch isn't cleanly applicable due to the line breaks by your mailer. Could you try to resubmit with the proper setup? thanks, Takashi > --- > sound/hda/codecs/realtek/alc269.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/hda/codecs/realtek/alc269.c > b/sound/hda/codecs/realtek/alc269.c > index 6748057e6a14..10c83cd3460e 100644 > --- a/sound/hda/codecs/realtek/alc269.c > +++ b/sound/hda/codecs/realtek/alc269.c > @@ -6590,6 +6590,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x8a4f, "HP Victus 15-fa0xxx (MB 8A4F)", > ALC245_FIXUP_HP_MUTE_LED_COEFBIT), > SND_PCI_QUIRK(0x103c, 0x8a6e, "HP EDNA 360", ALC287_FIXUP_CS35L41_I2C_4), > SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC", > ALC236_FIXUP_HP_GPIO_LED), > + SND_PCI_QUIRK(0x103c, 0x8a75, "HP ProBook 450 G8 Notebook PC", > ALC236_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", > ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), > SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", > ALC236_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", > ALC236_FIXUP_HP_GPIO_LED), > -- > 2.51.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add quirk for HP ProBook 450 G8 2025-11-21 9:36 ` Takashi Iwai @ 2025-11-21 10:03 ` Ilyas Gasanov 0 siblings, 0 replies; 5+ messages in thread From: Ilyas Gasanov @ 2025-11-21 10:03 UTC (permalink / raw) To: Takashi Iwai; +Cc: Jaroslav Kysela, linux-sound On Fri, 21 Nov 2025 13:36 +0400, Takashi Iwai wrote: > > On Thu, 20 Nov 2025 20:15:47 +0100, > Ilyas Gasanov wrote: > > > > My laptop, HP ProBook 450 G8 (32M40EA), has Realtek ALC236 codec on its > > integrated sound card, and uses GPIO pins 0x2 and 0x1 for speaker mute > > and mic mute LEDs correspondingly, as found out by me through hda-verb > > invocations. This matches the GPIO masks used by the > > alc236_fixup_hp_gpio_led() function. > > > > PCI subsystem vendor and device IDs happen to be 0x103c and 0x8a75, > > which has not been covered in the ALC2xx driver code yet. > > > > Signed-off-by: Ilyas Gasanov <torso.nafi@gmail.com> > > The code change looks good, but the patch isn't cleanly applicable due > to the line breaks by your mailer. > Could you try to resubmit with the proper setup? > It looks like the issue is either on the lieer (gmi) side, or on the Gmail server's side (in which case I'll probably have to set up a separate mailbox with another service specifically for patch emailing). I'm inclined to think it's likely the latter, since in the copy I'm having in my Sent folder, there are no extraneous line breaks in the code. Could be wrong though, might as well be an IMAP sync thing with lieer, for all I know. Configuring Gmail to work with git-send-email at all is a pain these days anyway, in no small part because of Google's rather convoluted OAuth2 token issuing policy. And plain old passwords just don't seem to work anymore, at least for me. I'll see what I can do later. > > thanks, > > Takashi > > > --- > > sound/hda/codecs/realtek/alc269.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sound/hda/codecs/realtek/alc269.c > > b/sound/hda/codecs/realtek/alc269.c > > index 6748057e6a14..10c83cd3460e 100644 > > --- a/sound/hda/codecs/realtek/alc269.c > > +++ b/sound/hda/codecs/realtek/alc269.c > > @@ -6590,6 +6590,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { > > SND_PCI_QUIRK(0x103c, 0x8a4f, "HP Victus 15-fa0xxx (MB 8A4F)", > > ALC245_FIXUP_HP_MUTE_LED_COEFBIT), > > SND_PCI_QUIRK(0x103c, 0x8a6e, "HP EDNA 360", ALC287_FIXUP_CS35L41_I2C_4), > > SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC", > > ALC236_FIXUP_HP_GPIO_LED), > > + SND_PCI_QUIRK(0x103c, 0x8a75, "HP ProBook 450 G8 Notebook PC", > > ALC236_FIXUP_HP_GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", > > ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), > > SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", > > ALC236_FIXUP_HP_GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", > > ALC236_FIXUP_HP_GPIO_LED), > > -- > > 2.51.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ALSA: hda/realtek: Add quirk for HP ProBook 450 G8 2025-11-20 19:15 [PATCH] ALSA: hda/realtek: Add quirk for HP ProBook 450 G8 Ilyas Gasanov 2025-11-21 9:36 ` Takashi Iwai @ 2025-11-25 23:54 ` Ilyas Gasanov 2025-11-26 7:53 ` Takashi Iwai 1 sibling, 1 reply; 5+ messages in thread From: Ilyas Gasanov @ 2025-11-25 23:54 UTC (permalink / raw) To: Jaroslav Kysela, Takashi Iwai; +Cc: Ilyas Gasanov, linux-sound My laptop, HP ProBook 450 G8 (32M40EA), has Realtek ALC236 codec on its integrated sound card, and uses GPIO pins 0x2 and 0x1 for speaker mute and mic mute LEDs correspondingly, as found out by me through hda-verb invocations. This matches the GPIO masks used by the alc236_fixup_hp_gpio_led() function. PCI subsystem vendor and device IDs happen to be 0x103c and 0x8a75, which has not been covered in the ALC2xx driver code yet. Signed-off-by: Ilyas Gasanov <public@gsnoff.com> --- sound/hda/codecs/realtek/alc269.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c index 70299e359ba0..97430c993ada 100644 --- a/sound/hda/codecs/realtek/alc269.c +++ b/sound/hda/codecs/realtek/alc269.c @@ -6590,6 +6590,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8a4f, "HP Victus 15-fa0xxx (MB 8A4F)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT), SND_PCI_QUIRK(0x103c, 0x8a6e, "HP EDNA 360", ALC287_FIXUP_CS35L41_I2C_4), SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8a75, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED), -- 2.51.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ALSA: hda/realtek: Add quirk for HP ProBook 450 G8 2025-11-25 23:54 ` [PATCH v2] " Ilyas Gasanov @ 2025-11-26 7:53 ` Takashi Iwai 0 siblings, 0 replies; 5+ messages in thread From: Takashi Iwai @ 2025-11-26 7:53 UTC (permalink / raw) To: Ilyas Gasanov; +Cc: Jaroslav Kysela, Takashi Iwai, Ilyas Gasanov, linux-sound On Wed, 26 Nov 2025 00:54:41 +0100, Ilyas Gasanov wrote: > > My laptop, HP ProBook 450 G8 (32M40EA), has Realtek ALC236 codec on its > integrated sound card, and uses GPIO pins 0x2 and 0x1 for speaker mute > and mic mute LEDs correspondingly, as found out by me through hda-verb > invocations. This matches the GPIO masks used by the > alc236_fixup_hp_gpio_led() function. > > PCI subsystem vendor and device IDs happen to be 0x103c and 0x8a75, > which has not been covered in the ALC2xx driver code yet. > > Signed-off-by: Ilyas Gasanov <public@gsnoff.com> Applied now. Thanks. Takashi ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-11-26 7:53 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-11-20 19:15 [PATCH] ALSA: hda/realtek: Add quirk for HP ProBook 450 G8 Ilyas Gasanov 2025-11-21 9:36 ` Takashi Iwai 2025-11-21 10:03 ` Ilyas Gasanov 2025-11-25 23:54 ` [PATCH v2] " Ilyas Gasanov 2025-11-26 7:53 ` Takashi Iwai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox