* [PATCH next] ALSA: hda/tas2781: Fix error code tas2781_read_acpi()
@ 2024-11-30 10:08 Dan Carpenter
2024-12-01 8:52 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2024-11-30 10:08 UTC (permalink / raw)
To: Baojun Xu
Cc: Shenghao Ding, Kevin Lu, Jaroslav Kysela, Takashi Iwai,
linux-sound, linux-kernel, kernel-janitors
Return an error code if acpi_get_subsystem_id() fails. Don't return
success.
Fixes: 4e7035a75da9 ("ALSA: hda/tas2781: Add speaker id check for ASUS projects")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
sound/pci/hda/tas2781_hda_i2c.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
index 45cfb5a6f309..8ec03bda85f3 100644
--- a/sound/pci/hda/tas2781_hda_i2c.c
+++ b/sound/pci/hda/tas2781_hda_i2c.c
@@ -143,6 +143,7 @@ static int tas2781_read_acpi(struct tasdevice_priv *p, const char *hid)
sub = acpi_get_subsystem_id(ACPI_HANDLE(physdev));
if (IS_ERR(sub)) {
dev_err(p->dev, "Failed to get SUBSYS ID.\n");
+ ret = PTR_ERR(sub);
goto err;
}
/* Speaker id was needed for ASUS projects. */
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH next] ALSA: hda/tas2781: Fix error code tas2781_read_acpi()
2024-11-30 10:08 [PATCH next] ALSA: hda/tas2781: Fix error code tas2781_read_acpi() Dan Carpenter
@ 2024-12-01 8:52 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-12-01 8:52 UTC (permalink / raw)
To: Dan Carpenter
Cc: Baojun Xu, Shenghao Ding, Kevin Lu, Jaroslav Kysela, Takashi Iwai,
linux-sound, linux-kernel, kernel-janitors
On Sat, 30 Nov 2024 11:08:18 +0100,
Dan Carpenter wrote:
>
> Return an error code if acpi_get_subsystem_id() fails. Don't return
> success.
>
> Fixes: 4e7035a75da9 ("ALSA: hda/tas2781: Add speaker id check for ASUS projects")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-01 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-30 10:08 [PATCH next] ALSA: hda/tas2781: Fix error code tas2781_read_acpi() Dan Carpenter
2024-12-01 8:52 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox