[PATCH] ALSA: hda: Use imply for suggesting CONFIG_SERIAL_MULTI_INSTANTIATE

[PATCH] ALSA: hda: Use imply for suggesting CONFIG_SERIAL_MULTI_INSTANTIATE

[Takashi Iwai]

The recent fix introduced a reverse selection of
CONFIG_SERIAL_MULTI_INSTANTIATE, but its condition isn't always met.
Use a weak reverse selection to suggest the config for avoiding such
inconsistencies, instead.

Fixes: 9b1effff19cd ("ALSA: hda: cs35l56: Select SERIAL_MULTI_INSTANTIATE")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202406210732.ozgk8IMK-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202406211244.oLhoF3My-lkp@intel.com/
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/hda/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
index e59df40a0007..a3cf0725fc43 100644
--- a/sound/pci/hda/Kconfig
+++ b/sound/pci/hda/Kconfig
@@ -162,7 +162,7 @@ config SND_HDA_SCODEC_CS35L56_I2C
 	depends on ACPI || COMPILE_TEST
 	depends on SND_SOC
 	select FW_CS_DSP
-	select SERIAL_MULTI_INSTANTIATE
+	imply SERIAL_MULTI_INSTANTIATE
 	select SND_HDA_GENERIC
 	select SND_SOC_CS35L56_SHARED
 	select SND_HDA_SCODEC_CS35L56
@@ -179,7 +179,7 @@ config SND_HDA_SCODEC_CS35L56_SPI
 	depends on ACPI || COMPILE_TEST
 	depends on SND_SOC
 	select FW_CS_DSP
-	select SERIAL_MULTI_INSTANTIATE
+	imply SERIAL_MULTI_INSTANTIATE
 	select SND_HDA_GENERIC
 	select SND_SOC_CS35L56_SHARED
 	select SND_HDA_SCODEC_CS35L56
-- 
2.43.0

Re: [PATCH] ALSA: hda: Use imply for suggesting CONFIG_SERIAL_MULTI_INSTANTIATE

[Richard Fitzgerald]

On 21/06/2024 08:39, Takashi Iwai wrote:
> The recent fix introduced a reverse selection of
> CONFIG_SERIAL_MULTI_INSTANTIATE, but its condition isn't always met.
> Use a weak reverse selection to suggest the config for avoiding such
> inconsistencies, instead.
> 
> Fixes: 9b1effff19cd ("ALSA: hda: cs35l56: Select SERIAL_MULTI_INSTANTIATE")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406210732.ozgk8IMK-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202406211244.oLhoF3My-lkp@intel.com/
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>   sound/pci/hda/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
> index e59df40a0007..a3cf0725fc43 100644
> --- a/sound/pci/hda/Kconfig
> +++ b/sound/pci/hda/Kconfig
> @@ -162,7 +162,7 @@ config SND_HDA_SCODEC_CS35L56_I2C
>   	depends on ACPI || COMPILE_TEST
>   	depends on SND_SOC
>   	select FW_CS_DSP
> -	select SERIAL_MULTI_INSTANTIATE
> +	imply SERIAL_MULTI_INSTANTIATE
>   	select SND_HDA_GENERIC
>   	select SND_SOC_CS35L56_SHARED
>   	select SND_HDA_SCODEC_CS35L56
> @@ -179,7 +179,7 @@ config SND_HDA_SCODEC_CS35L56_SPI
>   	depends on ACPI || COMPILE_TEST
>   	depends on SND_SOC
>   	select FW_CS_DSP
> -	select SERIAL_MULTI_INSTANTIATE
> +	imply SERIAL_MULTI_INSTANTIATE
>   	select SND_HDA_GENERIC
>   	select SND_SOC_CS35L56_SHARED
>   	select SND_HDA_SCODEC_CS35L56
Sorry about that. Thanks for fixing.
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>

(Though I think this points at a bug in serial-multi-instantiate
dependencies. When SPI support was added it was made mandatory
to have both I2C AND SPI. But you shouldn't need to build in a
subsystem if you don't have any devices of that type.)

Re: [PATCH] ALSA: hda: Use imply for suggesting CONFIG_SERIAL_MULTI_INSTANTIATE

[Takashi Iwai]

On Fri, 21 Jun 2024 11:13:46 +0200,
Richard Fitzgerald wrote:
> 
> On 21/06/2024 08:39, Takashi Iwai wrote:
> > The recent fix introduced a reverse selection of
> > CONFIG_SERIAL_MULTI_INSTANTIATE, but its condition isn't always met.
> > Use a weak reverse selection to suggest the config for avoiding such
> > inconsistencies, instead.
> > 
> > Fixes: 9b1effff19cd ("ALSA: hda: cs35l56: Select SERIAL_MULTI_INSTANTIATE")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202406210732.ozgk8IMK-lkp@intel.com/
> > Closes: https://lore.kernel.org/oe-kbuild-all/202406211244.oLhoF3My-lkp@intel.com/
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> >   sound/pci/hda/Kconfig | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
> > index e59df40a0007..a3cf0725fc43 100644
> > --- a/sound/pci/hda/Kconfig
> > +++ b/sound/pci/hda/Kconfig
> > @@ -162,7 +162,7 @@ config SND_HDA_SCODEC_CS35L56_I2C
> >   	depends on ACPI || COMPILE_TEST
> >   	depends on SND_SOC
> >   	select FW_CS_DSP
> > -	select SERIAL_MULTI_INSTANTIATE
> > +	imply SERIAL_MULTI_INSTANTIATE
> >   	select SND_HDA_GENERIC
> >   	select SND_SOC_CS35L56_SHARED
> >   	select SND_HDA_SCODEC_CS35L56
> > @@ -179,7 +179,7 @@ config SND_HDA_SCODEC_CS35L56_SPI
> >   	depends on ACPI || COMPILE_TEST
> >   	depends on SND_SOC
> >   	select FW_CS_DSP
> > -	select SERIAL_MULTI_INSTANTIATE
> > +	imply SERIAL_MULTI_INSTANTIATE
> >   	select SND_HDA_GENERIC
> >   	select SND_SOC_CS35L56_SHARED
> >   	select SND_HDA_SCODEC_CS35L56
> Sorry about that. Thanks for fixing.
> Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> 
> (Though I think this points at a bug in serial-multi-instantiate
> dependencies. When SPI support was added it was made mandatory
> to have both I2C AND SPI. But you shouldn't need to build in a
> subsystem if you don't have any devices of that type.)

Yeah, the condition there could be relaxed, I suppose.

But the use of imply isn't bad for a case like this, so let's go
forward with this fix.


thanks,

Takashi

Re: [PATCH] ALSA: hda: Use imply for suggesting CONFIG_SERIAL_MULTI_INSTANTIATE

[Richard Fitzgerald]

On 21/06/2024 11:06, Takashi Iwai wrote:
> On Fri, 21 Jun 2024 11:13:46 +0200,
> Richard Fitzgerald wrote:
>>
>> On 21/06/2024 08:39, Takashi Iwai wrote:
>>> The recent fix introduced a reverse selection of
>>> CONFIG_SERIAL_MULTI_INSTANTIATE, but its condition isn't always met.
>>> Use a weak reverse selection to suggest the config for avoiding such
>>> inconsistencies, instead.
>>>
>>> Fixes: 9b1effff19cd ("ALSA: hda: cs35l56: Select SERIAL_MULTI_INSTANTIATE")
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202406210732.ozgk8IMK-lkp@intel.com/
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202406211244.oLhoF3My-lkp@intel.com/
>>> Signed-off-by: Takashi Iwai <tiwai@suse.de>
>>> ---
>>>    sound/pci/hda/Kconfig | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
>>> index e59df40a0007..a3cf0725fc43 100644
>>> --- a/sound/pci/hda/Kconfig
>>> +++ b/sound/pci/hda/Kconfig
>>> @@ -162,7 +162,7 @@ config SND_HDA_SCODEC_CS35L56_I2C
>>>    	depends on ACPI || COMPILE_TEST
>>>    	depends on SND_SOC
>>>    	select FW_CS_DSP
>>> -	select SERIAL_MULTI_INSTANTIATE
>>> +	imply SERIAL_MULTI_INSTANTIATE
>>>    	select SND_HDA_GENERIC
>>>    	select SND_SOC_CS35L56_SHARED
>>>    	select SND_HDA_SCODEC_CS35L56
>>> @@ -179,7 +179,7 @@ config SND_HDA_SCODEC_CS35L56_SPI
>>>    	depends on ACPI || COMPILE_TEST
>>>    	depends on SND_SOC
>>>    	select FW_CS_DSP
>>> -	select SERIAL_MULTI_INSTANTIATE
>>> +	imply SERIAL_MULTI_INSTANTIATE
>>>    	select SND_HDA_GENERIC
>>>    	select SND_SOC_CS35L56_SHARED
>>>    	select SND_HDA_SCODEC_CS35L56
>> Sorry about that. Thanks for fixing.
>> Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
>>
>> (Though I think this points at a bug in serial-multi-instantiate
>> dependencies. When SPI support was added it was made mandatory
>> to have both I2C AND SPI. But you shouldn't need to build in a
>> subsystem if you don't have any devices of that type.)
> 
> Yeah, the condition there could be relaxed, I suppose.
> 
> But the use of imply isn't bad for a case like this, so let's go
> forward with this fix.
> 
Agreed.

> 
> thanks,
> 
> Takashi