From: Takashi Iwai <tiwai@suse.de>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: Jaroslav Kysela <perex@perex.cz>,
yunbolyu@smu.edu.sg, kexinsun@smail.nju.edu.cn,
ratnadiraw@smu.edu.sg, xutong.ma@inria.fr,
Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: echoaudio: adjust function name reference
Date: Wed, 31 Dec 2025 16:47:01 +0100 [thread overview]
Message-ID: <87bjjey7pm.wl-tiwai@suse.de> (raw)
In-Reply-To: <20251230133525.91837-1-Julia.Lawall@inria.fr>
On Tue, 30 Dec 2025 14:35:25 +0100,
Julia Lawall wrote:
>
> The code just below the comment sets chip->pipe_alloc_mask to 0 and
> then calls restore_dsp_rettings, so it seems that restore_dsp_rettings
> is what was intended.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> ---
>
> The code in restore_dsp_rettings() looks like restore_dsp_settings()
> might be a more appropriate name. If it is preferred to change that,
> I would be happy to redo the patch.
Yes, let's correct the typo in the function name itself.
Please submit another version.
thanks,
Takashi
prev parent reply other threads:[~2025-12-31 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 13:35 [PATCH] ALSA: echoaudio: adjust function name reference Julia Lawall
2025-12-31 15:47 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjjey7pm.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Julia.Lawall@inria.fr \
--cc=kexinsun@smail.nju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ratnadiraw@smu.edu.sg \
--cc=tiwai@suse.com \
--cc=xutong.ma@inria.fr \
--cc=yunbolyu@smu.edu.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox