* [PATCH] ALSA: echoaudio: adjust function name reference
@ 2025-12-30 13:35 Julia Lawall
2025-12-31 15:47 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2025-12-30 13:35 UTC (permalink / raw)
To: Jaroslav Kysela
Cc: yunbolyu, kexinsun, ratnadiraw, xutong.ma, Takashi Iwai,
linux-sound, linux-kernel
The code just below the comment sets chip->pipe_alloc_mask to 0 and
then calls restore_dsp_rettings, so it seems that restore_dsp_rettings
is what was intended.
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
The code in restore_dsp_rettings() looks like restore_dsp_settings()
might be a more appropriate name. If it is preferred to change that,
I would be happy to redo the patch.
sound/pci/echoaudio/echoaudio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index f2c8602a1ad7..65a73faf2027 100644
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -2155,7 +2155,7 @@ static int snd_echo_resume(struct device *dev)
}
/* Temporarily set chip->pipe_alloc_mask=0 otherwise
- * restore_dsp_settings() fails.
+ * restore_dsp_rettings() fails.
*/
pipe_alloc_mask = chip->pipe_alloc_mask;
chip->pipe_alloc_mask = 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: echoaudio: adjust function name reference
2025-12-30 13:35 [PATCH] ALSA: echoaudio: adjust function name reference Julia Lawall
@ 2025-12-31 15:47 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-12-31 15:47 UTC (permalink / raw)
To: Julia Lawall
Cc: Jaroslav Kysela, yunbolyu, kexinsun, ratnadiraw, xutong.ma,
Takashi Iwai, linux-sound, linux-kernel
On Tue, 30 Dec 2025 14:35:25 +0100,
Julia Lawall wrote:
>
> The code just below the comment sets chip->pipe_alloc_mask to 0 and
> then calls restore_dsp_rettings, so it seems that restore_dsp_rettings
> is what was intended.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> ---
>
> The code in restore_dsp_rettings() looks like restore_dsp_settings()
> might be a more appropriate name. If it is preferred to change that,
> I would be happy to redo the patch.
Yes, let's correct the typo in the function name itself.
Please submit another version.
thanks,
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-31 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-30 13:35 [PATCH] ALSA: echoaudio: adjust function name reference Julia Lawall
2025-12-31 15:47 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox