From: Takashi Iwai <tiwai@suse.de>
To: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, alsa-devel@alsa-project.org,
linux-sound@vger.kernel.org,
pierre-louis.bossart@linux.intel.com,
kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com
Subject: Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
Date: Mon, 27 Nov 2023 15:31:01 +0100 [thread overview]
Message-ID: <87cyvvp8t6.wl-tiwai@suse.de> (raw)
In-Reply-To: <d2fff7cd-ea4b-41b9-992b-fab6ba6549ec@linux.intel.com>
On Mon, 27 Nov 2023 15:12:51 +0100,
Péter Ujfalusi wrote:
>
>
>
> On 27/11/2023 15:18, Takashi Iwai wrote:
> >> +bool snd_hda_device_is_hdmi(struct hdac_device *hdev)
> >> +{
> >> + int i;
> >> +
> >> + for (i = 0; i < ARRAY_SIZE(snd_hda_id_hdmi); i++) {
> >> + if (snd_hda_id_hdmi[i].vendor_id == hdev->vendor_id)
> >> + return true;
> >> + }
> >> +
> >> + return false;
> >> +}
> >> +EXPORT_SYMBOL_GPL(snd_hda_device_is_hdmi);
> >
> > I'm afraid that this will bring unnecessary dependency on HDMI codec
> > driver.
>
> For HDMI support we anyways need HDMI code?
But the ASoC hdac-hda driver isn't specifically bound with HDMI, I
thought?
With your patch, now it becomes a hard-dependency. It'll be even
build failure when HDMI codec driver isn't enabled in Kconfig.
Takashi
next prev parent reply other threads:[~2023-11-27 14:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 13:02 [PATCH 0/2] ALSA/ASoC: hdmi/hdac_hda: Conditionally register dais Peter Ujfalusi
2023-11-27 13:02 ` [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec Peter Ujfalusi
2023-11-27 13:18 ` Takashi Iwai
2023-11-27 14:12 ` Péter Ujfalusi
2023-11-27 14:31 ` Takashi Iwai [this message]
2023-11-27 14:45 ` Péter Ujfalusi
2023-11-27 15:20 ` Takashi Iwai
2023-11-27 15:40 ` Péter Ujfalusi
2023-11-27 15:43 ` Takashi Iwai
2023-11-28 9:10 ` Péter Ujfalusi
2023-11-28 9:39 ` Takashi Iwai
2023-11-28 9:53 ` Péter Ujfalusi
2023-11-28 10:02 ` Takashi Iwai
2023-11-28 10:16 ` Péter Ujfalusi
2023-11-28 10:48 ` Takashi Iwai
2023-11-28 11:58 ` Péter Ujfalusi
2023-11-28 12:16 ` Péter Ujfalusi
2023-11-28 13:02 ` Takashi Iwai
2023-11-27 13:02 ` [PATCH 2/2] ASoC: hdac_hda: Conditionally register dais for HDMI and Analog Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyvvp8t6.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox