From: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, alsa-devel@alsa-project.org,
linux-sound@vger.kernel.org,
pierre-louis.bossart@linux.intel.com,
kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com
Subject: Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
Date: Tue, 28 Nov 2023 11:53:56 +0200 [thread overview]
Message-ID: <e40a3b5d-425e-427c-bec2-6b82d8f5ee94@linux.intel.com> (raw)
In-Reply-To: <87y1eimd23.wl-tiwai@suse.de>
On 28/11/2023 11:39, Takashi Iwai wrote:
> Hm... I still find it's a bad move to use an exported symbol from
> another codec driver.
The other option is to check for 0x4 (or address 2), but I'm not sure if
this is Intel only or universally true for HDMI codecs.
> And, I wonder what if you have a system that has only one HDMI codec
> without analog one? Would it still work with your change?
Yes, it works with only HDMI codec (for example on SoundWire laptops) or
with UP2 board which only have HDMI audio support by default.
It also works if we disable HDMI and only have analog codec.
--
Péter
next prev parent reply other threads:[~2023-11-28 9:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 13:02 [PATCH 0/2] ALSA/ASoC: hdmi/hdac_hda: Conditionally register dais Peter Ujfalusi
2023-11-27 13:02 ` [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec Peter Ujfalusi
2023-11-27 13:18 ` Takashi Iwai
2023-11-27 14:12 ` Péter Ujfalusi
2023-11-27 14:31 ` Takashi Iwai
2023-11-27 14:45 ` Péter Ujfalusi
2023-11-27 15:20 ` Takashi Iwai
2023-11-27 15:40 ` Péter Ujfalusi
2023-11-27 15:43 ` Takashi Iwai
2023-11-28 9:10 ` Péter Ujfalusi
2023-11-28 9:39 ` Takashi Iwai
2023-11-28 9:53 ` Péter Ujfalusi [this message]
2023-11-28 10:02 ` Takashi Iwai
2023-11-28 10:16 ` Péter Ujfalusi
2023-11-28 10:48 ` Takashi Iwai
2023-11-28 11:58 ` Péter Ujfalusi
2023-11-28 12:16 ` Péter Ujfalusi
2023-11-28 13:02 ` Takashi Iwai
2023-11-27 13:02 ` [PATCH 2/2] ASoC: hdac_hda: Conditionally register dais for HDMI and Analog Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e40a3b5d-425e-427c-bec2-6b82d8f5ee94@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox