* [PATCH] ALSA: hda/tegra: fix a memory leak in hda_tegra_first_init()
@ 2025-12-28 14:05 Haoxiang Li
2025-12-29 13:23 ` Markus Elfring
2025-12-31 15:42 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Haoxiang Li @ 2025-12-28 14:05 UTC (permalink / raw)
To: perex, tiwai, thierry.reding, jonathanh, mkumard, ddadap, sheetal
Cc: linux-sound, linux-tegra, linux-kernel, Haoxiang Li
Add azx_free_stream_pages() to release the resources allocated
by azx_alloc_stream_pages().
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
---
sound/hda/controllers/tegra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/hda/controllers/tegra.c b/sound/hda/controllers/tegra.c
index 6ab338f37db5..656cbd88b9aa 100644
--- a/sound/hda/controllers/tegra.c
+++ b/sound/hda/controllers/tegra.c
@@ -380,6 +380,7 @@ static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
/* codec detection */
if (!bus->codec_mask) {
dev_err(card->dev, "no codecs found!\n");
+ azx_free_stream_pages(chip);
return -ENODEV;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: hda/tegra: fix a memory leak in hda_tegra_first_init()
2025-12-28 14:05 [PATCH] ALSA: hda/tegra: fix a memory leak in hda_tegra_first_init() Haoxiang Li
@ 2025-12-29 13:23 ` Markus Elfring
2025-12-31 15:42 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2025-12-29 13:23 UTC (permalink / raw)
To: Haoxiang Li, linux-tegra, linux-sound, Daniel Dadap,
Jaroslav Kysela, Jonathan Hunter, Mohan Kumar D, sheetal,
Thierry Reding, Takashi Iwai
Cc: LKML
> Add azx_free_stream_pages() to release the resources allocated
call?
> by azx_alloc_stream_pages().
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc3#n145
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: hda/tegra: fix a memory leak in hda_tegra_first_init()
2025-12-28 14:05 [PATCH] ALSA: hda/tegra: fix a memory leak in hda_tegra_first_init() Haoxiang Li
2025-12-29 13:23 ` Markus Elfring
@ 2025-12-31 15:42 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2025-12-31 15:42 UTC (permalink / raw)
To: Haoxiang Li
Cc: perex, tiwai, thierry.reding, jonathanh, mkumard, ddadap, sheetal,
linux-sound, linux-tegra, linux-kernel
On Sun, 28 Dec 2025 15:05:30 +0100,
Haoxiang Li wrote:
>
> Add azx_free_stream_pages() to release the resources allocated
> by azx_alloc_stream_pages().
It'll be already called later at the destructor hda_tegra_dev_free()
callback, so this change would be rather superfluous or harmful.
thanks,
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-31 15:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-28 14:05 [PATCH] ALSA: hda/tegra: fix a memory leak in hda_tegra_first_init() Haoxiang Li
2025-12-29 13:23 ` Markus Elfring
2025-12-31 15:42 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox