* [PATCH 1/9] ALSA: hda/realtek: Remove ALC294_FIXUP_CS35L41_I2C_2
[not found] <20260803091102.107570-1-dnaim@cachyos.org>
@ 2026-08-03 9:10 ` Eric Naim
2026-08-03 9:10 ` [PATCH 2/9] ALSA: hda/realtek: Add ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST quirk Eric Naim
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Eric Naim @ 2026-08-03 9:10 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Eric Naim, linux-sound, linux-kernel
ALC294_FIXUP_CS35L41_I2C_2 is exactly the same as
ALC287_FIXUP_CS35L41_I2C_2, so remove the former and move existing
devices that previously used ALC294_FIXUP_CS35L41_I2C_2 to
ALC287_FIXUP_CS35L41_I2C_2.
Signed-off-by: Eric Naim <dnaim@cachyos.org>
---
sound/hda/codecs/realtek/alc269.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index e9b0f3aa9776..f44996869059 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -4232,7 +4232,6 @@ enum {
ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD,
ALC2XX_FIXUP_HEADSET_MIC,
ALC289_FIXUP_DELL_CS35L41_SPI_2,
- ALC294_FIXUP_CS35L41_I2C_2,
ALC256_FIXUP_ACER_SFG16_MICMUTE_LED,
ALC256_FIXUP_HEADPHONE_AMP_VOL,
ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX,
@@ -6730,10 +6729,6 @@ static const struct hda_fixup alc269_fixups[] = {
.chained = true,
.chain_id = ALC289_FIXUP_DUAL_SPK
},
- [ALC294_FIXUP_CS35L41_I2C_2] = {
- .type = HDA_FIXUP_FUNC,
- .v.func = cs35l41_fixup_i2c_two,
- },
[ALC256_FIXUP_ACER_SFG16_MICMUTE_LED] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc256_fixup_acer_sfg16_micmute_led,
@@ -7671,7 +7666,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1863, "ASUS UX6404VI/VV", ALC245_FIXUP_CS35L41_SPI_2),
SND_PCI_QUIRK(0x1043, 0x1881, "ASUS Zephyrus S/M", ALC294_FIXUP_ASUS_GX502_PINS),
SND_PCI_QUIRK(0x1043, 0x18b1, "Asus MJ401TA", ALC256_FIXUP_ASUS_HEADSET_MIC),
- SND_PCI_QUIRK(0x1043, 0x18d3, "ASUS UM3504DA", ALC294_FIXUP_CS35L41_I2C_2),
+ SND_PCI_QUIRK(0x1043, 0x18d3, "ASUS UM3504DA", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x1043, 0x18f1, "Asus FX505DT", ALC256_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x194e, "ASUS UX563FD", ALC294_FIXUP_ASUS_HPE),
SND_PCI_QUIRK(0x1043, 0x1970, "ASUS UX550VE", ALC289_FIXUP_ASUS_GA401),
@@ -7682,7 +7677,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x19f4, "ASUS UM3405GA", ALC294_FIXUP_ASUS_I2C_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
SND_PCI_QUIRK(0x1043, 0x1a63, "ASUS UX3405MA", ALC294_FIXUP_ASUS_SPI_HEADSET_MIC),
- SND_PCI_QUIRK(0x1043, 0x1a83, "ASUS UM5302LA", ALC294_FIXUP_CS35L41_I2C_2),
+ SND_PCI_QUIRK(0x1043, 0x1a83, "ASUS UM5302LA", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x1043, 0x1a8e, "ASUS G712LWS", ALC294_FIXUP_LENOVO_MIC_LOCATION),
SND_PCI_QUIRK(0x1043, 0x1a8f, "ASUS UX582ZS", ALC245_FIXUP_CS35L41_SPI_2),
SND_PCI_QUIRK(0x1043, 0x1b11, "ASUS UX431DA", ALC294_FIXUP_ASUS_COEF_1B),
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/9] ALSA: hda/realtek: Add ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST quirk
[not found] <20260803091102.107570-1-dnaim@cachyos.org>
2026-08-03 9:10 ` [PATCH 1/9] ALSA: hda/realtek: Remove ALC294_FIXUP_CS35L41_I2C_2 Eric Naim
@ 2026-08-03 9:10 ` Eric Naim
2026-08-03 9:10 ` [PATCH 3/9] ALSA: hda/realtek: Unchain ALC269_FIXUP_THINKPAD_ACPI from ALC269_FIXUP_LIMIT_INT_MIC_BOOST Eric Naim
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Eric Naim @ 2026-08-03 9:10 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Eric Naim, linux-sound, linux-kernel
Add ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST, identical to
ALC269_FIXUP_LIMIT_INT_MIC_BOOST.
This prepares for removing the chain from
ALC269_FIXUP_LIMIT_INT_MIC_BOOST.
Signed-off-by: Eric Naim <dnaim@cachyos.org>
---
sound/hda/codecs/realtek/alc269.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index f44996869059..2efa984a2193 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -3975,6 +3975,7 @@ enum {
ALC271_FIXUP_HP_GATE_MIC_JACK_E1_572,
ALC269_FIXUP_ACER_AC700,
ALC269_FIXUP_LIMIT_INT_MIC_BOOST,
+ ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST,
ALC269VB_FIXUP_ASUS_ZENBOOK,
ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A,
ALC269VB_FIXUP_ASUS_MIC_NO_PRESENCE,
@@ -4774,6 +4775,12 @@ static const struct hda_fixup alc269_fixups[] = {
.chained = true,
.chain_id = ALC269_FIXUP_THINKPAD_ACPI,
},
+ [ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST] = {
+ .type = HDA_FIXUP_FUNC,
+ .v.func = alc269_fixup_limit_int_mic_boost,
+ .chained = true,
+ .chain_id = ALC269_FIXUP_THINKPAD_ACPI,
+ },
[ALC269VB_FIXUP_ASUS_ZENBOOK] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc269_fixup_limit_int_mic_boost,
@@ -7930,7 +7937,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x2211, "Thinkpad W541", ALC292_FIXUP_TPT440_DOCK),
SND_PCI_QUIRK(0x17aa, 0x2212, "Thinkpad T440", ALC292_FIXUP_TPT440_DOCK),
SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad X240", ALC292_FIXUP_TPT440_DOCK),
- SND_PCI_QUIRK(0x17aa, 0x2215, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
+ SND_PCI_QUIRK(0x17aa, 0x2215, "Thinkpad", ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST),
SND_PCI_QUIRK(0x17aa, 0x2218, "Thinkpad X1 Carbon 2nd", ALC292_FIXUP_TPT440_DOCK),
SND_PCI_QUIRK(0x17aa, 0x2223, "ThinkPad T550", ALC292_FIXUP_TPT440_DOCK),
SND_PCI_QUIRK(0x17aa, 0x2226, "ThinkPad X250", ALC292_FIXUP_TPT440_DOCK),
@@ -7946,7 +7953,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
- SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
+ SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST),
SND_PCI_QUIRK(0x17aa, 0x2288, "Thinkpad X390", ALC285_FIXUP_THINKPAD_NO_BASS_SPK_HEADSET_JACK),
SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Carbon 7th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
SND_PCI_QUIRK(0x17aa, 0x22be, "Thinkpad X1 Carbon 8th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
@@ -8102,10 +8109,10 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
- SND_PCI_QUIRK(0x17aa, 0x5013, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
+ SND_PCI_QUIRK(0x17aa, 0x5013, "Thinkpad", ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST),
SND_PCI_QUIRK(0x17aa, 0x501a, "Thinkpad", ALC283_FIXUP_INT_MIC),
SND_PCI_QUIRK(0x17aa, 0x501e, "Thinkpad L440", ALC292_FIXUP_TPT440_DOCK),
- SND_PCI_QUIRK(0x17aa, 0x5026, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
+ SND_PCI_QUIRK(0x17aa, 0x5026, "Thinkpad", ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST),
SND_PCI_QUIRK(0x17aa, 0x5034, "Thinkpad T450", ALC292_FIXUP_TPT440_DOCK),
SND_PCI_QUIRK(0x17aa, 0x5036, "Thinkpad T450s", ALC292_FIXUP_TPT440_DOCK),
SND_PCI_QUIRK(0x17aa, 0x503c, "Thinkpad L450", ALC292_FIXUP_TPT440_DOCK),
@@ -8118,7 +8125,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x505f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x5062, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x508b, "Thinkpad X12 Gen 1", ALC287_FIXUP_LEGION_15IMHG05_SPEAKERS),
- SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
+ SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST),
SND_PCI_QUIRK(0x17aa, 0x511e, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD),
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 3/9] ALSA: hda/realtek: Unchain ALC269_FIXUP_THINKPAD_ACPI from ALC269_FIXUP_LIMIT_INT_MIC_BOOST
[not found] <20260803091102.107570-1-dnaim@cachyos.org>
2026-08-03 9:10 ` [PATCH 1/9] ALSA: hda/realtek: Remove ALC294_FIXUP_CS35L41_I2C_2 Eric Naim
2026-08-03 9:10 ` [PATCH 2/9] ALSA: hda/realtek: Add ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST quirk Eric Naim
@ 2026-08-03 9:10 ` Eric Naim
2026-08-03 9:10 ` [PATCH 4/9] ALSA: hda/realtek: Remove ALC233_FIXUP_INTEL_NUC8_BOOST Eric Naim
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Eric Naim @ 2026-08-03 9:10 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Eric Naim, linux-sound, linux-kernel
After creating ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST,
ALC269_FIXUP_LIMIT_INT_MIC_BOOST no longer needs to be chained to
ALC269_FIXUP_THINKPAD_ACPI and can be a generic quirk usable by all
devices.
Signed-off-by: Eric Naim <dnaim@cachyos.org>
---
sound/hda/codecs/realtek/alc269.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 2efa984a2193..c457ee9f61a2 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -4771,9 +4771,7 @@ static const struct hda_fixup alc269_fixups[] = {
},
[ALC269_FIXUP_LIMIT_INT_MIC_BOOST] = {
.type = HDA_FIXUP_FUNC,
- .v.func = alc269_fixup_limit_int_mic_boost,
- .chained = true,
- .chain_id = ALC269_FIXUP_THINKPAD_ACPI,
+ .v.func = alc269_fixup_limit_int_mic_boost
},
[ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST] = {
.type = HDA_FIXUP_FUNC,
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 4/9] ALSA: hda/realtek: Remove ALC233_FIXUP_INTEL_NUC8_BOOST
[not found] <20260803091102.107570-1-dnaim@cachyos.org>
` (2 preceding siblings ...)
2026-08-03 9:10 ` [PATCH 3/9] ALSA: hda/realtek: Unchain ALC269_FIXUP_THINKPAD_ACPI from ALC269_FIXUP_LIMIT_INT_MIC_BOOST Eric Naim
@ 2026-08-03 9:10 ` Eric Naim
2026-08-03 9:10 ` [PATCH 5/9] ALSA: hda/realtek: Remove ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST Eric Naim
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Eric Naim @ 2026-08-03 9:10 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Eric Naim, linux-sound, linux-kernel
Now that ALC269_FIXUP_LIMIT_INT_MIC_BOOST is no longer chained to
ALC269_FIXUP_THINKPAD_ACPI, ALC233_FIXUP_INTEL_NUC8_BOOST and
ALC269_FIXUP_LIMIT_INT_MIC_BOOST are both identical. Remove the former
and replace it with the latter to avoid redundancy.
Signed-off-by: Eric Naim <dnaim@cachyos.org>
---
sound/hda/codecs/realtek/alc269.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index c457ee9f61a2..addea99b3bce 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -4157,7 +4157,6 @@ enum {
ALC269_FIXUP_LEMOTE_A190X,
ALC256_FIXUP_INTEL_NUC8_RUGGED,
ALC233_FIXUP_INTEL_NUC8_DMIC,
- ALC233_FIXUP_INTEL_NUC8_BOOST,
ALC256_FIXUP_INTEL_NUC10,
ALC255_FIXUP_XIAOMI_HEADSET_MIC,
ALC274_FIXUP_HP_MIC,
@@ -5149,11 +5148,7 @@ static const struct hda_fixup alc269_fixups[] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc_fixup_inv_dmic,
.chained = true,
- .chain_id = ALC233_FIXUP_INTEL_NUC8_BOOST,
- },
- [ALC233_FIXUP_INTEL_NUC8_BOOST] = {
- .type = HDA_FIXUP_FUNC,
- .v.func = alc269_fixup_limit_int_mic_boost
+ .chain_id = ALC269_FIXUP_LIMIT_INT_MIC_BOOST,
},
[ALC255_FIXUP_DELL_SPK_NOISE] = {
.type = HDA_FIXUP_FUNC,
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5/9] ALSA: hda/realtek: Remove ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST
[not found] <20260803091102.107570-1-dnaim@cachyos.org>
` (3 preceding siblings ...)
2026-08-03 9:10 ` [PATCH 4/9] ALSA: hda/realtek: Remove ALC233_FIXUP_INTEL_NUC8_BOOST Eric Naim
@ 2026-08-03 9:10 ` Eric Naim
2026-08-03 9:10 ` [PATCH 6/9] ALSA: hda/realtek: Add ALC285_FIXUP_YOGA_SPEAKER2_TO_DAC1 Eric Naim
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Eric Naim @ 2026-08-03 9:10 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Eric Naim, linux-sound, linux-kernel
Now that ALC269_FIXUP_LIMIT_INT_MIC_BOOST is no longer chained to
ALC269_FIXUP_THINKPAD_ACPI, ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST and
ALC269_FIXUP_LIMIT_INT_MIC_BOOST are both identical. Remove the former
and replace it with the latter to avoid redundancy.
Signed-off-by: Eric Naim <dnaim@cachyos.org>
---
sound/hda/codecs/realtek/alc269.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index addea99b3bce..473422e236e9 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -4248,7 +4248,6 @@ enum {
ALC245_FIXUP_MINISFORUM_JACK_DETECT,
ALC269_FIXUP_VAIO_VJFH52_MIC_NO_PRESENCE,
ALC233_FIXUP_MEDION_MTL_SPK,
- ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST,
ALC233_FIXUP_STARLABS_STARFIGHTER,
ALC294_FIXUP_BASS_SPEAKER_15,
ALC283_FIXUP_DELL_HP_RESUME,
@@ -6822,15 +6821,11 @@ static const struct hda_fixup alc269_fixups[] = {
{ }
},
},
- [ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST] = {
- .type = HDA_FIXUP_FUNC,
- .v.func = alc269_fixup_limit_int_mic_boost,
- },
[ALC233_FIXUP_STARLABS_STARFIGHTER] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc233_fixup_starlabs_starfighter,
.chained = true,
- .chain_id = ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST,
+ .chain_id = ALC269_FIXUP_LIMIT_INT_MIC_BOOST,
},
[ALC294_FIXUP_BASS_SPEAKER_15] = {
.type = HDA_FIXUP_FUNC,
@@ -8266,7 +8261,7 @@ static const struct hda_quirk alc269_fixup_vendor_tbl[] = {
SND_PCI_QUIRK_VENDOR(0x104d, "Sony VAIO", ALC269_FIXUP_SONY_VAIO),
SND_PCI_QUIRK_VENDOR(0x17aa, "Lenovo XPAD", ALC269_FIXUP_LENOVO_XPAD_ACPI),
SND_PCI_QUIRK_VENDOR(0x19e5, "Huawei Matebook", ALC255_FIXUP_MIC_MUTE_LED),
- SND_PCI_QUIRK_VENDOR(0x2145, "Star Labs", ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST),
+ SND_PCI_QUIRK_VENDOR(0x2145, "Star Labs", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
{}
};
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 6/9] ALSA: hda/realtek: Add ALC285_FIXUP_YOGA_SPEAKER2_TO_DAC1
[not found] <20260803091102.107570-1-dnaim@cachyos.org>
` (4 preceding siblings ...)
2026-08-03 9:10 ` [PATCH 5/9] ALSA: hda/realtek: Remove ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST Eric Naim
@ 2026-08-03 9:10 ` Eric Naim
2026-08-03 9:10 ` [PATCH 7/9] ALSA: hda/realtek: Unchain ALC269_FIXUP_THINKPAD_ACPI from ALC285_FIXUP_SPEAKER2_TO_DAC1 Eric Naim
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Eric Naim @ 2026-08-03 9:10 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Eric Naim, linux-sound, linux-kernel
In preparation for unchaining ALC269_FIXUP_THINKPAD_ACPI from
ALC285_FIXUP_SPEAKER2_TO_DAC1, add
ALC285_FIXUP_YOGA_SPEAKER2_TO_DAC1 as a duplicate of
ALC285_FIXUP_SPEAKER2_TO_DAC1.
Signed-off-by: Eric Naim <dnaim@cachyos.org>
---
sound/hda/codecs/realtek/alc269.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 473422e236e9..991136bc43ec 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -4044,6 +4044,7 @@ enum {
ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
ALC295_FIXUP_DISABLE_DAC3,
ALC285_FIXUP_SPEAKER2_TO_DAC1,
+ ALC285_FIXUP_YOGA_SPEAKER2_TO_DAC1,
ALC285_FIXUP_ASUS_SPEAKER2_TO_DAC1,
ALC285_FIXUP_ASUS_HEADSET_MIC,
ALC285_FIXUP_ASUS_SPI_REAR_SPEAKERS,
@@ -5211,6 +5212,12 @@ static const struct hda_fixup alc269_fixups[] = {
.chained = true,
.chain_id = ALC269_FIXUP_THINKPAD_ACPI
},
+ [ALC285_FIXUP_YOGA_SPEAKER2_TO_DAC1] = {
+ .type = HDA_FIXUP_FUNC,
+ .v.func = alc285_fixup_speaker2_to_dac1,
+ .chained = true,
+ .chain_id = ALC269_FIXUP_THINKPAD_ACPI
+ },
[ALC285_FIXUP_ASUS_SPEAKER2_TO_DAC1] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc285_fixup_speaker2_to_dac1,
@@ -8016,7 +8023,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x3869, "Lenovo Yoga7 14IAL7", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
HDA_CODEC_QUIRK(0x17aa, 0x386a, "Lenovo Yoga 7 16IAP7", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
HDA_CODEC_QUIRK(0x17aa, 0x386e, "Legion Y9000X 2022 IAH7", ALC287_FIXUP_CS35L41_I2C_2),
- SND_PCI_QUIRK(0x17aa, 0x386e, "Yoga Pro 7 14ARP8", ALC285_FIXUP_SPEAKER2_TO_DAC1),
+ SND_PCI_QUIRK(0x17aa, 0x386e, "Yoga Pro 7 14ARP8", ALC285_FIXUP_YOGA_SPEAKER2_TO_DAC1),
HDA_CODEC_QUIRK(0x17aa, 0x38a8, "Legion Pro 7 16ARX8H", ALC287_FIXUP_TAS2781_I2C), /* this must match before PCI SSID 17aa:386f below */
HDA_CODEC_QUIRK(0x17aa, 0x38a7, "Legion Pro 7 16ARX8H", ALC287_FIXUP_TAS2781_I2C), /* this must match before PCI SSID 17aa:386f below */
SND_PCI_QUIRK(0x17aa, 0x386f, "Legion Pro 7i 16IAX7", ALC287_FIXUP_CS35L41_I2C_2),
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 7/9] ALSA: hda/realtek: Unchain ALC269_FIXUP_THINKPAD_ACPI from ALC285_FIXUP_SPEAKER2_TO_DAC1
[not found] <20260803091102.107570-1-dnaim@cachyos.org>
` (5 preceding siblings ...)
2026-08-03 9:10 ` [PATCH 6/9] ALSA: hda/realtek: Add ALC285_FIXUP_YOGA_SPEAKER2_TO_DAC1 Eric Naim
@ 2026-08-03 9:10 ` Eric Naim
2026-08-03 9:10 ` [PATCH 8/9] ALSA: hda/realtek: Remove ALC294_FIXUP_ASUS_ALLY_SPEAKER Eric Naim
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Eric Naim @ 2026-08-03 9:10 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Eric Naim, linux-sound, linux-kernel
Now that ALC285_FIXUP_YOGA_SPEAKER2_TO_DAC1 exists,
ALC285_FIXUP_SPEAKER2_TO_DAC1 can be unchained from
ALC269_FIXUP_THINKPAD_ACPI.
Signed-off-by: Eric Naim <dnaim@cachyos.org>
---
sound/hda/codecs/realtek/alc269.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 991136bc43ec..1e6f3f262e03 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -5209,8 +5209,6 @@ static const struct hda_fixup alc269_fixups[] = {
[ALC285_FIXUP_SPEAKER2_TO_DAC1] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc285_fixup_speaker2_to_dac1,
- .chained = true,
- .chain_id = ALC269_FIXUP_THINKPAD_ACPI
},
[ALC285_FIXUP_YOGA_SPEAKER2_TO_DAC1] = {
.type = HDA_FIXUP_FUNC,
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 8/9] ALSA: hda/realtek: Remove ALC294_FIXUP_ASUS_ALLY_SPEAKER
[not found] <20260803091102.107570-1-dnaim@cachyos.org>
` (6 preceding siblings ...)
2026-08-03 9:10 ` [PATCH 7/9] ALSA: hda/realtek: Unchain ALC269_FIXUP_THINKPAD_ACPI from ALC285_FIXUP_SPEAKER2_TO_DAC1 Eric Naim
@ 2026-08-03 9:10 ` Eric Naim
2026-08-03 9:10 ` [PATCH 9/9] ALSA: hda/realtek: Remove ALC285_FIXUP_ASUS_GA605K_I2C_SPEAKER2_TO_DAC1 Eric Naim
2026-08-03 9:18 ` [PATCH 0/9] Remove some duplicate quirks Eric Naim
9 siblings, 0 replies; 11+ messages in thread
From: Eric Naim @ 2026-08-03 9:10 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Eric Naim, linux-sound, linux-kernel
ALC294_FIXUP_ASUS_ALLY_SPEAKER is exactly the same as
ALC285_FIXUP_SPEAKER2_TO_DAC1. Remove the former to avoid redundancy.
Signed-off-by: Eric Naim <dnaim@cachyos.org>
---
sound/hda/codecs/realtek/alc269.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 1e6f3f262e03..81d535acfd05 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -4114,7 +4114,6 @@ enum {
ALC294_FIXUP_ASUS_ALLY,
ALC294_FIXUP_ASUS_ALLY_PINS,
ALC294_FIXUP_ASUS_ALLY_VERBS,
- ALC294_FIXUP_ASUS_ALLY_SPEAKER,
ALC294_FIXUP_ASUS_HPE,
ALC294_FIXUP_ASUS_COEF_1B,
ALC294_FIXUP_ASUS_GX502_HP,
@@ -5732,11 +5731,7 @@ static const struct hda_fixup alc269_fixups[] = {
{ }
},
.chained = true,
- .chain_id = ALC294_FIXUP_ASUS_ALLY_SPEAKER
- },
- [ALC294_FIXUP_ASUS_ALLY_SPEAKER] = {
- .type = HDA_FIXUP_FUNC,
- .v.func = alc285_fixup_speaker2_to_dac1,
+ .chain_id = ALC285_FIXUP_SPEAKER2_TO_DAC1
},
[ALC285_FIXUP_THINKPAD_X1_GEN7] = {
.type = HDA_FIXUP_FUNC,
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 9/9] ALSA: hda/realtek: Remove ALC285_FIXUP_ASUS_GA605K_I2C_SPEAKER2_TO_DAC1
[not found] <20260803091102.107570-1-dnaim@cachyos.org>
` (7 preceding siblings ...)
2026-08-03 9:10 ` [PATCH 8/9] ALSA: hda/realtek: Remove ALC294_FIXUP_ASUS_ALLY_SPEAKER Eric Naim
@ 2026-08-03 9:10 ` Eric Naim
2026-08-03 9:18 ` [PATCH 0/9] Remove some duplicate quirks Eric Naim
9 siblings, 0 replies; 11+ messages in thread
From: Eric Naim @ 2026-08-03 9:10 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Eric Naim, linux-sound, linux-kernel
ALC285_FIXUP_ASUS_GA605K_I2C_SPEAKER2_TO_DAC1 and
ALC285_FIXUP_SPEAKER2_TO_DAC1 are exactly the same. Remove the former to
avoid redundancy.
Signed-off-by: Eric Naim <dnaim@cachyos.org>
---
sound/hda/codecs/realtek/alc269.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 81d535acfd05..481335776ba8 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -4255,7 +4255,6 @@ enum {
ALC274_FIXUP_HP_AIO_BIND_DACS,
ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2,
ALC285_FIXUP_ASUS_GA605K_HEADSET_MIC,
- ALC285_FIXUP_ASUS_GA605K_I2C_SPEAKER2_TO_DAC1,
ALC269_FIXUP_POSITIVO_P15X_HEADSET_MIC,
ALC289_FIXUP_ASUS_ZEPHYRUS_DUAL_SPK,
ALC256_FIXUP_VAIO_RPL_MIC_NO_PRESENCE,
@@ -6853,11 +6852,7 @@ static const struct hda_fixup alc269_fixups[] = {
{ }
},
.chained = true,
- .chain_id = ALC285_FIXUP_ASUS_GA605K_I2C_SPEAKER2_TO_DAC1
- },
- [ALC285_FIXUP_ASUS_GA605K_I2C_SPEAKER2_TO_DAC1] = {
- .type = HDA_FIXUP_FUNC,
- .v.func = alc285_fixup_speaker2_to_dac1,
+ .chain_id = ALC285_FIXUP_SPEAKER2_TO_DAC1
},
[ALC269_FIXUP_POSITIVO_P15X_HEADSET_MIC] = {
.type = HDA_FIXUP_FUNC,
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 0/9] Remove some duplicate quirks
[not found] <20260803091102.107570-1-dnaim@cachyos.org>
` (8 preceding siblings ...)
2026-08-03 9:10 ` [PATCH 9/9] ALSA: hda/realtek: Remove ALC285_FIXUP_ASUS_GA605K_I2C_SPEAKER2_TO_DAC1 Eric Naim
@ 2026-08-03 9:18 ` Eric Naim
2026-08-03 14:04 ` Takashi Iwai
9 siblings, 1 reply; 11+ messages in thread
From: Eric Naim @ 2026-08-03 9:18 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Eric Naim, linux-sound, open list
Sorry everyone, I fumbled sending the cover letter. Here it is.
--
Regards,
Eric
On 8/3/26 4:10 PM, Eric Naim wrote:
> When looking at a recent review discussion, I noticed that quirk existed
> because
> ALC269_FIXUP_LIMIT_INT_MIC_BOOST was chained to
> ALC269_FIXUP_THINKPAD_ACPI and could not be reused in that case.
> This led to removing the chain from ALC269_FIXUP_LIMIT_INT_MIC_BOOST
> and deleting the redundant quirks.
>
> While at it, I also removed other quirks that existed because a generic
> quirk was chained to another quirk.
>
> Signed-off-by: Eric Naim <dnaim@cachyos.org>
>
> Eric Naim (9):
> ALSA: hda/realtek: Remove ALC294_FIXUP_CS35L41_I2C_2
> ALSA: hda/realtek: Add ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST quirk
> ALSA: hda/realtek: Unchain ALC269_FIXUP_THINKPAD_ACPI from
> ALC269_FIXUP_LIMIT_INT_MIC_BOOST
> ALSA: hda/realtek: Remove ALC233_FIXUP_INTEL_NUC8_BOOST
> ALSA: hda/realtek: Remove ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST
> ALSA: hda/realtek: Add ALC285_FIXUP_YOGA_SPEAKER2_TO_DAC1
> ALSA: hda/realtek: Unchain ALC269_FIXUP_THINKPAD_ACPI from
> ALC285_FIXUP_SPEAKER2_TO_DAC1
> ALSA: hda/realtek: Remove ALC294_FIXUP_ASUS_ALLY_SPEAKER
> ALSA: hda/realtek: Remove
> ALC285_FIXUP_ASUS_GA605K_I2C_SPEAKER2_TO_DAC1
>
> sound/hda/codecs/realtek/alc269.c | 61 ++++++++++++-------------------
> 1 file changed, 23 insertions(+), 38 deletions(-)
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 0/9] Remove some duplicate quirks
2026-08-03 9:18 ` [PATCH 0/9] Remove some duplicate quirks Eric Naim
@ 2026-08-03 14:04 ` Takashi Iwai
0 siblings, 0 replies; 11+ messages in thread
From: Takashi Iwai @ 2026-08-03 14:04 UTC (permalink / raw)
To: Eric Naim; +Cc: Jaroslav Kysela, Takashi Iwai, linux-sound, open list
On Mon, 03 Aug 2026 11:18:00 +0200,
Eric Naim wrote:
>
> Sorry everyone, I fumbled sending the cover letter. Here it is.
>
> --
> Regards,
> Eric
>
> On 8/3/26 4:10 PM, Eric Naim wrote:
> > When looking at a recent review discussion, I noticed that quirk existed
> > because
> > ALC269_FIXUP_LIMIT_INT_MIC_BOOST was chained to
> > ALC269_FIXUP_THINKPAD_ACPI and could not be reused in that case.
> > This led to removing the chain from ALC269_FIXUP_LIMIT_INT_MIC_BOOST
> > and deleting the redundant quirks.
> >
> > While at it, I also removed other quirks that existed because a generic
> > quirk was chained to another quirk.
> >
> > Signed-off-by: Eric Naim <dnaim@cachyos.org>
> >
> > Eric Naim (9):
> > ALSA: hda/realtek: Remove ALC294_FIXUP_CS35L41_I2C_2
> > ALSA: hda/realtek: Add ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST quirk
> > ALSA: hda/realtek: Unchain ALC269_FIXUP_THINKPAD_ACPI from
> > ALC269_FIXUP_LIMIT_INT_MIC_BOOST
> > ALSA: hda/realtek: Remove ALC233_FIXUP_INTEL_NUC8_BOOST
> > ALSA: hda/realtek: Remove ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST
> > ALSA: hda/realtek: Add ALC285_FIXUP_YOGA_SPEAKER2_TO_DAC1
> > ALSA: hda/realtek: Unchain ALC269_FIXUP_THINKPAD_ACPI from
> > ALC285_FIXUP_SPEAKER2_TO_DAC1
> > ALSA: hda/realtek: Remove ALC294_FIXUP_ASUS_ALLY_SPEAKER
> > ALSA: hda/realtek: Remove
> > ALC285_FIXUP_ASUS_GA605K_I2C_SPEAKER2_TO_DAC1
Now applied all 9 patches to for-next branch.
thanks,
Takashi
^ permalink raw reply [flat|nested] 11+ messages in thread