* [PATCH v1] ALSA: hda/tas2781: Fix index issue in tas2781 hda SPI driver
@ 2025-02-14 1:30 Baojun Xu
2025-02-14 7:40 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Baojun Xu @ 2025-02-14 1:30 UTC (permalink / raw)
To: tiwai
Cc: robh+dt, andriy.shevchenko, lgirdwood, perex, shenghao-ding,
navada, 13916275206, v-hampiholi, v-po, linux-sound, linux-kernel,
liam.r.girdwood, yung-chuan.liao, baojun.xu, broonie, antheas.dk,
stuart.a.hayhurst, dan.carpenter
Correct wrong mask for device index.
Signed-off-by: Baojun Xu <baojun.xu@ti.com>
---
sound/pci/hda/tas2781_spi_fwlib.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/pci/hda/tas2781_spi_fwlib.c b/sound/pci/hda/tas2781_spi_fwlib.c
index 0e2acbc3c900..131d9a77d140 100644
--- a/sound/pci/hda/tas2781_spi_fwlib.c
+++ b/sound/pci/hda/tas2781_spi_fwlib.c
@@ -2,7 +2,7 @@
//
// TAS2781 HDA SPI driver
//
-// Copyright 2024 Texas Instruments, Inc.
+// Copyright 2024-2025 Texas Instruments, Inc.
//
// Author: Baojun Xu <baojun.xu@ti.com>
@@ -771,19 +771,19 @@ static int tasdevice_process_block(void *context, unsigned char *data,
switch (subblk_typ) {
case TASDEVICE_CMD_SING_W:
subblk_offset = tasdevice_single_byte_wr(tas_priv,
- dev_idx & 0x4f, data, sublocksize);
+ dev_idx & 0x3f, data, sublocksize);
break;
case TASDEVICE_CMD_BURST:
subblk_offset = tasdevice_burst_wr(tas_priv,
- dev_idx & 0x4f, data, sublocksize);
+ dev_idx & 0x3f, data, sublocksize);
break;
case TASDEVICE_CMD_DELAY:
subblk_offset = tasdevice_delay(tas_priv,
- dev_idx & 0x4f, data, sublocksize);
+ dev_idx & 0x3f, data, sublocksize);
break;
case TASDEVICE_CMD_FIELD_W:
subblk_offset = tasdevice_field_wr(tas_priv,
- dev_idx & 0x4f, data, sublocksize);
+ dev_idx & 0x3f, data, sublocksize);
break;
default:
subblk_offset = 2;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] ALSA: hda/tas2781: Fix index issue in tas2781 hda SPI driver
2025-02-14 1:30 [PATCH v1] ALSA: hda/tas2781: Fix index issue in tas2781 hda SPI driver Baojun Xu
@ 2025-02-14 7:40 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-02-14 7:40 UTC (permalink / raw)
To: Baojun Xu
Cc: tiwai, robh+dt, andriy.shevchenko, lgirdwood, perex,
shenghao-ding, navada, 13916275206, v-hampiholi, v-po,
linux-sound, linux-kernel, liam.r.girdwood, yung-chuan.liao,
broonie, antheas.dk, stuart.a.hayhurst, dan.carpenter
On Fri, 14 Feb 2025 02:30:21 +0100,
Baojun Xu wrote:
>
> Correct wrong mask for device index.
>
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>
Applied now with Fixes tag to commit bb5f86ea50ff ("ALSA: hda/tas2781:
Add tas2781 hda SPI driver").
Please put the proper Fix tag at the next time.
thanks,
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-14 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-14 1:30 [PATCH v1] ALSA: hda/tas2781: Fix index issue in tas2781 hda SPI driver Baojun Xu
2025-02-14 7:40 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox