* [PATCH v2] ASoC: simple-card-utils.c: add missing dlc->of_node
@ 2025-02-04 23:50 Kuninori Morimoto
2025-02-06 11:32 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2025-02-04 23:50 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-sound, Daniel Baluta
commit 90de551c1bf ("ASoC: simple-card-utils.c: enable multi Component
support") added muiti Component support, but was missing to add
dlc->of_node. Because of it, Sound device list will indicates strange
name if it was DPCM connection and driver supports dai->driver->dai_args,
like below
> aplay -l
card X: sndulcbmix [xxxx], device 0: fe.(null).rsnd-dai.0 (*) []
... ^^^^^^
It will be fixed by this patch
> aplay -l
card X: sndulcbmix [xxxx], device 0: fe.sound@ec500000.rsnd-dai.0 (*) []
... ^^^^^^^^^^^^^^
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
---
v1 -> v2
- add Reviewed-by
- based on v6.14-rc1
sound/soc/generic/simple-card-utils.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
index dd414634b4ac7..c2445c5ccd84c 100644
--- a/sound/soc/generic/simple-card-utils.c
+++ b/sound/soc/generic/simple-card-utils.c
@@ -1092,6 +1092,7 @@ int graph_util_parse_dai(struct device *dev, struct device_node *ep,
args.np = ep;
dai = snd_soc_get_dai_via_args(&args);
if (dai) {
+ dlc->of_node = node;
dlc->dai_name = snd_soc_dai_name_get(dai);
dlc->dai_args = snd_soc_copy_dai_args(dev, &args);
if (!dlc->dai_args)
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ASoC: simple-card-utils.c: add missing dlc->of_node
2025-02-04 23:50 [PATCH v2] ASoC: simple-card-utils.c: add missing dlc->of_node Kuninori Morimoto
@ 2025-02-06 11:32 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2025-02-06 11:32 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: linux-sound, Daniel Baluta
On Tue, 04 Feb 2025 23:50:08 +0000, Kuninori Morimoto wrote:
> commit 90de551c1bf ("ASoC: simple-card-utils.c: enable multi Component
> support") added muiti Component support, but was missing to add
> dlc->of_node. Because of it, Sound device list will indicates strange
> name if it was DPCM connection and driver supports dai->driver->dai_args,
> like below
>
> > aplay -l
> card X: sndulcbmix [xxxx], device 0: fe.(null).rsnd-dai.0 (*) []
> ... ^^^^^^
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: simple-card-utils.c: add missing dlc->of_node
commit: dabbd325b25edb5cdd99c94391817202dd54b651
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-06 11:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-04 23:50 [PATCH v2] ASoC: simple-card-utils.c: add missing dlc->of_node Kuninori Morimoto
2025-02-06 11:32 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox