* [PATCH 0/2] ALSA: hda/hdmi: add force-connect quirks
@ 2023-12-08 13:21 Kai Vehmanen
2023-12-08 13:21 ` [PATCH 1/2] ALSA: hda/hdmi: add force-connect quirk for NUC5CPYB Kai Vehmanen
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kai Vehmanen @ 2023-12-08 13:21 UTC (permalink / raw)
To: linux-sound, tiwai; +Cc: kai.vehmanen, alsa-devel
This series addresses problems seen on a few older Intel based
systems as found by the DRM i915 CI and the inject-audio test.
The patches in series have been separately tested on top
of drm-tip at:
https://patchwork.freedesktop.org/series/127515/
https://patchwork.freedesktop.org/series/127305/
Kai Vehmanen (2):
ALSA: hda/hdmi: add force-connect quirk for NUC5CPYB
ALSA: hda/hdmi: add force-connect quirks for ASUSTeK Z170 variants
sound/pci/hda/patch_hdmi.c | 3 +++
1 file changed, 3 insertions(+)
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] ALSA: hda/hdmi: add force-connect quirk for NUC5CPYB
2023-12-08 13:21 [PATCH 0/2] ALSA: hda/hdmi: add force-connect quirks Kai Vehmanen
@ 2023-12-08 13:21 ` Kai Vehmanen
2023-12-08 13:21 ` [PATCH 2/2] ALSA: hda/hdmi: add force-connect quirks for ASUSTeK Z170 variants Kai Vehmanen
2023-12-10 9:03 ` [PATCH 0/2] ALSA: hda/hdmi: add force-connect quirks Takashi Iwai
2 siblings, 0 replies; 4+ messages in thread
From: Kai Vehmanen @ 2023-12-08 13:21 UTC (permalink / raw)
To: linux-sound, tiwai
Cc: kai.vehmanen, alsa-devel, Ville Syrjälä, Jani Saarinen
Add one more older NUC model that requires quirk to force all pins to be
connected. The display codec pins are not registered properly without
the force-connect quirk. The codec will report only one pin as having
external connectivity, but i915 finds all three connectors on the
system, so the two drivers are not in sync.
Issue found with DRM igt-gpu-tools test kms_hdmi_inject@inject-audio.
Link: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/3
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Saarinen <jani.saarinen@intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
---
sound/pci/hda/patch_hdmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index dff2d7221982..88d7e037a57c 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1994,6 +1994,7 @@ static const struct snd_pci_quirk force_connect_list[] = {
SND_PCI_QUIRK(0x103c, 0x8711, "HP", 1),
SND_PCI_QUIRK(0x103c, 0x8715, "HP", 1),
SND_PCI_QUIRK(0x1462, 0xec94, "MS-7C94", 1),
+ SND_PCI_QUIRK(0x8086, 0x2060, "Intel NUC5CPYB", 1),
SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", 1),
{}
};
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ALSA: hda/hdmi: add force-connect quirks for ASUSTeK Z170 variants
2023-12-08 13:21 [PATCH 0/2] ALSA: hda/hdmi: add force-connect quirks Kai Vehmanen
2023-12-08 13:21 ` [PATCH 1/2] ALSA: hda/hdmi: add force-connect quirk for NUC5CPYB Kai Vehmanen
@ 2023-12-08 13:21 ` Kai Vehmanen
2023-12-10 9:03 ` [PATCH 0/2] ALSA: hda/hdmi: add force-connect quirks Takashi Iwai
2 siblings, 0 replies; 4+ messages in thread
From: Kai Vehmanen @ 2023-12-08 13:21 UTC (permalink / raw)
To: linux-sound, tiwai
Cc: kai.vehmanen, alsa-devel, Ville Syrjälä, Jani Saarinen
On ASUSTeK Z170M PLUS and Z170 PRO GAMING systems, the display codec
pins are not registered properly without the force-connect quirk. The
codec will report only one pin as having external connectivity, but i915
finds all three connectors on the system, so the two drivers are not
in sync.
Issue found with DRM igt-gpu-tools test kms_hdmi_inject@inject-audio.
Link: https://gitlab.freedesktop.org/drm/intel/-/issues/9801
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Saarinen <jani.saarinen@intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
---
sound/pci/hda/patch_hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 88d7e037a57c..200779296a1b 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1993,6 +1993,8 @@ static const struct snd_pci_quirk force_connect_list[] = {
SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1),
SND_PCI_QUIRK(0x103c, 0x8711, "HP", 1),
SND_PCI_QUIRK(0x103c, 0x8715, "HP", 1),
+ SND_PCI_QUIRK(0x1043, 0x86ae, "ASUS", 1), /* Z170 PRO */
+ SND_PCI_QUIRK(0x1043, 0x86c7, "ASUS", 1), /* Z170M PLUS */
SND_PCI_QUIRK(0x1462, 0xec94, "MS-7C94", 1),
SND_PCI_QUIRK(0x8086, 0x2060, "Intel NUC5CPYB", 1),
SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", 1),
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] ALSA: hda/hdmi: add force-connect quirks
2023-12-08 13:21 [PATCH 0/2] ALSA: hda/hdmi: add force-connect quirks Kai Vehmanen
2023-12-08 13:21 ` [PATCH 1/2] ALSA: hda/hdmi: add force-connect quirk for NUC5CPYB Kai Vehmanen
2023-12-08 13:21 ` [PATCH 2/2] ALSA: hda/hdmi: add force-connect quirks for ASUSTeK Z170 variants Kai Vehmanen
@ 2023-12-10 9:03 ` Takashi Iwai
2 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2023-12-10 9:03 UTC (permalink / raw)
To: Kai Vehmanen; +Cc: linux-sound, alsa-devel
On Fri, 08 Dec 2023 14:21:25 +0100,
Kai Vehmanen wrote:
>
> This series addresses problems seen on a few older Intel based
> systems as found by the DRM i915 CI and the inject-audio test.
>
> The patches in series have been separately tested on top
> of drm-tip at:
> https://patchwork.freedesktop.org/series/127515/
> https://patchwork.freedesktop.org/series/127305/
>
> Kai Vehmanen (2):
> ALSA: hda/hdmi: add force-connect quirk for NUC5CPYB
> ALSA: hda/hdmi: add force-connect quirks for ASUSTeK Z170 variants
Applied both patches now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-10 9:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-08 13:21 [PATCH 0/2] ALSA: hda/hdmi: add force-connect quirks Kai Vehmanen
2023-12-08 13:21 ` [PATCH 1/2] ALSA: hda/hdmi: add force-connect quirk for NUC5CPYB Kai Vehmanen
2023-12-08 13:21 ` [PATCH 2/2] ALSA: hda/hdmi: add force-connect quirks for ASUSTeK Z170 variants Kai Vehmanen
2023-12-10 9:03 ` [PATCH 0/2] ALSA: hda/hdmi: add force-connect quirks Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox