* [PATCH] fix cs420x MacPro 6,1 inverted jack detection
@ 2025-11-14 16:35 René Rebe
2025-11-17 16:17 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: René Rebe @ 2025-11-14 16:35 UTC (permalink / raw)
To: linux-sound; +Cc: Jaroslav Kysela, tiwai, Richard Fitzgerald
Turns out the Apple MacPro 6,1 trashcan also needs the inverted jack
detection like Mac mini patched, too.
Signed-off-by: René Rebe <rene@exactco.de>
diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c
index 06e046214a41..dcd58f0b8bdf 100644
--- a/sound/hda/codecs/cirrus/cs420x.c
+++ b/sound/hda/codecs/cirrus/cs420x.c
@@ -643,6 +643,7 @@ static const struct hda_quirk cs4208_fixup_tbl[] = {
static const struct hda_quirk cs4208_mac_fixup_tbl[] = {
SND_PCI_QUIRK(0x106b, 0x5e00, "MacBookPro 11,2", CS4208_MBP11),
SND_PCI_QUIRK(0x106b, 0x6c00, "MacMini 7,1", CS4208_MACMINI),
+ SND_PCI_QUIRK(0x106b, 0x7800, "MacPro 6,1", CS4208_MACMINI),
SND_PCI_QUIRK(0x106b, 0x7100, "MacBookAir 6,1", CS4208_MBA6),
SND_PCI_QUIRK(0x106b, 0x7200, "MacBookAir 6,2", CS4208_MBA6),
SND_PCI_QUIRK(0x106b, 0x7b00, "MacBookPro 12,1", CS4208_MBP11),
--
René Rebe, ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
https://exactco.de | https://t2linux.com | https://rene.rebe.de
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fix cs420x MacPro 6,1 inverted jack detection
2025-11-14 16:35 [PATCH] fix cs420x MacPro 6,1 inverted jack detection René Rebe
@ 2025-11-17 16:17 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-11-17 16:17 UTC (permalink / raw)
To: René Rebe; +Cc: linux-sound, Jaroslav Kysela, tiwai, Richard Fitzgerald
On Fri, 14 Nov 2025 17:35:41 +0100,
René Rebe wrote:
>
> Turns out the Apple MacPro 6,1 trashcan also needs the inverted jack
> detection like Mac mini patched, too.
>
> Signed-off-by: René Rebe <rene@exactco.de>
>
> diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c
> index 06e046214a41..dcd58f0b8bdf 100644
> --- a/sound/hda/codecs/cirrus/cs420x.c
> +++ b/sound/hda/codecs/cirrus/cs420x.c
> @@ -643,6 +643,7 @@ static const struct hda_quirk cs4208_fixup_tbl[] = {
> static const struct hda_quirk cs4208_mac_fixup_tbl[] = {
> SND_PCI_QUIRK(0x106b, 0x5e00, "MacBookPro 11,2", CS4208_MBP11),
> SND_PCI_QUIRK(0x106b, 0x6c00, "MacMini 7,1", CS4208_MACMINI),
> + SND_PCI_QUIRK(0x106b, 0x7800, "MacPro 6,1", CS4208_MACMINI),
> SND_PCI_QUIRK(0x106b, 0x7100, "MacBookAir 6,1", CS4208_MBA6),
> SND_PCI_QUIRK(0x106b, 0x7200, "MacBookAir 6,2", CS4208_MBA6),
> SND_PCI_QUIRK(0x106b, 0x7b00, "MacBookPro 12,1", CS4208_MBP11),
The table entries are sorted rather in PCI SSID order.
Could you try to put at the right position?
Also, please put a proper subject prefix, e.g. "ALSA: hda/cirrus: fix
cs420x MacPro ....".
thanks,
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-17 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-14 16:35 [PATCH] fix cs420x MacPro 6,1 inverted jack detection René Rebe
2025-11-17 16:17 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox