* [PATCH] ALSA: hda/realtek - Enable mute LED on HP Pavilion Laptop 15-eg100
@ 2025-05-29 5:54 SunOfLife1
2025-06-02 14:48 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: SunOfLife1 @ 2025-05-29 5:54 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: SunOfLife1, linux-sound, linux-kernel
The HP Pavilion Laptop 15-eg100 has Realtek HDA codec ALC287.
It needs the ALC287_FIXUP_HP_GPIO_LED quirk to enable the mute LED.
Signed-off-by: SunOfLife1 <sunoflife1.git@gmail.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index cd0d7ba7320e..0c09bcae2006 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10713,6 +10713,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8975, "HP EliteBook x360 840 Aero G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x897d, "HP mt440 Mobile Thin Client U74", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8981, "HP Elite Dragonfly G3", ALC245_FIXUP_CS35L41_SPI_4),
+ SND_PCI_QUIRK(0x103c, 0x898a, "HP Pavilion 15-eg100", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x898e, "HP EliteBook 835 G9", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x103c, 0x898f, "HP EliteBook 835 G9", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x103c, 0x8991, "HP EliteBook 845 G9", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
--
2.49.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ALSA: hda/realtek - Enable mute LED on HP Pavilion Laptop 15-eg100
2025-05-29 5:54 [PATCH] ALSA: hda/realtek - Enable mute LED on HP Pavilion Laptop 15-eg100 SunOfLife1
@ 2025-06-02 14:48 ` Takashi Iwai
2025-06-06 19:24 ` SunOfLife1
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2025-06-02 14:48 UTC (permalink / raw)
To: SunOfLife1; +Cc: Jaroslav Kysela, Takashi Iwai, linux-sound, linux-kernel
On Thu, 29 May 2025 07:54:26 +0200,
SunOfLife1 wrote:
>
> The HP Pavilion Laptop 15-eg100 has Realtek HDA codec ALC287.
> It needs the ALC287_FIXUP_HP_GPIO_LED quirk to enable the mute LED.
>
> Signed-off-by: SunOfLife1 <sunoflife1.git@gmail.com>
Could you give your Signed-off-by tag with a real name and resubmit?
It's a legal requirement for merging to the upstream.
thanks,
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ALSA: hda/realtek - Enable mute LED on HP Pavilion Laptop 15-eg100
2025-06-02 14:48 ` Takashi Iwai
@ 2025-06-06 19:24 ` SunOfLife1
2025-06-08 9:29 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: SunOfLife1 @ 2025-06-06 19:24 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: SunOfLife1, linux-sound, linux-kernel
Of course, thank you for notifying me. Is this better?
Signed-off-by: Yasmin Fitzgerald <sunoflife1.git@gmail.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index cd0d7ba7320e..0c09bcae2006 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10713,6 +10713,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8975, "HP EliteBook x360 840 Aero G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x897d, "HP mt440 Mobile Thin Client U74", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8981, "HP Elite Dragonfly G3", ALC245_FIXUP_CS35L41_SPI_4),
+ SND_PCI_QUIRK(0x103c, 0x898a, "HP Pavilion 15-eg100", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x898e, "HP EliteBook 835 G9", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x103c, 0x898f, "HP EliteBook 835 G9", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x103c, 0x8991, "HP EliteBook 845 G9", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
--
2.49.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ALSA: hda/realtek - Enable mute LED on HP Pavilion Laptop 15-eg100
2025-06-06 19:24 ` SunOfLife1
@ 2025-06-08 9:29 ` Takashi Iwai
2025-06-21 5:36 ` SunOfLife1
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2025-06-08 9:29 UTC (permalink / raw)
To: SunOfLife1; +Cc: Jaroslav Kysela, Takashi Iwai, linux-sound, linux-kernel
On Fri, 06 Jun 2025 21:24:59 +0200,
SunOfLife1 wrote:
>
> Of course, thank you for notifying me. Is this better?
>
> Signed-off-by: Yasmin Fitzgerald <sunoflife1.git@gmail.com>
Improved, but the patch description is missing now...
Please restore your original patch description and resubmit with the
proper sign-off.
thanks,
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ALSA: hda/realtek - Enable mute LED on HP Pavilion Laptop 15-eg100
2025-06-08 9:29 ` Takashi Iwai
@ 2025-06-21 5:36 ` SunOfLife1
2025-06-22 9:32 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: SunOfLife1 @ 2025-06-21 5:36 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: SunOfLife1, linux-sound, linux-kernel
Sorry about that! This is my first time doing anything like this. ^^;
I've restored the original patch description with the proper sign-off. Hopefully this is suitable now. :)
The HP Pavilion Laptop 15-eg100 has Realtek HDA codec ALC287.
It needs the ALC287_FIXUP_HP_GPIO_LED quirk to enable the mute LED.
Signed-off-by: Yasmin Fitzgerald <sunoflife1.git@gmail.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index cd0d7ba7320e..0c09bcae2006 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10713,6 +10713,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8975, "HP EliteBook x360 840 Aero G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x897d, "HP mt440 Mobile Thin Client U74", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8981, "HP Elite Dragonfly G3", ALC245_FIXUP_CS35L41_SPI_4),
+ SND_PCI_QUIRK(0x103c, 0x898a, "HP Pavilion 15-eg100", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x898e, "HP EliteBook 835 G9", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x103c, 0x898f, "HP EliteBook 835 G9", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x103c, 0x8991, "HP EliteBook 845 G9", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
--
2.49.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ALSA: hda/realtek - Enable mute LED on HP Pavilion Laptop 15-eg100
2025-06-21 5:36 ` SunOfLife1
@ 2025-06-22 9:32 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2025-06-22 9:32 UTC (permalink / raw)
To: SunOfLife1; +Cc: Jaroslav Kysela, Takashi Iwai, linux-sound, linux-kernel
On Sat, 21 Jun 2025 07:36:14 +0200,
SunOfLife1 wrote:
>
> Sorry about that! This is my first time doing anything like this. ^^;
> I've restored the original patch description with the proper sign-off. Hopefully this is suitable now. :)
>
>
> The HP Pavilion Laptop 15-eg100 has Realtek HDA codec ALC287.
> It needs the ALC287_FIXUP_HP_GPIO_LED quirk to enable the mute LED.
>
> Signed-off-by: Yasmin Fitzgerald <sunoflife1.git@gmail.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-06-22 9:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-29 5:54 [PATCH] ALSA: hda/realtek - Enable mute LED on HP Pavilion Laptop 15-eg100 SunOfLife1
2025-06-02 14:48 ` Takashi Iwai
2025-06-06 19:24 ` SunOfLife1
2025-06-08 9:29 ` Takashi Iwai
2025-06-21 5:36 ` SunOfLife1
2025-06-22 9:32 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox