Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>,
	ALOK TIWARI <alok.a.tiwari@oracle.com>,
	devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-sound@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v3 02/10] spi: sh-msiof: use dev in sh_msiof_spi_probe()
Date: Tue, 15 Apr 2025 23:02:32 +0000	[thread overview]
Message-ID: <87lds181vc.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAMuHMdU3ieWELcj8Z2zQRJ4gsjz25nK+CZi1qDJByUUS9f1teg@mail.gmail.com>


Hi Geert

> > sh_msiof_spi_probe() is using priv->dev everywhare,
> 
> everywhere

Grr, thank you for pointing it.

> > -       ret = devm_request_irq(&pdev->dev, i, sh_msiof_spi_irq, 0,
> > -                              dev_name(&pdev->dev), p);
> > +       ret = devm_request_irq(dev, i, sh_msiof_spi_irq, 0, dev_name(&pdev->dev), p);
> 
> Looks like you missed one instance ;-)

Because it can be 1 line now.

> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks


Thank you for your help !!

Best regards
---
Kuninori Morimoto

  reply	other threads:[~2025-04-15 23:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15  1:33 [PATCH v3 00/10] ASoC: add Renesas MSIOF sound driver Kuninori Morimoto
2025-04-15  1:33 ` [PATCH v3 01/10] dt-bindings: renesas,sh-msiof: Add MSIOF I2S Sound support Kuninori Morimoto
2025-04-15  7:30   ` Geert Uytterhoeven
2025-04-15 23:00     ` Kuninori Morimoto
2025-04-16 23:52       ` Kuninori Morimoto
2025-04-17  7:43         ` Geert Uytterhoeven
2025-04-17 22:31           ` Kuninori Morimoto
2025-04-22  7:46             ` Geert Uytterhoeven
2025-04-15  1:33 ` [PATCH v3 02/10] spi: sh-msiof: use dev in sh_msiof_spi_probe() Kuninori Morimoto
2025-04-15  8:06   ` Geert Uytterhoeven
2025-04-15 23:02     ` Kuninori Morimoto [this message]
2025-04-15  1:34 ` [PATCH v3 03/10] spi: sh-msiof: ignore driver probing if it was MSIOF Sound Kuninori Morimoto
2025-04-15  1:34 ` [PATCH v3 04/10] ASoC: renesas: rsnd: allow to use ADG as standalone Kuninori Morimoto
2025-04-15  1:34 ` [PATCH v3 05/10] ASoC: renesas: rsnd: care BRGA/BRGB select in rsnd_adg_clk_enable() Kuninori Morimoto
2025-04-15  1:34 ` [PATCH v3 06/10] ASoC: renesas: rsnd: enable to use "adg" clock Kuninori Morimoto
2025-04-15  1:34 ` [PATCH v3 07/10] ASoC: renesas: add MSIOF sound support Kuninori Morimoto
2025-04-15  8:11   ` Geert Uytterhoeven
2025-04-15  8:50   ` ALOK TIWARI
2025-04-15 23:04     ` Kuninori Morimoto
2025-04-16  8:21       ` Lad, Prabhakar
2025-04-15  1:34 ` [PATCH v3 08/10] arm64: dts: renesas: r8a779g0: tidyup MSIOF node name Kuninori Morimoto
2025-04-15  8:27   ` Geert Uytterhoeven
2025-04-15  1:34 ` [PATCH v3 09/10] arm64: dts: renesas: sparrow hawk: Add MSIOF Sound support Kuninori Morimoto
2025-04-15  1:34 ` [PATCH v3 10/10] arm64: defconfig: add Renesas MSIOF sound support Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lds181vc.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alok.a.tiwari@oracle.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=quic_msavaliy@quicinc.com \
    --cc=robh@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox