Re: [PATCH v3 07/10] ASoC: renesas: add MSIOF sound support

[ALOK TIWARI <alok.a.tiwari@oracle.com>]

Hi Morimoto-san,

Thanks for your patch!
Sorry, I did not ask you earlier.


On 15-04-2025 07:04, Kuninori Morimoto wrote:
> +	/* Check MSIOF as Sound mode or SPI mode */
> +	struct device_node *port __free(device_node) = of_graph_get_next_port(dev->of_node, NULL);
> +	if (!port)
> +		return -ENODEV;
> +
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res)
> +		return -ENODEV;
> +
> +	irq = platform_get_irq(pdev, 0);
> +	if (irq <= 0)
> +		return -ENODEV;

nit: -EINVAL will be more relevant here

> +
> +	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> +	if (!priv)
> +		return -ENODEV;

nit: not sure why -ENOMEM not return

> +
> +	priv->base = devm_ioremap_resource(dev, res);
> +	if (IS_ERR(priv->base))
> +		return PTR_ERR(priv->base);
> +
> +	ret = devm_request_irq(dev, irq, msiof_interrupt, 0, dev_name(dev), priv);
> +	if (ret)
> +		return ret;
> +
> +	priv->dev	= dev;
> +	priv->phy_addr	= res->start;
> +
> +	spin_lock_init(&priv->lock);
> +	platform_set_drvdata(pdev, priv);


Thanks,
Alok