Re: [PATCH v2?] ALSA: scarlett2: Add error check after retrieving PEQ filter values

Re: [PATCH v2?] ALSA: scarlett2: Add error check after retrieving PEQ filter values

[Markus Elfring]

> Add error check after retrieving PEQ filter values in scarlett2_update_filter_values
> that ensure function returns error if PEQ filter value retrieval fails

* It is usually preferred to end such a sentence with a dot, isn't it?

* Would you like to add any tags (like “Fixes” and “Cc”) accordingly?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n145


…
> ---
>  sound/usb/mixer_scarlett2.c | 3 +++

Please take version information better into account.

See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n321

* https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22


…
> +++ b/sound/usb/mixer_scarlett2.c
> @@ -5614,6 +5614,9 @@ static int scarlett2_update_filter_values(struct usb_mixer_interface *mixer)
>  			SCARLETT2_BIQUAD_COEFFS,
>  		peq_flt_values);
>
> +	if (err < 0)
> +		return err;
> +
>  	for (i = 0, dst_idx = 0; i < info->dsp_input_count; i++) {
…

May a blank line be omitted before the return value check?

Regards,
Markus

[PATCH v2] ALSA: scarlett2: Add error check after retrieving PEQ filter values

[Zhu Jun]

Add error check after retrieving PEQ filter values in scarlett2_update_filter_values
that ensure function returns error if PEQ filter value retrieval fails.

Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Cc: <stable@vger.kernel.org>
---
V1 -> V2: 
- commit wit a dot
- add tag "Cc"
- delete a blank before the return value check

 sound/usb/mixer_scarlett2.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/usb/mixer_scarlett2.c b/sound/usb/mixer_scarlett2.c
index 1150cf104985..4cddf84db631 100644
--- a/sound/usb/mixer_scarlett2.c
+++ b/sound/usb/mixer_scarlett2.c
@@ -5613,6 +5613,8 @@ static int scarlett2_update_filter_values(struct usb_mixer_interface *mixer)
 			info->peq_flt_total_count *
 			SCARLETT2_BIQUAD_COEFFS,
 		peq_flt_values);
+	if (err < 0)
+		return err;
 
 	for (i = 0, dst_idx = 0; i < info->dsp_input_count; i++) {
 		src_idx = i *
-- 
2.17.1

Re: [PATCH v2] ALSA: scarlett2: Add error check after retrieving PEQ filter values

[Markus Elfring]

…
> Cc: <stable@vger.kernel.org>

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n262


> ---
> V1 -> V2:
> - commit wit a dot

A dot was appended to a change description.


> - add tag "Cc"
…

Do you expect that the tag “Fixes” will be added by an other contributor finally?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n145

Regards,
Markus

Re: [PATCH v2] ALSA: scarlett2: Add error check after retrieving PEQ filter values

[Takashi Iwai]

On Wed, 09 Oct 2024 11:23:05 +0200,
Zhu Jun wrote:
> 
> Add error check after retrieving PEQ filter values in scarlett2_update_filter_values
> that ensure function returns error if PEQ filter value retrieval fails.
> 
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> Cc: <stable@vger.kernel.org>

Applied now (with additional Fixes tag).


thanks,

Takashi