* [PATCH] ALSA: firewire: fix inverted streaming speed between tx and rx streams
@ 2026-11-02 3:36 Takashi Sakamoto
2026-11-02 8:50 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Sakamoto @ 2026-11-02 3:36 UTC (permalink / raw)
To: tiwai; +Cc: linux-sound, linux1394-devel
ALSA firewire-tascam driver uses inverted streaming speed when reserving
isochronous resources between tx and rx streams.
Correct the streaming speeds. This has no impact on existing
functionality, as both streams are always reserved together when handling
PCM substreams.
Fixes: dbd0cf204fe6 ("ALSA: firewire-tascam: reserve resources for transferred isochronous packets at S400")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
sound/firewire/tascam/tascam-stream.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/firewire/tascam/tascam-stream.c b/sound/firewire/tascam/tascam-stream.c
index 4ecd151a46c1..462766946e94 100644
--- a/sound/firewire/tascam/tascam-stream.c
+++ b/sound/firewire/tascam/tascam-stream.c
@@ -287,10 +287,10 @@ static int keep_resources(struct snd_tscm *tscm, unsigned int rate,
if (stream == &tscm->tx_stream) {
resources = &tscm->tx_resources;
- speed = fw_parent_device(tscm->unit)->max_speed;
+ speed = SCODE_400;
} else {
resources = &tscm->rx_resources;
- speed = SCODE_400;
+ speed = fw_parent_device(tscm->unit)->max_speed;
}
err = amdtp_tscm_set_parameters(stream, rate);
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: firewire: fix inverted streaming speed between tx and rx streams
2026-11-02 3:36 [PATCH] ALSA: firewire: fix inverted streaming speed between tx and rx streams Takashi Sakamoto
@ 2026-11-02 8:50 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-11-02 8:50 UTC (permalink / raw)
To: Takashi Sakamoto; +Cc: tiwai, linux-sound, linux1394-devel
On Mon, 02 Nov 2026 04:36:52 +0100,
Takashi Sakamoto wrote:
>
> ALSA firewire-tascam driver uses inverted streaming speed when reserving
> isochronous resources between tx and rx streams.
>
> Correct the streaming speeds. This has no impact on existing
> functionality, as both streams are always reserved together when handling
> PCM substreams.
>
> Fixes: dbd0cf204fe6 ("ALSA: firewire-tascam: reserve resources for transferred isochronous packets at S400")
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-02 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-02 3:36 [PATCH] ALSA: firewire: fix inverted streaming speed between tx and rx streams Takashi Sakamoto
2026-11-02 8:50 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox