From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
notify@kernel.org
Subject: Re: [PATCH] ALSA: pcxhr: Share PLL frequency register calculation
Date: Fri, 12 Jun 2026 11:07:59 +0200 [thread overview]
Message-ID: <87mrx0i0sw.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260612-alsa-pcxhr-pll-helper-v1-1-c84ae2bd2e9b@gmail.com>
On Fri, 12 Jun 2026 05:43:55 +0200,
Cássio Gabriel wrote:
>
> The PCXHR and HR222 clock paths duplicate the PLL divider calculation and
> register encoding. The HR222 variant extends the same format with an
> additional range for rates above those supported by the older boards.
>
> Move the complete encoding into pcxhr_pll_freq_register() and pass each
> hardware path its existing maximum frequency. The additional encoding
> branch is unreachable with the older 110 kHz limit, so this preserves both
> paths' accepted ranges and generated register values while removing the
> duplicate implementation and its long-standing TODO.
>
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Applied to for-next branch now. Thanks.
Takashi
prev parent reply other threads:[~2026-06-12 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 3:43 [PATCH] ALSA: pcxhr: Share PLL frequency register calculation Cássio Gabriel
2026-06-12 9:07 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mrx0i0sw.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=notify@kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox