public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: virtio: drop an extaneous kernel-doc comment
@ 2026-02-16  5:59 Randy Dunlap
  2026-04-16 22:00 ` Randy Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2026-02-16  5:59 UTC (permalink / raw)
  To: linux-sound
  Cc: Randy Dunlap, Anton Yakovlev, Matias Ezequiel Vara Larsen,
	Michael S. Tsirkin, virtualization, Jaroslav Kysela, Takashi Iwai

Drop a kernel-doc struct comment since the struct member was removed.
This eliminates a kernel-doc warning when make W=1 is used.

virtio_pcm.h:65: warning: Excess struct member 'msg_last_enqueued'
 description in 'virtio_pcm_substream'

Fixes: fe981e67568c ("ALSA: virtio: use ack callback")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Anton Yakovlev <anton.yakovlev@opensynergy.com>
Cc: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux.dev
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org

 sound/virtio/virtio_pcm.h |    1 -
 1 file changed, 1 deletion(-)

--- linux-next-20251210.orig/sound/virtio/virtio_pcm.h
+++ linux-next-20251210/sound/virtio/virtio_pcm.h
@@ -37,7 +37,6 @@ struct virtio_pcm_msg;
  *             the device side at resume.
  * @msgs: Allocated I/O messages.
  * @nmsgs: Number of allocated I/O messages.
- * @msg_last_enqueued: Index of the last I/O message added to the virtqueue.
  * @msg_count: Number of pending I/O messages in the virtqueue.
  * @msg_empty: Notify when msg_count is zero.
  */

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: virtio: drop an extaneous kernel-doc comment
  2026-02-16  5:59 [PATCH] ALSA: virtio: drop an extaneous kernel-doc comment Randy Dunlap
@ 2026-04-16 22:00 ` Randy Dunlap
  2026-04-17  7:49   ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2026-04-16 22:00 UTC (permalink / raw)
  To: linux-sound
  Cc: Matias Ezequiel Vara Larsen, Michael S. Tsirkin, virtualization,
	Jaroslav Kysela, Takashi Iwai

ping.

On 2/15/26 9:59 PM, Randy Dunlap wrote:
> Drop a kernel-doc struct comment since the struct member was removed.
> This eliminates a kernel-doc warning when make W=1 is used.
> 
> virtio_pcm.h:65: warning: Excess struct member 'msg_last_enqueued'
>  description in 'virtio_pcm_substream'
> 
> Fixes: fe981e67568c ("ALSA: virtio: use ack callback")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Anton Yakovlev <anton.yakovlev@opensynergy.com>
> Cc: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: virtualization@lists.linux.dev
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: linux-sound@vger.kernel.org
> 
>  sound/virtio/virtio_pcm.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- linux-next-20251210.orig/sound/virtio/virtio_pcm.h
> +++ linux-next-20251210/sound/virtio/virtio_pcm.h
> @@ -37,7 +37,6 @@ struct virtio_pcm_msg;
>   *             the device side at resume.
>   * @msgs: Allocated I/O messages.
>   * @nmsgs: Number of allocated I/O messages.
> - * @msg_last_enqueued: Index of the last I/O message added to the virtqueue.
>   * @msg_count: Number of pending I/O messages in the virtqueue.
>   * @msg_empty: Notify when msg_count is zero.
>   */

-- 
~Randy


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: virtio: drop an extaneous kernel-doc comment
  2026-04-16 22:00 ` Randy Dunlap
@ 2026-04-17  7:49   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2026-04-17  7:49 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-sound, Matias Ezequiel Vara Larsen, Michael S. Tsirkin,
	virtualization, Jaroslav Kysela, Takashi Iwai

On Fri, 17 Apr 2026 00:00:17 +0200,
Randy Dunlap wrote:
> 
> ping.
> 
> On 2/15/26 9:59 PM, Randy Dunlap wrote:
> > Drop a kernel-doc struct comment since the struct member was removed.
> > This eliminates a kernel-doc warning when make W=1 is used.
> > 
> > virtio_pcm.h:65: warning: Excess struct member 'msg_last_enqueued'
> >  description in 'virtio_pcm_substream'
> > 
> > Fixes: fe981e67568c ("ALSA: virtio: use ack callback")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > ---
> > Cc: Anton Yakovlev <anton.yakovlev@opensynergy.com>
> > Cc: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > Cc: virtualization@lists.linux.dev
> > Cc: Jaroslav Kysela <perex@perex.cz>
> > Cc: Takashi Iwai <tiwai@suse.com>
> > Cc: linux-sound@vger.kernel.org
> > 
> >  sound/virtio/virtio_pcm.h |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > --- linux-next-20251210.orig/sound/virtio/virtio_pcm.h
> > +++ linux-next-20251210/sound/virtio/virtio_pcm.h
> > @@ -37,7 +37,6 @@ struct virtio_pcm_msg;
> >   *             the device side at resume.
> >   * @msgs: Allocated I/O messages.
> >   * @nmsgs: Number of allocated I/O messages.
> > - * @msg_last_enqueued: Index of the last I/O message added to the virtqueue.
> >   * @msg_count: Number of pending I/O messages in the virtqueue.
> >   * @msg_empty: Notify when msg_count is zero.
> >   */

Sorry, it slipped from my inbox, maybe it hit on a bad day :-<

Applied now this and another one for vx.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-17  7:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-16  5:59 [PATCH] ALSA: virtio: drop an extaneous kernel-doc comment Randy Dunlap
2026-04-16 22:00 ` Randy Dunlap
2026-04-17  7:49   ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox