Re: [PATCH] rename s1810c* to presonus_studio to get s1824c working

[Takashi Iwai <tiwai@suse.de>]

On Thu, 27 Feb 2025 07:43:08 +0100,
Amin Dandache wrote:
> 
> ---
>  sound/usb/Makefile                            |   2 +-
>  sound/usb/format.c                            |  12 +-
>  ...mixer_s1810c.c => mixer_presonus_studio.c} | 247 +++++++++---------
>  sound/usb/mixer_presonus_studio.h             |   8 +
>  sound/usb/mixer_quirks.c                      |  12 +-
>  sound/usb/mixer_s1810c.h                      |   7 -
>  sound/usb/quirks.c                            |   9 +-
>  7 files changed, 161 insertions(+), 136 deletions(-)
>  rename sound/usb/{mixer_s1810c.c => mixer_presonus_studio.c} (59%)
>  create mode 100644 sound/usb/mixer_presonus_studio.h
>  delete mode 100644 sound/usb/mixer_s1810c.h

First off, could you give the reason why you must rename the whole
stuff?  Is it just to add the support of a new device ID 194f:010d?
If so, we don't have to rename everything, but just keep using the
same function as is.  You can put simply a comment that the function
supports both devices, instead.

And, the patch should be formatted properly. You need a proper subject
prefix (e.g. "ALSA: usb-audio: ....."), then put more detailed patch
description texts.

Last but not least, most importantly, we need your Signed-off-by tag.
It's a legal requirement.

Could you address the above and resubmit?


thanks,

Takashi