[PATCH 1/1] ALSA: hda/realtek: Add mute LEDs quirk for HP Pavilion Plus 14-EW1XXX.

[PATCH 1/1] ALSA: hda/realtek: Add mute LEDs quirk for HP Pavilion Plus 14-EW1XXX.

[Volodymyr Lurin]

The HP Pavilion Plus 14-ew1xxx with subsystem ID 103c:0x8c31 needs the
ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT bit LED quirk to control speaker
mute LED and ALC245_FIXUP_HP_GPIO_LED quirk to control mic mute LED.

Define new ALC245_FIXUP_HP_PAVILION_14_EW1XXX_LEDS fixup that combine
existing COEF(ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT) and
GPIO (ALC245_FIXUP_HP_GPIO_LED) fixups. Add the missing quirk entry.

Tested on the affected hardware: both the mute and mic-mute key
LEDs respond correctly to the keyboard hotkeys after this change.

Based on tests, to control mute LED, it is sufficient to
flip coef bit #3. While ALC245_FIXUP_HP_X360_MUTE_LEDS works too
(combines ALC245_FIXUP_HP_MUTE_LED_COEFBIT and ALC245_FIXUP_HP_GPIO_LED),
it also flip coef bit #2, and side effect of this "flip" is not clear.
So separate chained quirk introduced to be of safe side.

Signed-off-by: Volodymyr Lurin <volodymyr.iurin@gmail.com>
---
 sound/hda/codecs/realtek/alc269.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 36d3bc23a2df..550cf976af6c 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -4463,6 +4463,7 @@ enum {
 	ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT,
 	ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT,
 	ALC245_FIXUP_HP_X360_MUTE_LEDS,
+	ALC245_FIXUP_HP_PAVILION_14_EW1XXX_LEDS,
 	ALC287_FIXUP_THINKPAD_I2S_SPK,
 	ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD,
 	ALC287_FIXUP_CS35L41_I2C_4_THINKPAD_ACPI,
@@ -7061,6 +7062,12 @@ static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC245_FIXUP_HP_GPIO_LED
 	},
+	[ALC245_FIXUP_HP_PAVILION_14_EW1XXX_LEDS] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = alc245_fixup_hp_mute_led_v2_coefbit,
+		.chained = true,
+		.chain_id = ALC245_FIXUP_HP_GPIO_LED
+	},
 	[ALC287_FIXUP_THINKPAD_I2S_SPK] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc287_fixup_bind_dacs,
@@ -7889,6 +7896,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8c2d, "HP Victus 15-fa1xxx (MB 8C2D)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8c2f, "HP Victus 15-fb2xxx", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8c30, "HP Victus 15-fb1xxx", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
+	SND_PCI_QUIRK(0x103c, 0x8c31, "HP Pavilion Plus Laptop 14-ew1xxx", ALC245_FIXUP_HP_PAVILION_14_EW1XXX_LEDS),
 	SND_PCI_QUIRK(0x103c, 0x8c3f, "HP Victus 15-fa1xxx (MB 8C3F)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8c46, "HP EliteBook 830 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8c47, "HP EliteBook 840 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
-- 
2.56.0

Re: [PATCH 1/1] ALSA: hda/realtek: Add mute LEDs quirk for HP Pavilion Plus 14-EW1XXX.

[Takashi Iwai]

On Thu, 22 Oct 2026 04:38:39 +0200,
Volodymyr Lurin wrote:
> 
> The HP Pavilion Plus 14-ew1xxx with subsystem ID 103c:0x8c31 needs the
> ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT bit LED quirk to control speaker
> mute LED and ALC245_FIXUP_HP_GPIO_LED quirk to control mic mute LED.
> 
> Define new ALC245_FIXUP_HP_PAVILION_14_EW1XXX_LEDS fixup that combine
> existing COEF(ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT) and
> GPIO (ALC245_FIXUP_HP_GPIO_LED) fixups. Add the missing quirk entry.
> 
> Tested on the affected hardware: both the mute and mic-mute key
> LEDs respond correctly to the keyboard hotkeys after this change.
> 
> Based on tests, to control mute LED, it is sufficient to
> flip coef bit #3. While ALC245_FIXUP_HP_X360_MUTE_LEDS works too
> (combines ALC245_FIXUP_HP_MUTE_LED_COEFBIT and ALC245_FIXUP_HP_GPIO_LED),
> it also flip coef bit #2, and side effect of this "flip" is not clear.
> So separate chained quirk introduced to be of safe side.
> 
> Signed-off-by: Volodymyr Lurin <volodymyr.iurin@gmail.com>

Applied now.  Thanks.


Takashi