* [PATCH] ALSA: lx6464es: fix a error handling in lx_hardware_open()
@ 2026-01-26 1:18 Haoxiang Li
2026-01-26 8:39 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Haoxiang Li @ 2026-01-26 1:18 UTC (permalink / raw)
To: perex, tiwai, andriy.shevchenko, phasta
Cc: linux-sound, linux-kernel, Haoxiang Li
In lx_hardware_open(), if lx_set_granularity() fails,
call lx_pipe_release() to release the resoueces.
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
---
sound/pci/lx6464es/lx6464es.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c
index 96df00db51d5..af8d614381b5 100644
--- a/sound/pci/lx6464es/lx6464es.c
+++ b/sound/pci/lx6464es/lx6464es.c
@@ -113,6 +113,7 @@ static int lx_hardware_open(struct lx6464es *chip,
if (err < 0) {
dev_err(chip->card->dev, "setting granularity to %ld failed\n",
period_size);
+ lx_pipe_release(chip, 0, is_capture);
return err;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: lx6464es: fix a error handling in lx_hardware_open()
2026-01-26 1:18 [PATCH] ALSA: lx6464es: fix a error handling in lx_hardware_open() Haoxiang Li
@ 2026-01-26 8:39 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-01-26 8:39 UTC (permalink / raw)
To: Haoxiang Li
Cc: perex, tiwai, andriy.shevchenko, phasta, linux-sound,
linux-kernel
On Mon, 26 Jan 2026 02:18:54 +0100,
Haoxiang Li wrote:
>
> In lx_hardware_open(), if lx_set_granularity() fails,
> call lx_pipe_release() to release the resoueces.
>
> Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Thanks for the patch. But beware that this isn't about the kernel
resource allocation or free, but rather the manipulation of the
chip-inside configuration. So there is no memory leak or such.
And, this doesn't look like the only place that leads to the
unbalanced / unexpected configuration, and we might need to address
all...
Takashi
> ---
> sound/pci/lx6464es/lx6464es.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c
> index 96df00db51d5..af8d614381b5 100644
> --- a/sound/pci/lx6464es/lx6464es.c
> +++ b/sound/pci/lx6464es/lx6464es.c
> @@ -113,6 +113,7 @@ static int lx_hardware_open(struct lx6464es *chip,
> if (err < 0) {
> dev_err(chip->card->dev, "setting granularity to %ld failed\n",
> period_size);
> + lx_pipe_release(chip, 0, is_capture);
> return err;
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-26 8:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-26 1:18 [PATCH] ALSA: lx6464es: fix a error handling in lx_hardware_open() Haoxiang Li
2026-01-26 8:39 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox