Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH] ALSA: tidyup SNDRV_PCM_TRIGGER_xxx numbering
@ 2024-11-13  1:17 Kuninori Morimoto
  2024-11-13  7:24 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2024-11-13  1:17 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: linux-sound

pcm.h has SNDRV_PCM_TRIGGER_xxx, but it is missing "2".
Fixup it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 include/sound/pcm.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/sound/pcm.h b/include/sound/pcm.h
index 0bf7d25434d7f..ef9cbeaf37849 100644
--- a/include/sound/pcm.h
+++ b/include/sound/pcm.h
@@ -97,11 +97,11 @@ struct snd_pcm_ops {
 
 #define SNDRV_PCM_TRIGGER_STOP		0
 #define SNDRV_PCM_TRIGGER_START		1
-#define SNDRV_PCM_TRIGGER_PAUSE_PUSH	3
-#define SNDRV_PCM_TRIGGER_PAUSE_RELEASE	4
-#define SNDRV_PCM_TRIGGER_SUSPEND	5
-#define SNDRV_PCM_TRIGGER_RESUME	6
-#define SNDRV_PCM_TRIGGER_DRAIN		7
+#define SNDRV_PCM_TRIGGER_PAUSE_PUSH	2
+#define SNDRV_PCM_TRIGGER_PAUSE_RELEASE	3
+#define SNDRV_PCM_TRIGGER_SUSPEND	4
+#define SNDRV_PCM_TRIGGER_RESUME	5
+#define SNDRV_PCM_TRIGGER_DRAIN		6
 
 #define SNDRV_PCM_POS_XRUN		((snd_pcm_uframes_t)-1)
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: tidyup SNDRV_PCM_TRIGGER_xxx numbering
  2024-11-13  1:17 [PATCH] ALSA: tidyup SNDRV_PCM_TRIGGER_xxx numbering Kuninori Morimoto
@ 2024-11-13  7:24 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-11-13  7:24 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Takashi Iwai, linux-sound

On Wed, 13 Nov 2024 02:17:25 +0100,
Kuninori Morimoto wrote:
> 
> pcm.h has SNDRV_PCM_TRIGGER_xxx, but it is missing "2".
> Fixup it.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Let's hope that these numbers are purely internal.

Applied now, thanks.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-13  7:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-13  1:17 [PATCH] ALSA: tidyup SNDRV_PCM_TRIGGER_xxx numbering Kuninori Morimoto
2024-11-13  7:24 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox