[PATCH] fix volume mute and mic mute LEDs on HP probook 0x8a74

[PATCH] fix volume mute and mic mute LEDs on HP probook 0x8a74

[fætalize]

> --- linux-6.8/sound/pci/hda/patch_realtek.c.orig 2024-03-11 11:59:02.989267710 +0000
> +++ linux-6.8/sound/pci/hda/patch_realtek.c 2024-03-11 11:54:16.764227013 +0000
> @@ -9890,6 +9890,7 @@ static const struct snd_pci_quirk alc269
> SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC q", ALC236_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87f1, "HP ProBook 630 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87f2, "HP ProBook 640 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),

Some probook models have a different board ID, which aren't encompassed by the patches. 
on my probook 440 g8, this patch fixed my LED lights which now activate correctly upon mute/unmute.

Signed-off-by: Valentine Altair <faetalize@pm.me>

Re: [PATCH] fix volume mute and mic mute LEDs on HP probook 0x8a74

[Takashi Iwai]

On Mon, 11 Mar 2024 14:05:55 +0100,
fætalize wrote:
> 
> > --- linux-6.8/sound/pci/hda/patch_realtek.c.orig 2024-03-11 11:59:02.989267710 +0000
> > +++ linux-6.8/sound/pci/hda/patch_realtek.c 2024-03-11 11:54:16.764227013 +0000
> > @@ -9890,6 +9890,7 @@ static const struct snd_pci_quirk alc269
> > SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> > SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> > + SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC q", ALC236_FIXUP_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x87f1, "HP ProBook 630 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x87f2, "HP ProBook 640 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> 
> Some probook models have a different board ID, which aren't encompassed by the patches. 
> on my probook 440 g8, this patch fixed my LED lights which now activate correctly upon mute/unmute.
> 
> Signed-off-by: Valentine Altair <faetalize@pm.me>

The fix looks trivial, but to be merged to the upstream, could you
resubmit in a proper format?
  https://docs.kernel.org/process/submitting-patches.html

Or, if it's too hard, I can fix by myself, as this is a really trivial
change, too.


thanks,

Takashi

Re: [PATCH] fix volume mute and mic mute LEDs on HP probook 0x8a74

[fætalize]

> The fix looks trivial, but to be merged to the upstream, could you
> resubmit in a proper format?
> https://docs.kernel.org/process/submitting-patches.html

Yes, I may. Could you please guide me, as I don't recognize what is not conforming to the proper format in my initial submission?
I'd like to learn. Also, do i do so in this thread as a reply, or as a new submission?

> Or, if it's too hard, I can fix by myself, as this is a really trivial
> change, too.

I do not wish to inconvenience you, and I do not think learning is too hard. So I wish to try. If however you believe it's better for you to do it yourself, then why not. I consent.

Thank you for your attention and efforts.

Re: [PATCH] fix volume mute and mic mute LEDs on HP probook 0x8a74

[Takashi Iwai]

On Mon, 11 Mar 2024 17:04:31 +0100,
fætalize wrote:
> 
> 
> > The fix looks trivial, but to be merged to the upstream, could you
> > resubmit in a proper format?
> > https://docs.kernel.org/process/submitting-patches.html
> 
> Yes, I may. Could you please guide me, as I don't recognize what is not conforming to the proper format in my initial submission?
> I'd like to learn. Also, do i do so in this thread as a reply, or as a new submission?

See the document above.  There is a section "The canonical patch
format".


HTH,

Takashi