From: Takashi Iwai <tiwai@suse.de>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: tiwai@suse.com, broonie@kernel.org, perex@perex.cz,
amadeuszx.slawinski@linux.intel.com, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: Ignore unsol events for cards being shut down
Date: Mon, 02 Jun 2025 16:49:11 +0200 [thread overview]
Message-ID: <87r002xkpk.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250530141309.2943404-1-cezary.rojewski@intel.com>
On Fri, 30 May 2025 16:13:09 +0200,
Cezary Rojewski wrote:
>
> For the classic snd_hda_intel driver, codec->card and bus->card point to
> the exact same thing. When snd_card_diconnect() fires, bus->shutdown is
> set thanks to azx_dev_disconnect(). card->shutdown is already set when
> that happens but both provide basically the same functionality.
>
> For the DSP snd_soc_avs driver where multiple codecs are located on
> multiple cards, bus->shutdown 'shortcut' is not sufficient. One codec
> card may be unregistered while other codecs are still operational.
> Proper check in form of card->shutdown must be used to verify whether
> the codec's card is being shut down.
>
> Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Thanks, applied now.
Takashi
prev parent reply other threads:[~2025-06-02 14:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 14:13 [PATCH] ALSA: hda: Ignore unsol events for cards being shut down Cezary Rojewski
2025-06-02 14:49 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r002xkpk.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox