[PATCH] ALSA: hda: Ignore unsol events for cards being shut down

[PATCH] ALSA: hda: Ignore unsol events for cards being shut down

[Cezary Rojewski]

For the classic snd_hda_intel driver, codec->card and bus->card point to
the exact same thing. When snd_card_diconnect() fires, bus->shutdown is
set thanks to azx_dev_disconnect(). card->shutdown is already set when
that happens but both provide basically the same functionality.

For the DSP snd_soc_avs driver where multiple codecs are located on
multiple cards, bus->shutdown 'shortcut' is not sufficient. One codec
card may be unregistered while other codecs are still operational.
Proper check in form of card->shutdown must be used to verify whether
the codec's card is being shut down.

Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
 sound/pci/hda/hda_bind.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/hda_bind.c b/sound/pci/hda/hda_bind.c
index 9521e5e0e6e6..fdc8f65c4199 100644
--- a/sound/pci/hda/hda_bind.c
+++ b/sound/pci/hda/hda_bind.c
@@ -44,7 +44,7 @@ static void hda_codec_unsol_event(struct hdac_device *dev, unsigned int ev)
 	struct hda_codec *codec = container_of(dev, struct hda_codec, core);
 
 	/* ignore unsol events during shutdown */
-	if (codec->bus->shutdown)
+	if (codec->card->shutdown || codec->bus->shutdown)
 		return;
 
 	/* ignore unsol events during system suspend/resume */
-- 
2.25.1

Re: [PATCH] ALSA: hda: Ignore unsol events for cards being shut down

[Takashi Iwai]

On Fri, 30 May 2025 16:13:09 +0200,
Cezary Rojewski wrote:
> 
> For the classic snd_hda_intel driver, codec->card and bus->card point to
> the exact same thing. When snd_card_diconnect() fires, bus->shutdown is
> set thanks to azx_dev_disconnect(). card->shutdown is already set when
> that happens but both provide basically the same functionality.
> 
> For the DSP snd_soc_avs driver where multiple codecs are located on
> multiple cards, bus->shutdown 'shortcut' is not sufficient. One codec
> card may be unregistered while other codecs are still operational.
> Proper check in form of card->shutdown must be used to verify whether
> the codec's card is being shut down.
> 
> Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>

Thanks, applied now.


Takashi