From: Takashi Iwai <tiwai@suse.de>
To: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Cc: lars@metafoo.de, perex@perex.cz, tiwai@suse.de,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: dmaengine: Check DMA submission errors
Date: Thu, 19 Nov 2026 13:56:11 +0100 [thread overview]
Message-ID: <87se0xugic.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261119073653.2632-1-sreekuttan2156239@gmail.com>
On Thu, 19 Nov 2026 08:36:53 +0100,
Sreeraj S Kurup wrote:
>
> The dmaengine_pcm_prepare_and_submit() function does not check
> the return value of dmaengine_submit().
>
> dmaengine_submit() can return a negative DMA cookie if the
> submission fails. However, the function currently returns
> success unconditionally.
>
> This makes the PCM trigger path believe that DMA has been
> successfully submitted, even when the submission has failed.
>
> Use dma_submit_error() to check the returned DMA cookie and
> propagate the error to the caller.
>
> This ensures that DMA submission failures are properly
> reported instead of allowing the PCM stream to continue
> as if the DMA transfer had started successfully.
>
> Fixes: e7f73a161356 ("ASoC: Add dmaengine PCM helper functions")
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-11-19 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 7:10 [PATCH] ALSA: dmaengine: Check DMA submission errors Sreeraj S Kurup
2026-11-19 7:16 ` sashiko-bot
2026-11-19 7:36 ` [PATCH v2] " Sreeraj S Kurup
2026-11-19 12:56 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87se0xugic.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sreekuttan2156239@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox