[PATCH 0/2] Implement jack detection for HP Thunderbolt Dock G2

[PATCH 0/2] Implement jack detection for HP Thunderbolt Dock G2

[Tasos Sahanidis]

This series adds jack detection support for the HP Thunderbolt Dock G2.

The first patch modifies the existing realtek quirk for the Dell WD15/19
docks to allow changing the commands/algorithm used for jack detection.

The second patch implements the detection for the HP dock.

This series was tested against both a WD19TB, with no regressions, and
an HP TB Dock G2 without the optional USB speaker audio module. The
module shows up as an additional USB device, so this should not affect
its functionality.

Tasos Sahanidis (2):
  ALSA: usb-audio: Modularize realtek_add_jack in mixer_quirks
  ALSA: usb-audio: Implement jack detection for HP Thunderbolt Dock G2

 sound/usb/mixer_quirks.c | 122 ++++++++++++++++++++++++++++++++++++---
 1 file changed, 115 insertions(+), 7 deletions(-)

-- 
2.43.0

[PATCH 1/2] ALSA: usb-audio: Modularize realtek_add_jack in mixer_quirks

[Tasos Sahanidis]

Modify the realtek_add_jack function used for the jack detection quirk
to allow passing the mixer unit id and an snd_kcontrol_new.

This allows adding additional devices that require the same quirk, but
implement jack detection with different commands.

Signed-off-by: Tasos Sahanidis <tasos@tasossah.com>
---
 sound/usb/mixer_quirks.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
index 828af3095b86..a48eb3b8cab2 100644
--- a/sound/usb/mixer_quirks.c
+++ b/sound/usb/mixer_quirks.c
@@ -2277,7 +2277,8 @@ static int realtek_resume_jack(struct usb_mixer_elem_list *list)
 }
 
 static int realtek_add_jack(struct usb_mixer_interface *mixer,
-			    char *name, u32 val)
+			    char *name, u32 val, int unitid,
+			    const struct snd_kcontrol_new *kctl_new)
 {
 	struct usb_mixer_elem_info *cval;
 	struct snd_kcontrol *kctl;
@@ -2285,14 +2286,13 @@ static int realtek_add_jack(struct usb_mixer_interface *mixer,
 	cval = kzalloc(sizeof(*cval), GFP_KERNEL);
 	if (!cval)
 		return -ENOMEM;
-	snd_usb_mixer_elem_init_std(&cval->head, mixer,
-				    REALTEK_JACK_INTERRUPT_NODE);
+	snd_usb_mixer_elem_init_std(&cval->head, mixer, unitid);
 	cval->head.resume = realtek_resume_jack;
 	cval->val_type = USB_MIXER_BOOLEAN;
 	cval->channels = 1;
 	cval->min = 0;
 	cval->max = 1;
-	kctl = snd_ctl_new1(&realtek_connector_ctl_ro, cval);
+	kctl = snd_ctl_new1(kctl_new, cval);
 	if (!kctl) {
 		kfree(cval);
 		return -ENOMEM;
@@ -2322,14 +2322,20 @@ static int dell_dock_mixer_create(struct usb_mixer_interface *mixer)
 			USB_RECIP_DEVICE | USB_TYPE_VENDOR | USB_DIR_OUT,
 			0, 0, NULL, 0);
 
-	err = realtek_add_jack(mixer, "Line Out Jack", REALTEK_LINE1);
+	err = realtek_add_jack(mixer, "Line Out Jack", REALTEK_LINE1,
+			       REALTEK_JACK_INTERRUPT_NODE,
+			       &realtek_connector_ctl_ro);
 	if (err < 0)
 		return err;
-	err = realtek_add_jack(mixer, "Headphone Jack", REALTEK_HP_OUT);
+	err = realtek_add_jack(mixer, "Headphone Jack", REALTEK_HP_OUT,
+			       REALTEK_JACK_INTERRUPT_NODE,
+			       &realtek_connector_ctl_ro);
 	if (err < 0)
 		return err;
 	err = realtek_add_jack(mixer, "Headset Mic Jack",
-			       REALTEK_HP_OUT | REALTEK_MIC_FLAG);
+			       REALTEK_HP_OUT | REALTEK_MIC_FLAG,
+			       REALTEK_JACK_INTERRUPT_NODE,
+			       &realtek_connector_ctl_ro);
 	if (err < 0)
 		return err;
 	return 0;
-- 
2.43.0

[PATCH 2/2] ALSA: usb-audio: Implement jack detection for HP Thunderbolt Dock G2

[Tasos Sahanidis]

The HP Thunderbolt Dock G2 includes a headset jack with support for
jack detection. However, this being a UAC1 device, detection is
implemented via vendor-defined URB Controls.

Implement it in a similar way to the Dell WD15/19 docks, but with
different commands.

Signed-off-by: Tasos Sahanidis <tasos@tasossah.com>
---
 sound/usb/mixer_quirks.c | 102 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 102 insertions(+)

diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
index a48eb3b8cab2..fe6c2cebc7f0 100644
--- a/sound/usb/mixer_quirks.c
+++ b/sound/usb/mixer_quirks.c
@@ -2363,6 +2363,105 @@ static int dell_dock_mixer_init(struct usb_mixer_interface *mixer)
 	return 0;
 }
 
+/*
+ * HP Thunderbolt Dock G2 jack detection
+ *
+ * Similar to the Dell WD15/WD19, but with different commands.
+ */
+
+#define HP_DOCK_JACK_INTERRUPT_NODE	7
+
+#define HP_DOCK_GET			37
+
+#define HP_DOCK_JACK_PRESENCE		0xffb8
+#define HP_DOCK_JACK_PRESENCE_BIT	BIT(2)
+
+#define HP_DOCK_MIC_SENSE		0xf753
+#define HP_DOCK_MIC_SENSE_COMPLETE_BIT	BIT(4)
+
+#define HP_DOCK_MIC_SENSE_MASK		(BIT(2) | BIT(1) | BIT(0))
+/* #define HP_DOCK_MIC_SENSE_PRESENT	0x2 */
+#define HP_DOCK_MIC_SENSE_NOT_PRESENT	0x4
+
+static int hp_dock_ctl_connector_get(struct snd_kcontrol *kcontrol,
+				     struct snd_ctl_elem_value *ucontrol)
+{
+	struct usb_mixer_elem_info *cval = snd_kcontrol_chip(kcontrol);
+	struct snd_usb_audio *chip = cval->head.mixer->chip;
+	u32 pv = kcontrol->private_value;
+	bool presence;
+	int err;
+	u8 buf;
+
+	CLASS(snd_usb_lock, pm)(chip);
+	if (pm.err < 0)
+		return pm.err;
+
+	err = snd_usb_ctl_msg(chip->dev, usb_rcvctrlpipe(chip->dev, 0),
+		       HP_DOCK_GET,
+		       USB_RECIP_DEVICE | USB_TYPE_VENDOR | USB_DIR_IN,
+		       0, HP_DOCK_JACK_PRESENCE, &buf, sizeof(buf));
+	if (err < 0)
+		return err;
+
+	presence = !(buf & HP_DOCK_JACK_PRESENCE_BIT);
+
+	if (pv && presence) {
+		for (int i = 0; i < 20; i++) {
+			err = snd_usb_ctl_msg(chip->dev, usb_rcvctrlpipe(chip->dev, 0),
+			       HP_DOCK_GET,
+			       USB_RECIP_DEVICE | USB_TYPE_VENDOR | USB_DIR_IN,
+			       0, HP_DOCK_MIC_SENSE, &buf, sizeof(buf));
+			if (err < 0)
+				return err;
+
+			/* Mic sense is complete, we have a result. */
+			if (buf & HP_DOCK_MIC_SENSE_COMPLETE_BIT)
+				break;
+
+			msleep(100);
+		}
+
+		/*
+		 * If we reach the retry limit without mic sense having
+		 * completed, buf will contain HP_DOCK_MIC_SENSE_PRESENT,
+		 * thus presence remains true even when detection fails.
+		 */
+		if ((buf & HP_DOCK_MIC_SENSE_MASK) == HP_DOCK_MIC_SENSE_NOT_PRESENT)
+			presence = false;
+	}
+	ucontrol->value.integer.value[0] = presence;
+	return 0;
+}
+
+static const struct snd_kcontrol_new hp_dock_connector_ctl_ro = {
+	.iface = SNDRV_CTL_ELEM_IFACE_CARD,
+	.name = "", /* will be filled later manually */
+	.access = SNDRV_CTL_ELEM_ACCESS_READ,
+	.info = snd_ctl_boolean_mono_info,
+	.get = hp_dock_ctl_connector_get,
+};
+
+static int hp_dock_mixer_create(struct usb_mixer_interface *mixer)
+{
+	int err;
+
+	err = realtek_add_jack(mixer, "Headsets Playback Jack", 0,
+			       HP_DOCK_JACK_INTERRUPT_NODE,
+			       &hp_dock_connector_ctl_ro);
+	if (err < 0)
+		return err;
+
+	err = realtek_add_jack(mixer, "Headset Capture Jack", 1,
+			       HP_DOCK_JACK_INTERRUPT_NODE,
+			       &hp_dock_connector_ctl_ro);
+	if (err < 0)
+		return err;
+
+	return 0;
+}
+
+
 /* RME Class Compliant device quirks */
 
 #define SND_RME_GET_STATUS1			23
@@ -4414,6 +4513,9 @@ int snd_usb_mixer_apply_create_quirk(struct usb_mixer_interface *mixer)
 	case USB_ID(0x2b73, 0x0034): /* Pioneer DJ DJM-V10 */
 		err = snd_djm_controls_create(mixer, SND_DJM_V10_IDX);
 		break;
+	case USB_ID(0x03f0, 0x0269): /* HP TB Dock G2 */
+		err = hp_dock_mixer_create(mixer);
+		break;
 	}
 
 	return err;
-- 
2.43.0

Re: [PATCH 0/2] Implement jack detection for HP Thunderbolt Dock G2

[Cryolitia PukNgae]

On 26/11/2025 08.29, Tasos Sahanidis wrote:
> This series adds jack detection support for the HP Thunderbolt Dock G2.
> 
> The first patch modifies the existing realtek quirk for the Dell WD15/19
> docks to allow changing the commands/algorithm used for jack detection.

Does the HP Thunderbolt Dock G2 use a realtek chip?

> The second patch implements the detection for the HP dock.
> 
> This series was tested against both a WD19TB, with no regressions, and
> an HP TB Dock G2 without the optional USB speaker audio module. The
> module shows up as an additional USB device, so this should not affect
> its functionality.
> 
> Tasos Sahanidis (2):
>   ALSA: usb-audio: Modularize realtek_add_jack in mixer_quirks
>   ALSA: usb-audio: Implement jack detection for HP Thunderbolt Dock G2
> 
>  sound/usb/mixer_quirks.c | 122 ++++++++++++++++++++++++++++++++++++---
>  1 file changed, 115 insertions(+), 7 deletions(-)
> 

thanks

Best regards,
Cryolitia PukNgae

Re: [PATCH 0/2] Implement jack detection for HP Thunderbolt Dock G2

[Tasos Sahanidis]

On 2025-11-26 04:58, Cryolitia PukNgae wrote:
> 
> 
> On 26/11/2025 08.29, Tasos Sahanidis wrote:
>> This series adds jack detection support for the HP Thunderbolt Dock G2.
>>
>> The first patch modifies the existing realtek quirk for the Dell WD15/19
>> docks to allow changing the commands/algorithm used for jack detection.
> 
> Does the HP Thunderbolt Dock G2 use a realtek chip?

Yes, it does. When plugged in, it loads RtUsbA64.sys.

Looking up a teardown online, it appears to be an ALC4102, however I
could not locate any public information about it. The only other Realtek
IC in the dock is the NIC (RTL8153).

lsusb doesn't reveal much, either:
  idVendor           0x03f0 HP, Inc
  idProduct          0x0269 USB Audio
  bcdDevice            0.17
  iManufacturer           3 Generic
  iProduct                1 USB Audio

I am unsure if this is an HP specific jack implementation (in firmware)
or if Realtek changed it for some devices.

>> The second patch implements the detection for the HP dock.
>>
>> This series was tested against both a WD19TB, with no regressions, and
>> an HP TB Dock G2 without the optional USB speaker audio module. The
>> module shows up as an additional USB device, so this should not affect
>> its functionality.
>>
>> Tasos Sahanidis (2):
>>   ALSA: usb-audio: Modularize realtek_add_jack in mixer_quirks
>>   ALSA: usb-audio: Implement jack detection for HP Thunderbolt Dock G2
>>
>>  sound/usb/mixer_quirks.c | 122 ++++++++++++++++++++++++++++++++++++---
>>  1 file changed, 115 insertions(+), 7 deletions(-)
>>
> 
> thanks
> 
> Best regards,
> Cryolitia PukNgae
> 

Re: [PATCH 0/2] Implement jack detection for HP Thunderbolt Dock G2

[Cryolitia PukNgae]

On 26/11/2025 11.36, Tasos Sahanidis wrote:
> On 2025-11-26 04:58, Cryolitia PukNgae wrote:
>>
>>
>> On 26/11/2025 08.29, Tasos Sahanidis wrote:
>>> This series adds jack detection support for the HP Thunderbolt Dock G2.
>>>
>>> The first patch modifies the existing realtek quirk for the Dell WD15/19
>>> docks to allow changing the commands/algorithm used for jack detection.
>>
>> Does the HP Thunderbolt Dock G2 use a realtek chip?
> 
> Yes, it does. When plugged in, it loads RtUsbA64.sys.
> 
> Looking up a teardown online, it appears to be an ALC4102, however I
> could not locate any public information about it. The only other Realtek
> IC in the dock is the NIC (RTL8153).
> 
> lsusb doesn't reveal much, either:
>   idVendor           0x03f0 HP, Inc
>   idProduct          0x0269 USB Audio
>   bcdDevice            0.17
>   iManufacturer           3 Generic
>   iProduct                1 USB Audio
> 
> I am unsure if this is an HP specific jack implementation (in firmware)
> or if Realtek changed it for some devices.

The ALC4102 is widely used in a wide variety of devices. As far as I know,
this chip has programmable firmware that allows downstream manufacturers
to customize its behavior. I'm curious to what extent this jack detection
implementation can be generalized to other devices that also use the
ALC4102. Perhaps we can examine its behavior under operating systems like
Windows? Does Windows have a similar jack detection function, and is this
function provided by HP or Realtek's driver?

>>> The second patch implements the detection for the HP dock.
>>>
>>> This series was tested against both a WD19TB, with no regressions, and
>>> an HP TB Dock G2 without the optional USB speaker audio module. The
>>> module shows up as an additional USB device, so this should not affect
>>> its functionality.
>>>
>>> Tasos Sahanidis (2):
>>>   ALSA: usb-audio: Modularize realtek_add_jack in mixer_quirks
>>>   ALSA: usb-audio: Implement jack detection for HP Thunderbolt Dock G2
>>>
>>>  sound/usb/mixer_quirks.c | 122 ++++++++++++++++++++++++++++++++++++---
>>>  1 file changed, 115 insertions(+), 7 deletions(-)
>>>
>>
>> thanks
>>
>> Best regards,
>> Cryolitia PukNgae
>>
> 
> 

thanks

Best regards,
Cryolitia PukNgae

Re: [PATCH 0/2] Implement jack detection for HP Thunderbolt Dock G2

[Tasos Sahanidis]

On 2025-11-26 07:40, Cryolitia PukNgae wrote:
> 
> 
> On 26/11/2025 11.36, Tasos Sahanidis wrote:
>> On 2025-11-26 04:58, Cryolitia PukNgae wrote:
>>>
>>>
>>> On 26/11/2025 08.29, Tasos Sahanidis wrote:
>>>> This series adds jack detection support for the HP Thunderbolt Dock G2.
>>>>
>>>> The first patch modifies the existing realtek quirk for the Dell WD15/19
>>>> docks to allow changing the commands/algorithm used for jack detection.
>>>
>>> Does the HP Thunderbolt Dock G2 use a realtek chip?
>>
>> Yes, it does. When plugged in, it loads RtUsbA64.sys.
>>
>> Looking up a teardown online, it appears to be an ALC4102, however I
>> could not locate any public information about it. The only other Realtek
>> IC in the dock is the NIC (RTL8153).
>>
>> lsusb doesn't reveal much, either:
>>   idVendor           0x03f0 HP, Inc
>>   idProduct          0x0269 USB Audio
>>   bcdDevice            0.17
>>   iManufacturer           3 Generic
>>   iProduct                1 USB Audio
>>
>> I am unsure if this is an HP specific jack implementation (in firmware)
>> or if Realtek changed it for some devices.
> 
> The ALC4102 is widely used in a wide variety of devices. As far as I know,
> this chip has programmable firmware that allows downstream manufacturers
> to customize its behavior. I'm curious to what extent this jack detection
> implementation can be generalized to other devices that also use the
> ALC4102. Perhaps we can examine its behavior under operating systems like
> Windows? Does Windows have a similar jack detection function, and is this
> function provided by HP or Realtek's driver?
This was implemented by observing the driver's behaviour on Windows.

The driver is provided by Realtek, not HP, however the inf contains the
HP ven/dev pair. The generic Windows USB driver does not support jack
detection. It only works with the Realtek one, which you can find by
searching for "VID_03F0&PID_0269" in the Microsoft Update Catalog.

Unfortunately I do not have any other devices with an ALC4102 to check
if this works against them. I believe the only way to tell if it can be
generalised is to observe what happens with other devices (by other
vendors integrating the ALC4102) on Windows. I would certainly not
enable this blindly.

It is worth noting that the Dell Realtek detection is considerably
distinct (4 byte vs 1 byte Control buffers, different bRequest and
wIndex, no waiting for mic sense to return a result).

Re: [PATCH 0/2] Implement jack detection for HP Thunderbolt Dock G2

[Takashi Iwai]

On Wed, 26 Nov 2025 01:29:55 +0100,
Tasos Sahanidis wrote:
> 
> This series adds jack detection support for the HP Thunderbolt Dock G2.
> 
> The first patch modifies the existing realtek quirk for the Dell WD15/19
> docks to allow changing the commands/algorithm used for jack detection.
> 
> The second patch implements the detection for the HP dock.
> 
> This series was tested against both a WD19TB, with no regressions, and
> an HP TB Dock G2 without the optional USB speaker audio module. The
> module shows up as an additional USB device, so this should not affect
> its functionality.
> 
> Tasos Sahanidis (2):
>   ALSA: usb-audio: Modularize realtek_add_jack in mixer_quirks
>   ALSA: usb-audio: Implement jack detection for HP Thunderbolt Dock G2

Applied both patches to for-next branch now.  Thanks.


Takashi