* [PATCH] ALSA: hda/realtek: Remove needless comment lines
@ 2024-12-04 9:39 Yongzhen Zhang
2024-12-04 9:43 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Yongzhen Zhang @ 2024-12-04 9:39 UTC (permalink / raw)
To: perex, tiwai, linux-sound; +Cc: kailang, Yongzhen Zhang
-/*
- */
-
Signed-off-by: Yongzhen Zhang <zhangyongzhen@kylinos.cn>
---
sound/pci/hda/patch_realtek.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4ba9e647250b..b73b1a51a23d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -890,9 +890,6 @@ static void alc_ssid_check(struct hda_codec *codec, const hda_nid_t *ports)
}
}
-/*
- */
-
static void alc_fixup_inv_dmic(struct hda_codec *codec,
const struct hda_fixup *fix, int action)
{
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ALSA: hda/realtek: Remove needless comment lines
2024-12-04 9:39 [PATCH] ALSA: hda/realtek: Remove needless comment lines Yongzhen Zhang
@ 2024-12-04 9:43 ` Takashi Iwai
2024-12-23 8:47 ` [PATCH v2] ALSA: hda/realtek: Add a comment for alc_fixup_inv_dmic() Yongzhen Zhang
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2024-12-04 9:43 UTC (permalink / raw)
To: Yongzhen Zhang; +Cc: perex, tiwai, linux-sound, kailang
On Wed, 04 Dec 2024 10:39:28 +0100,
Yongzhen Zhang wrote:
>
> -/*
> - */
> -
Too cryptic description :)
And, instead of removing, better to put proper comment instead.
thanks,
Takashi
>
> Signed-off-by: Yongzhen Zhang <zhangyongzhen@kylinos.cn>
> ---
> sound/pci/hda/patch_realtek.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 4ba9e647250b..b73b1a51a23d 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -890,9 +890,6 @@ static void alc_ssid_check(struct hda_codec *codec, const hda_nid_t *ports)
> }
> }
>
> -/*
> - */
> -
> static void alc_fixup_inv_dmic(struct hda_codec *codec,
> const struct hda_fixup *fix, int action)
> {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] ALSA: hda/realtek: Add a comment for alc_fixup_inv_dmic()
2024-12-04 9:43 ` Takashi Iwai
@ 2024-12-23 8:47 ` Yongzhen Zhang
2024-12-29 8:21 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Yongzhen Zhang @ 2024-12-23 8:47 UTC (permalink / raw)
To: tiwai; +Cc: kailang, linux-sound, perex, tiwai, zhangyongzhen
alc_fixup_inv_dmic() has an empty comment line above it,
add a comment here.
Signed-off-by: Yongzhen Zhang <zhangyongzhen@kylinos.cn>
---
sound/pci/hda/patch_realtek.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 61ba5dc35b8b..46e542581809 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -890,9 +890,7 @@ static void alc_ssid_check(struct hda_codec *codec, const hda_nid_t *ports)
}
}
-/*
- */
-
+/* inverted digital-mic */
static void alc_fixup_inv_dmic(struct hda_codec *codec,
const struct hda_fixup *fix, int action)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-29 8:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-04 9:39 [PATCH] ALSA: hda/realtek: Remove needless comment lines Yongzhen Zhang
2024-12-04 9:43 ` Takashi Iwai
2024-12-23 8:47 ` [PATCH v2] ALSA: hda/realtek: Add a comment for alc_fixup_inv_dmic() Yongzhen Zhang
2024-12-29 8:21 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox