Re: [PATCH 2/2] ASoC: dt-bindings: simple-audio-mux: add mux-names property

[Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>]

Hi Krzysztof, Mark

> > > Current simple-audio-mux selects MUX by "Input 1" or "Input 2",
> > > it is not user friendly. Adds new "mux-names" property and enable to
> > > select MUX by own names.
> 
> > > +  mux-names:
> > > +    description: |
> > > +      Name of multiplexers. default is "Input 1", "Input 2"
> 
> > I have troubles with this binding... It seems driver expects only one
> > GPIO, but the binding allows any number. Similarly mux-names...
> 
> > Anyway, this does not look like hardware description but rather
> > configuration of driver. What's wrong with input 1 or mux 1 or whatever
> > is there for default?
> 
> I would expect that when this driver is deployed it would mainly be for
> selecting between things like microphone inputs that are defined and
> labelled as part of the system hardware design.  Using numbered inputs
> would *work* but it's not great for usability so I do see a use case for
> labels.  Possibly we could figure something out by walking the graph but
> that seems quite hard, possibly unreasonably so.

Thank you for explaning, Mark

I noticed that the property naming is not so good.
I will fix property name and git-log, and re-post v2.

Thank you for your help !!

Best regards
---
Kuninori Morimoto