Re: [PATCH 2/2] ASoC: dt-bindings: simple-audio-mux: add mux-names property

[Krzysztof Kozlowski <krzk@kernel.org>]

On 27/06/2024 05:52, Kuninori Morimoto wrote:
> Current simple-audio-mux selects MUX by "Input 1" or "Input 2",
> it is not user friendly. Adds new "mux-names" property and enable to
> select MUX by own names.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  Documentation/devicetree/bindings/sound/simple-audio-mux.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml b/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml
> index 9f319caf3db7..6e4018936887 100644
> --- a/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml
> +++ b/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml
> @@ -24,6 +24,10 @@ properties:
>      description: |
>        GPIOs used to select the input line.
>  
> +  mux-names:
> +    description: |
> +      Name of multiplexers. default is "Input 1", "Input 2"
> +

I have troubles with this binding... It seems driver expects only one
GPIO, but the binding allows any number. Similarly mux-names...

Anyway, this does not look like hardware description but rather
configuration of driver. What's wrong with input 1 or mux 1 or whatever
is there for default?

Also: extend the example.

Best regards,
Krzysztof