* [PATCH] ALSA: aaci: Delete unused variable in aaci_do_suspend
@ 2024-03-12 11:22 Thomas Weißschuh
2024-03-12 11:31 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Weißschuh @ 2024-03-12 11:22 UTC (permalink / raw)
To: Russell King, Jaroslav Kysela, Takashi Iwai
Cc: linux-sound, linux-kernel, Thomas Weißschuh
The variable aaci is not used anymore and can be deleted.
Fixes: 792a6c51875c ("[ALSA] Fix PM support")
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
Note: This only seems to trigger with the series
"ALSA: Clean up with DEFINE_SIMPLE_DEV_PM_OPS()" applied.
(Encountered on next-20240312)
[0] https://lore.kernel.org/all/20240207155140.18238-1-tiwai@suse.de/
---
sound/arm/aaci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/arm/aaci.c b/sound/arm/aaci.c
index 0817ad21af74..2bfffdd33864 100644
--- a/sound/arm/aaci.c
+++ b/sound/arm/aaci.c
@@ -740,7 +740,6 @@ static const struct snd_pcm_ops aaci_capture_ops = {
#ifdef CONFIG_PM
static int aaci_do_suspend(struct snd_card *card)
{
- struct aaci *aaci = card->private_data;
snd_power_change_state(card, SNDRV_CTL_POWER_D3cold);
return 0;
}
---
base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72
change-id: 20240312-aaci-unused-d74171092e50
Best regards,
--
Thomas Weißschuh <thomas.weissschuh@linutronix.de>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: aaci: Delete unused variable in aaci_do_suspend
2024-03-12 11:22 [PATCH] ALSA: aaci: Delete unused variable in aaci_do_suspend Thomas Weißschuh
@ 2024-03-12 11:31 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-03-12 11:31 UTC (permalink / raw)
To: Thomas Weißschuh
Cc: Russell King, Jaroslav Kysela, Takashi Iwai, linux-sound,
linux-kernel
On Tue, 12 Mar 2024 12:22:28 +0100,
Thomas Weißschuh wrote:
>
> The variable aaci is not used anymore and can be deleted.
>
> Fixes: 792a6c51875c ("[ALSA] Fix PM support")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
> Note: This only seems to trigger with the series
> "ALSA: Clean up with DEFINE_SIMPLE_DEV_PM_OPS()" applied.
>
> (Encountered on next-20240312)
>
> [0] https://lore.kernel.org/all/20240207155140.18238-1-tiwai@suse.de/
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-12 11:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-12 11:22 [PATCH] ALSA: aaci: Delete unused variable in aaci_do_suspend Thomas Weißschuh
2024-03-12 11:31 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox