Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH v2] ALSA: hda: remove unused chain_id entries from fixups
@ 2026-11-17 21:41 Sungwoo Kim
  2026-11-18 12:53 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Sungwoo Kim @ 2026-11-17 21:41 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai
  Cc: Dave Tian, Sungwoo Kim, Takashi Iwai, linux-sound, linux-kernel

Several HDA fixups specify a chain_id without setting the chained
flag, so the chained fixups are never executed.

Remove these unused chain_id entries.

Suggested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sungwoo Kim <iam@sung-woo.kim>
---
v1: https://lore.kernel.org/linux-sound/20261115132215.4084031-2-iam@sung-woo.kim/
v1->v2:
- Remove chain_id instead of setting chained true

The unused chain_id entries were introduced by:
- f1ec5be17b9a ("ALSA: hda/realtek: Add alc269/alc662 pin-tables for Loongson-3 laptops")
- f83bb2592482 ("ALSA: hda/conexant: Add quirk for LENOVO 20149 Notebook model")

 sound/hda/codecs/conexant.c       | 1 -
 sound/hda/codecs/realtek/alc269.c | 5 -----
 sound/hda/codecs/realtek/alc662.c | 1 -
 3 files changed, 7 deletions(-)

diff --git a/sound/hda/codecs/conexant.c b/sound/hda/codecs/conexant.c
index 5f2b0b55ab6e..5b5250043a50 100644
--- a/sound/hda/codecs/conexant.c
+++ b/sound/hda/codecs/conexant.c
@@ -974,7 +974,6 @@ static const struct hda_fixup cxt_fixups[] = {
 			{ 0x1a, 0x05d71030 },
 			{ }
 		},
-		.chain_id = CXT_FIXUP_STEREO_DMIC,
 	},
 	[CXT_FIXUP_INC_MIC_BOOST] = {
 		.type = HDA_FIXUP_FUNC,
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 96fa8c2782bb..96b691926570 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6431,7 +6431,6 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ 0x1e, 0x411111f0 },
 			{ }
 		},
-		.chain_id = ALC269_FIXUP_DMIC,
 	},
 	[ALC269_FIXUP_CZC_TMI] = {
 		.type = HDA_FIXUP_PINS,
@@ -6449,7 +6448,6 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ 0x20, 0x8000ffff },
 			{ }
 		},
-		.chain_id = ALC269_FIXUP_DMIC,
 	},
 	[ALC269_FIXUP_CZC_L101] = {
 		.type = HDA_FIXUP_PINS,
@@ -6467,7 +6465,6 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ 0x1e, 0x411111f0 },
 			{ }
 		},
-		.chain_id = ALC269_FIXUP_DMIC,
 	},
 	[ALC269_FIXUP_LEMOTE_A1802] = {
 		.type = HDA_FIXUP_PINS,
@@ -6485,7 +6482,6 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ 0x21, 0x03214020 },
 			{ }
 		},
-		.chain_id = ALC269_FIXUP_DMIC,
 	},
 	[ALC269_FIXUP_LEMOTE_A190X] = {
 		.type = HDA_FIXUP_PINS,
@@ -6497,7 +6493,6 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ 0x1b, 0x0201401f }, /* front lineout */
 			{ }
 		},
-		.chain_id = ALC269_FIXUP_DMIC,
 	},
 	[ALC256_FIXUP_INTEL_NUC8_RUGGED] = {
 		.type = HDA_FIXUP_PINS,
diff --git a/sound/hda/codecs/realtek/alc662.c b/sound/hda/codecs/realtek/alc662.c
index a0efd4596c88..6a65ec772e9b 100644
--- a/sound/hda/codecs/realtek/alc662.c
+++ b/sound/hda/codecs/realtek/alc662.c
@@ -629,7 +629,6 @@ static const struct hda_fixup alc662_fixups[] = {
 	[ALC668_FIXUP_ASUS_Nx51_HEADSET_MODE] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc_fixup_headset_mode_alc668,
-		.chain_id = ALC662_FIXUP_BASS_CHMAP
 	},
 	[ALC668_FIXUP_ASUS_Nx51] = {
 		.type = HDA_FIXUP_PINS,
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ALSA: hda: remove unused chain_id entries from fixups
  2026-11-17 21:41 [PATCH v2] ALSA: hda: remove unused chain_id entries from fixups Sungwoo Kim
@ 2026-11-18 12:53 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-11-18 12:53 UTC (permalink / raw)
  To: Sungwoo Kim
  Cc: Jaroslav Kysela, Takashi Iwai, Dave Tian, Takashi Iwai,
	linux-sound, linux-kernel

On Tue, 17 Nov 2026 22:41:57 +0100,
Sungwoo Kim wrote:
> 
> Several HDA fixups specify a chain_id without setting the chained
> flag, so the chained fixups are never executed.
> 
> Remove these unused chain_id entries.
> 
> Suggested-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Sungwoo Kim <iam@sung-woo.kim>

Applied to for-next branch.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-18 12:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 21:41 [PATCH v2] ALSA: hda: remove unused chain_id entries from fixups Sungwoo Kim
2026-11-18 12:53 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox