Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion Laptop 16-ag0xxx
@ 2026-05-14 16:59 Adrien Burnett
  2026-05-15  7:11 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Adrien Burnett @ 2026-05-14 16:59 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai; +Cc: linux-sound, linux-kernel

Add a SND_PCI_QUIRK entry for the HP Pavilion Laptop 16-ag0xxx
(subsystem 0x103c:0x8cbc, Realtek ALC245). The
ALC245_FIXUP_HP_X360_MUTE_LEDS fixup is already used by the
neighbouring HP Pavilion Aero Laptop 13-bg0xxx (0x103c:0x8cbd);
it chains the master-mute COEF handler with the GPIO mic-mute
LED handler, which is what this machine needs.

Tested on the affected hardware: both the mute and mic-mute key
LEDs respond correctly to the keyboard hotkeys after this change.

Cc: <stable@vger.kernel.org>
Signed-off-by: Adrien Burnett <an.arctic.pigeon@gmail.com>
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index d720565db..04d784343 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7135,6 +7135,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8ca4, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8ca7, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8caf, "HP Elite mt645 G8 Mobile Thin Client", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+	SND_PCI_QUIRK(0x103c, 0x8cbc, "HP Pavilion Laptop 16-ag0xxx", ALC245_FIXUP_HP_X360_MUTE_LEDS),
 	SND_PCI_QUIRK(0x103c, 0x8cbd, "HP Pavilion Aero Laptop 13-bg0xxx", ALC245_FIXUP_HP_X360_MUTE_LEDS),
 	SND_PCI_QUIRK(0x103c, 0x8cdd, "HP Spectre", ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
 	SND_PCI_QUIRK(0x103c, 0x8cde, "HP OmniBook Ultra Flip Laptop 14t", ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion Laptop 16-ag0xxx
  2026-05-14 16:59 [PATCH] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion Laptop 16-ag0xxx Adrien Burnett
@ 2026-05-15  7:11 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-05-15  7:11 UTC (permalink / raw)
  To: Adrien Burnett; +Cc: Jaroslav Kysela, Takashi Iwai, linux-sound, linux-kernel

On Thu, 14 May 2026 18:59:05 +0200,
Adrien Burnett wrote:
> 
> Add a SND_PCI_QUIRK entry for the HP Pavilion Laptop 16-ag0xxx
> (subsystem 0x103c:0x8cbc, Realtek ALC245). The
> ALC245_FIXUP_HP_X360_MUTE_LEDS fixup is already used by the
> neighbouring HP Pavilion Aero Laptop 13-bg0xxx (0x103c:0x8cbd);
> it chains the master-mute COEF handler with the GPIO mic-mute
> LED handler, which is what this machine needs.
> 
> Tested on the affected hardware: both the mute and mic-mute key
> LEDs respond correctly to the keyboard hotkeys after this change.
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Adrien Burnett <an.arctic.pigeon@gmail.com>

Applied now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-15  7:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-14 16:59 [PATCH] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion Laptop 16-ag0xxx Adrien Burnett
2026-05-15  7:11 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox