From: Takashi Iwai <tiwai@suse.de>
To: Aivaz <reichaivaz@gmail.com>
Cc: tiwai@suse.com, linux-sound@vger.kernel.org, kailang@realtek.com,
Aivaz Latypov <pngdrift@mail.ru>
Subject: Re: [PATCH v2] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx
Date: Mon, 24 Jun 2024 16:20:02 +0200 [thread overview]
Message-ID: <87wmmeo225.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAGRy+7BMH-4Kwp5mqCiDcjjQKJ2Q7gMwF=ZJO02hj+DyV1gkFA@mail.gmail.com>
On Mon, 24 Jun 2024 11:16:36 +0200,
Aivaz wrote:
>
> This HP Laptop uses ALC236 codec with COEF 0x07
> controlling the mute LED. Enable existing quirk for this device.
>
> Signed-off-by: Aivaz Latypov <reichaivaz@gmail.com>
First off, your mailer broke spaces and line breaks, so the patch
can't be applied cleanly at all. Please fix your mailer set up, or
better to use git-send-email for submission.
Also, the name in From line and Signed-off-by line are different.
Please try to align both.
thanks,
Takashi
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f4454abadc8d..51225c5770ea 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10067,6 +10067,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> + SND_PCI_QUIRK(0x103c, 0x87d3, "HP Laptop 15-gw0xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC",
> ALC236_FIXUP_HP_GPIO_LED),
> --
> 2.45.2
next prev parent reply other threads:[~2024-06-24 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 9:16 [PATCH v2] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Aivaz
2024-06-24 14:20 ` Takashi Iwai [this message]
2024-06-25 7:14 ` Amadeusz Sławiński
-- strict thread matches above, loose matches on Subject: below --
2024-06-25 8:12 Aivaz Latypov
2024-06-25 9:54 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmmeo225.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=kailang@realtek.com \
--cc=linux-sound@vger.kernel.org \
--cc=pngdrift@mail.ru \
--cc=reichaivaz@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox