* [PATCH v2] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx
@ 2024-06-24 9:16 Aivaz
2024-06-24 14:20 ` Takashi Iwai
2024-06-25 7:14 ` Amadeusz Sławiński
0 siblings, 2 replies; 5+ messages in thread
From: Aivaz @ 2024-06-24 9:16 UTC (permalink / raw)
To: tiwai; +Cc: linux-sound, kailang, Aivaz Latypov
This HP Laptop uses ALC236 codec with COEF 0x07
controlling the mute LED. Enable existing quirk for this device.
Signed-off-by: Aivaz Latypov <reichaivaz@gmail.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f4454abadc8d..51225c5770ea 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10067,6 +10067,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
+ SND_PCI_QUIRK(0x103c, 0x87d3, "HP Laptop 15-gw0xxx",
ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx",
ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC",
ALC236_FIXUP_HP_GPIO_LED),
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx
2024-06-24 9:16 [PATCH v2] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Aivaz
@ 2024-06-24 14:20 ` Takashi Iwai
2024-06-25 7:14 ` Amadeusz Sławiński
1 sibling, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2024-06-24 14:20 UTC (permalink / raw)
To: Aivaz; +Cc: tiwai, linux-sound, kailang, Aivaz Latypov
On Mon, 24 Jun 2024 11:16:36 +0200,
Aivaz wrote:
>
> This HP Laptop uses ALC236 codec with COEF 0x07
> controlling the mute LED. Enable existing quirk for this device.
>
> Signed-off-by: Aivaz Latypov <reichaivaz@gmail.com>
First off, your mailer broke spaces and line breaks, so the patch
can't be applied cleanly at all. Please fix your mailer set up, or
better to use git-send-email for submission.
Also, the name in From line and Signed-off-by line are different.
Please try to align both.
thanks,
Takashi
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f4454abadc8d..51225c5770ea 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10067,6 +10067,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> + SND_PCI_QUIRK(0x103c, 0x87d3, "HP Laptop 15-gw0xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC",
> ALC236_FIXUP_HP_GPIO_LED),
> --
> 2.45.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx
2024-06-24 9:16 [PATCH v2] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Aivaz
2024-06-24 14:20 ` Takashi Iwai
@ 2024-06-25 7:14 ` Amadeusz Sławiński
1 sibling, 0 replies; 5+ messages in thread
From: Amadeusz Sławiński @ 2024-06-25 7:14 UTC (permalink / raw)
To: Aivaz, tiwai; +Cc: linux-sound, kailang, Aivaz Latypov
On 6/24/2024 11:16 AM, Aivaz wrote:
> This HP Laptop uses ALC236 codec with COEF 0x07
> controlling the mute LED. Enable existing quirk for this device.
>
> Signed-off-by: Aivaz Latypov <reichaivaz@gmail.com>
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f4454abadc8d..51225c5770ea 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10067,6 +10067,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> + SND_PCI_QUIRK(0x103c, 0x87d3, "HP Laptop 15-gw0xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC",
> ALC236_FIXUP_HP_GPIO_LED),
> --
> 2.45.2
>
As far as I can tell, those are kept in sorted order, so they are easier
to find, so should be added after 0x103c, 0x87c8 in this case?
Thanks,
Amadeusz
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx
@ 2024-06-25 8:12 Aivaz Latypov
2024-06-25 9:54 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Aivaz Latypov @ 2024-06-25 8:12 UTC (permalink / raw)
To: tiwai; +Cc: Aivaz Latypov, kailang, linux-sound
This HP Laptop uses ALC236 codec with COEF 0x07 controlling
the mute LED. Enable existing quirk for this device.
Signed-off-by: Aivaz Latypov <reichaivaz@gmail.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f4454ab..cb9b11d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10069,6 +10069,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x87d3, "HP Laptop 15-gw0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f1, "HP ProBook 630 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx
2024-06-25 8:12 Aivaz Latypov
@ 2024-06-25 9:54 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2024-06-25 9:54 UTC (permalink / raw)
To: Aivaz Latypov; +Cc: tiwai, kailang, linux-sound
On Tue, 25 Jun 2024 10:12:02 +0200,
Aivaz Latypov wrote:
>
> This HP Laptop uses ALC236 codec with COEF 0x07 controlling
> the mute LED. Enable existing quirk for this device.
>
> Signed-off-by: Aivaz Latypov <reichaivaz@gmail.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-06-25 9:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-24 9:16 [PATCH v2] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Aivaz
2024-06-24 14:20 ` Takashi Iwai
2024-06-25 7:14 ` Amadeusz Sławiński
-- strict thread matches above, loose matches on Subject: below --
2024-06-25 8:12 Aivaz Latypov
2024-06-25 9:54 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox