Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Clément Villeret" <clement.villeret@gmail.com>
Cc: linux-sound@vger.kernel.org, perex@perex.cz, tiwai@suse.com
Subject: Re: ALSA: hda/realtek: Add quirk for ASUS ROG GV302XA
Date: Tue, 12 Dec 2023 08:46:52 +0100	[thread overview]
Message-ID: <87wmtjhngz.wl-tiwai@suse.de> (raw)
In-Reply-To: <3cad5ffd-22dd-4bd5-8c08-1a5530489923@gmail.com>

On Tue, 12 Dec 2023 08:43:36 +0100,
Clément Villeret wrote:
> 
> Commit message :

Please drop a superfluous tag.

> Asus ROG Flowx13 (GV302XA) seems require same patch as others asus product (UM3402YAR, UM3406HA...). This permit to load the correct firmware and don't loose audio after waking up from sleep or hibernate.

Your Signed-off-by tag is mandatory for the patch to be merged to the
upstream.  Please take a look at
Documentation/process/submitting-patches.rst for details.

About the code change:
> @@ -9954,6 +9954,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
>  	SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", ALC285_FIXUP_ASUS_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK),
> +	SND_PCI_QUIRK(0x1043, 0x1533, "ASUS GV302XA", ALC287_FIXUP_CS35L41_I2C_2),
>  	SND_PCI_QUIRK(0x1043, 0x1663, "ASUS GU603ZV", ALC285_FIXUP_ASUS_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", ALC287_FIXUP_CS35L41_I2C_2),
>  	SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),

The table is sorted in PCI SSID order.  Please put at the right
position.

Could you resubmit the patch with the corrections above?


thanks,

Takashi

  reply	other threads:[~2023-12-12  7:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12  7:43 ALSA: hda/realtek: Add quirk for ASUS ROG GV302XA Clément Villeret
2023-12-12  7:46 ` Takashi Iwai [this message]
     [not found]   ` <b93febca-6991-4259-9b38-1fee823d02a0@gmail.com>
2023-12-13 16:41     ` Takashi Iwai
     [not found] <446e6c6d-f639-4576-804a-e64e3fa4c463@gmail.com>
2023-12-14  8:49 ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2023-12-14 20:36 Clément Villeret
2023-12-15  7:13 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmtjhngz.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=clement.villeret@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox