* [PATCH] ALSA: firewire: Drop redundant mod_devicetable.h includes
@ 2026-07-06 3:26 Longlong Xia
2026-07-06 14:39 ` Takashi Sakamoto
2026-07-07 14:22 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Longlong Xia @ 2026-07-06 3:26 UTC (permalink / raw)
To: Takashi Sakamoto, Takashi Iwai
Cc: Jaroslav Kysela, Clemens Ladisch, linux-sound, linux-kernel
The ALSA FireWire driver headers include <linux/firewire.h>, which
already provides struct ieee1394_device_id via
<linux/device-id/ieee1394.h>.
Drop the now-redundant direct <linux/mod_devicetable.h> includes
from the per-device headers.
Signed-off-by: Longlong Xia <xialonglong2025@163.com>
---
sound/firewire/bebob/bebob.h | 1 -
sound/firewire/dice/dice.h | 1 -
sound/firewire/digi00x/digi00x.h | 1 -
sound/firewire/fireface/ff.h | 1 -
sound/firewire/fireworks/fireworks.h | 1 -
sound/firewire/motu/motu.h | 1 -
sound/firewire/oxfw/oxfw.h | 1 -
sound/firewire/tascam/tascam.h | 1 -
8 files changed, 8 deletions(-)
diff --git a/sound/firewire/bebob/bebob.h b/sound/firewire/bebob/bebob.h
index 4d73ecb30d79..41e019b9e24e 100644
--- a/sound/firewire/bebob/bebob.h
+++ b/sound/firewire/bebob/bebob.h
@@ -13,7 +13,6 @@
#include <linux/firewire.h>
#include <linux/firewire-constants.h>
#include <linux/module.h>
-#include <linux/mod_devicetable.h>
#include <linux/delay.h>
#include <linux/slab.h>
#include <linux/sched/signal.h>
diff --git a/sound/firewire/dice/dice.h b/sound/firewire/dice/dice.h
index 7744ea6a0791..5abae26d2bba 100644
--- a/sound/firewire/dice/dice.h
+++ b/sound/firewire/dice/dice.h
@@ -17,7 +17,6 @@
#include <linux/firewire-constants.h>
#include <linux/jiffies.h>
#include <linux/module.h>
-#include <linux/mod_devicetable.h>
#include <linux/mutex.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
diff --git a/sound/firewire/digi00x/digi00x.h b/sound/firewire/digi00x/digi00x.h
index 82b647d383c5..60d17a6fddd1 100644
--- a/sound/firewire/digi00x/digi00x.h
+++ b/sound/firewire/digi00x/digi00x.h
@@ -12,7 +12,6 @@
#include <linux/device.h>
#include <linux/firewire.h>
#include <linux/module.h>
-#include <linux/mod_devicetable.h>
#include <linux/delay.h>
#include <linux/slab.h>
#include <linux/sched/signal.h>
diff --git a/sound/firewire/fireface/ff.h b/sound/firewire/fireface/ff.h
index 7e42f5778a8a..c9c35c67db27 100644
--- a/sound/firewire/fireface/ff.h
+++ b/sound/firewire/fireface/ff.h
@@ -12,7 +12,6 @@
#include <linux/firewire.h>
#include <linux/firewire-constants.h>
#include <linux/module.h>
-#include <linux/mod_devicetable.h>
#include <linux/mutex.h>
#include <linux/slab.h>
#include <linux/compat.h>
diff --git a/sound/firewire/fireworks/fireworks.h b/sound/firewire/fireworks/fireworks.h
index c8d5879efe28..a8aadf754e72 100644
--- a/sound/firewire/fireworks/fireworks.h
+++ b/sound/firewire/fireworks/fireworks.h
@@ -13,7 +13,6 @@
#include <linux/firewire.h>
#include <linux/firewire-constants.h>
#include <linux/module.h>
-#include <linux/mod_devicetable.h>
#include <linux/delay.h>
#include <linux/slab.h>
#include <linux/sched/signal.h>
diff --git a/sound/firewire/motu/motu.h b/sound/firewire/motu/motu.h
index c66be0a89ccf..7333a76b50aa 100644
--- a/sound/firewire/motu/motu.h
+++ b/sound/firewire/motu/motu.h
@@ -12,7 +12,6 @@
#include <linux/firewire.h>
#include <linux/firewire-constants.h>
#include <linux/module.h>
-#include <linux/mod_devicetable.h>
#include <linux/mutex.h>
#include <linux/slab.h>
#include <linux/compat.h>
diff --git a/sound/firewire/oxfw/oxfw.h b/sound/firewire/oxfw/oxfw.h
index 39ea9a6dde33..aeb83e1595b7 100644
--- a/sound/firewire/oxfw/oxfw.h
+++ b/sound/firewire/oxfw/oxfw.h
@@ -9,7 +9,6 @@
#include <linux/firewire.h>
#include <linux/firewire-constants.h>
#include <linux/module.h>
-#include <linux/mod_devicetable.h>
#include <linux/mutex.h>
#include <linux/slab.h>
#include <linux/compat.h>
diff --git a/sound/firewire/tascam/tascam.h b/sound/firewire/tascam/tascam.h
index d07ffcb27be6..9c42c9b48f21 100644
--- a/sound/firewire/tascam/tascam.h
+++ b/sound/firewire/tascam/tascam.h
@@ -12,7 +12,6 @@
#include <linux/firewire.h>
#include <linux/firewire-constants.h>
#include <linux/module.h>
-#include <linux/mod_devicetable.h>
#include <linux/mutex.h>
#include <linux/slab.h>
#include <linux/compat.h>
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: firewire: Drop redundant mod_devicetable.h includes
2026-07-06 3:26 [PATCH] ALSA: firewire: Drop redundant mod_devicetable.h includes Longlong Xia
@ 2026-07-06 14:39 ` Takashi Sakamoto
2026-07-07 14:22 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Sakamoto @ 2026-07-06 14:39 UTC (permalink / raw)
To: Longlong Xia; +Cc: Takashi Iwai, linux-sound
Hi,
On Mon, Jul 06, 2026 at 12:26:39PM +0900, Longlong Xia wrote:
> The ALSA FireWire driver headers include <linux/firewire.h>, which
> already provides struct ieee1394_device_id via
> <linux/device-id/ieee1394.h>.
>
> Drop the now-redundant direct <linux/mod_devicetable.h> includes
> from the per-device headers.
>
> Signed-off-by: Longlong Xia <xialonglong2025@163.com>
> ---
> sound/firewire/bebob/bebob.h | 1 -
> sound/firewire/dice/dice.h | 1 -
> sound/firewire/digi00x/digi00x.h | 1 -
> sound/firewire/fireface/ff.h | 1 -
> sound/firewire/fireworks/fireworks.h | 1 -
> sound/firewire/motu/motu.h | 1 -
> sound/firewire/oxfw/oxfw.h | 1 -
> sound/firewire/tascam/tascam.h | 1 -
> 8 files changed, 8 deletions(-)
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Iwai-san, this patch should be applied to the tree which includes a
commit ecca1d63c1ea "Replace <linux/mod_devicetable.h> by more specific
<linux/device-id/*.h> (headers)" in v7.2-rc2. I would ask you to apply
it to your for-linus branch and send it for -rc3.
Thanks
Takashi Sakamoto
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: firewire: Drop redundant mod_devicetable.h includes
2026-07-06 3:26 [PATCH] ALSA: firewire: Drop redundant mod_devicetable.h includes Longlong Xia
2026-07-06 14:39 ` Takashi Sakamoto
@ 2026-07-07 14:22 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2026-07-07 14:22 UTC (permalink / raw)
To: Longlong Xia
Cc: Takashi Sakamoto, Takashi Iwai, Jaroslav Kysela, Clemens Ladisch,
linux-sound, linux-kernel
On Mon, 06 Jul 2026 05:26:39 +0200,
Longlong Xia wrote:
>
> The ALSA FireWire driver headers include <linux/firewire.h>, which
> already provides struct ieee1394_device_id via
> <linux/device-id/ieee1394.h>.
>
> Drop the now-redundant direct <linux/mod_devicetable.h> includes
> from the per-device headers.
>
> Signed-off-by: Longlong Xia <xialonglong2025@163.com>
Applied now.
thanks,
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-07 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-06 3:26 [PATCH] ALSA: firewire: Drop redundant mod_devicetable.h includes Longlong Xia
2026-07-06 14:39 ` Takashi Sakamoto
2026-07-07 14:22 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox