From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: <linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Mark Brown <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ASoC: Intel: avs: Use str_on_off() in avs_dsp_core_power()
Date: Thu, 13 Feb 2025 14:38:59 +0100 [thread overview]
Message-ID: <8c59618b-a9a6-4a0f-8200-2b7152dfe40c@intel.com> (raw)
In-Reply-To: <20250212091227.1217-3-thorsten.blum@linux.dev>
On 2025-02-12 10:12 AM, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_on_off() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> sound/soc/intel/avs/dsp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/avs/dsp.c b/sound/soc/intel/avs/dsp.c
> index 7b47e52c2b39..b9de691e9b9b 100644
> --- a/sound/soc/intel/avs/dsp.c
> +++ b/sound/soc/intel/avs/dsp.c
> @@ -6,6 +6,7 @@
> // Amadeusz Slawinski <amadeuszx.slawinski@linux.intel.com>
> //
>
> +#include <linux/string_choices.h>
> #include <sound/hdaudio_ext.h>
> #include "avs.h"
> #include "registers.h"
> @@ -39,7 +40,7 @@ int avs_dsp_core_power(struct avs_dev *adev, u32 core_mask, bool power)
> AVS_ADSPCS_TIMEOUT_US);
> if (ret)
> dev_err(adev->dev, "core_mask %d power %s failed: %d\n",
> - core_mask, power ? "on" : "off", ret);
> + core_mask, str_on_off(power), ret);
>
> return ret;
> }
LGTM
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
next prev parent reply other threads:[~2025-02-13 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 9:12 [PATCH] ASoC: Intel: avs: Use str_on_off() in avs_dsp_core_power() Thorsten Blum
2025-02-13 13:38 ` Cezary Rojewski [this message]
2025-02-13 17:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c59618b-a9a6-4a0f-8200-2b7152dfe40c@intel.com \
--to=cezary.rojewski@intel.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=thorsten.blum@linux.dev \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox