[PATCH] ASoC: Intel: avs: Use str_on_off() in avs_dsp_core_power()

[PATCH] ASoC: Intel: avs: Use str_on_off() in avs_dsp_core_power()

[Thorsten Blum]

Remove hard-coded strings by using the str_on_off() helper function.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 sound/soc/intel/avs/dsp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/intel/avs/dsp.c b/sound/soc/intel/avs/dsp.c
index 7b47e52c2b39..b9de691e9b9b 100644
--- a/sound/soc/intel/avs/dsp.c
+++ b/sound/soc/intel/avs/dsp.c
@@ -6,6 +6,7 @@
 //          Amadeusz Slawinski <amadeuszx.slawinski@linux.intel.com>
 //
 
+#include <linux/string_choices.h>
 #include <sound/hdaudio_ext.h>
 #include "avs.h"
 #include "registers.h"
@@ -39,7 +40,7 @@ int avs_dsp_core_power(struct avs_dev *adev, u32 core_mask, bool power)
 				       AVS_ADSPCS_TIMEOUT_US);
 	if (ret)
 		dev_err(adev->dev, "core_mask %d power %s failed: %d\n",
-			core_mask, power ? "on" : "off", ret);
+			core_mask, str_on_off(power), ret);
 
 	return ret;
 }
-- 
2.48.1

Re: [PATCH] ASoC: Intel: avs: Use str_on_off() in avs_dsp_core_power()

[Cezary Rojewski]

On 2025-02-12 10:12 AM, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_on_off() helper function.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>   sound/soc/intel/avs/dsp.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/avs/dsp.c b/sound/soc/intel/avs/dsp.c
> index 7b47e52c2b39..b9de691e9b9b 100644
> --- a/sound/soc/intel/avs/dsp.c
> +++ b/sound/soc/intel/avs/dsp.c
> @@ -6,6 +6,7 @@
>   //          Amadeusz Slawinski <amadeuszx.slawinski@linux.intel.com>
>   //
>   
> +#include <linux/string_choices.h>
>   #include <sound/hdaudio_ext.h>
>   #include "avs.h"
>   #include "registers.h"
> @@ -39,7 +40,7 @@ int avs_dsp_core_power(struct avs_dev *adev, u32 core_mask, bool power)
>   				       AVS_ADSPCS_TIMEOUT_US);
>   	if (ret)
>   		dev_err(adev->dev, "core_mask %d power %s failed: %d\n",
> -			core_mask, power ? "on" : "off", ret);
> +			core_mask, str_on_off(power), ret);
>   
>   	return ret;
>   }

LGTM

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>

Re: [PATCH] ASoC: Intel: avs: Use str_on_off() in avs_dsp_core_power()

[Mark Brown]

On Wed, 12 Feb 2025 10:12:26 +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_on_off() helper function.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: avs: Use str_on_off() in avs_dsp_core_power()
      commit: 994719ed6d81a6f4677875ab6730254c0bc484ea

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark