[PATCH v1] ASoC: tas2781: Optimize calibration to avoid full device reboot after calibration

[PATCH v1] ASoC: tas2781: Optimize calibration to avoid full device reboot after calibration

[Shenghao Ding]

Some clients have specified a new requirement: complete device restarts
should be avoided after calibration. Only a hot boot of the Smart Audio
Amplifier is required.

Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
---
 sound/soc/codecs/tas2781-i2c.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c
index 9e6f0ad5f05d..8eb9ead2951e 100644
--- a/sound/soc/codecs/tas2781-i2c.c
+++ b/sound/soc/codecs/tas2781-i2c.c
@@ -617,6 +617,7 @@ static int tasdev_calib_stop_put(struct snd_kcontrol *kcontrol,
 {
 	struct snd_soc_component *comp = snd_kcontrol_chip(kcontrol);
 	struct tasdevice_priv *priv = snd_soc_component_get_drvdata(comp);
+	int i;
 
 	guard(mutex)(&priv->codec_lock);
 	if (priv->chip_id == TAS2563)
@@ -624,6 +625,14 @@ static int tasdev_calib_stop_put(struct snd_kcontrol *kcontrol,
 	else
 		tas2781_calib_stop_put(priv);
 
+	/*
+	 * Set reloading-firmware flag after calibration, the flag will work
+	 * during next playback, then set to the program id after reloading
+	 * firmware.
+	 */
+	for (i = 0; i < priv->ndev; i++)
+		priv->tasdevice[i].cur_prog = -1;
+
 	return 1;
 }
 
-- 
2.43.0

Re: [PATCH v1] ASoC: tas2781: Optimize calibration to avoid full device reboot after calibration

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 691 bytes --]

On Fri, Jul 24, 2026 at 06:25:43PM +0800, Shenghao Ding wrote:
> Some clients have specified a new requirement: complete device restarts
> should be avoided after calibration. Only a hot boot of the Smart Audio
> Amplifier is required.

> +	/*
> +	 * Set reloading-firmware flag after calibration, the flag will work
> +	 * during next playback, then set to the program id after reloading
> +	 * firmware.
> +	 */
> +	for (i = 0; i < priv->ndev; i++)
> +		priv->tasdevice[i].cur_prog = -1;
> +

I'll apply this since this is preexisting, but it might be worth
checking the interaction with DAPM delayed powerdown (or indeed active
streams).  There's an element of user error here of course.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v1] ASoC: tas2781: Optimize calibration to avoid full device reboot after calibration

[Mark Brown]

On Fri, 24 Jul 2026 18:25:43 +0800, Shenghao Ding wrote:
> ASoC: tas2781: Optimize calibration to avoid full device reboot after calibration

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/1] ASoC: tas2781: Optimize calibration to avoid full device reboot after calibration
      https://git.kernel.org/broonie/sound/c/df3bdb553331

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

RE: Re: [PATCH v1] ASoC: tas2781: Optimize calibration to avoid full device reboot after calibration

[Ding, Shenghao]

Hi Brown

> On Fri, Jul 24, 2026 at 06:25:43PM +0800, Shenghao Ding wrote:
> > Some clients have specified a new requirement: complete device
> > restarts should be avoided after calibration. Only a hot boot of the
> > Smart Audio Amplifier is required.
> 
> > +	/*
> > +	 * Set reloading-firmware flag after calibration, the flag will work
> > +	 * during next playback, then set to the program id after reloading
> > +	 * firmware.
> > +	 */
> > +	for (i = 0; i < priv->ndev; i++)
> > +		priv->tasdevice[i].cur_prog = -1;
> > +
> 
> I'll apply this since this is preexisting, but it might be worth checking the
> interaction with DAPM delayed powerdown (or indeed active streams).
> There's an element of user error here of course.

Thank you very much for your valuable feedback. I will forward all your comments 
directly to our customer side for full visibility.