Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH v2 00/10] driver core: Disable driver overriding by default
@ 2026-11-20 11:11 Uwe Kleine-König
  2026-11-20 11:11 ` [PATCH v2 09/10] slimbus: qcom-ngd-ctrl: Allow untainted use of driver_override Uwe Kleine-König
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2026-11-20 11:11 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Danilo Krummrich, Johan Hovold, Bjorn Helgaas,
	Nipun Gupta, Nikhil Agarwal, Ioana Ciornei, Longfang Liu,
	Julian Ruess, Ankit Agrawal, Brett Creeley, Giovanni Cabiddu,
	Michał Winiarski, Eric Auger, Eric Farman, Matthew Rosato,
	Tony Krowiak, Jason Herne, Harald Freudenberger, Holger Dengler,
	Haiyang Zhang, Wei Liu, Dexuan Cui, Michael S. Tsirkin,
	Mark Brown, Abel Vesa, Stephen Boyd, Brian Masney, Jerome Brunet,
	Bjorn Andersson, Mathieu Poirier, Srinivas Kandagatla,
	Sylwester Nawrocki, Liam Girdwood, Jaroslav Kysela
  Cc: Jonathan Corbet, Rafael J. Wysocki, Steven Rostedt,
	Bradley Morgan, Armin Wolf, Masami Hiramatsu, linux-doc,
	driver-core, linux-kernel, linux-trace-kernel, linux-pci,
	Alex Williamson, Mostafa Saleh, kvm, qat-linux, virtualization,
	intel-xe, Vineeth Vijayan, Peter Oberparleiter, Heiko Carstens,
	Vasily Gorbik, Alexander Gordeev, linux-s390, linux-hyperv,
	linux-spi, Frank Li, Sascha Hauer, linux-clk, imx,
	linux-arm-kernel, linux-remoteproc, linux-arm-msm, linux-sound,
	Takashi Iwai

Hello,

here comes v2 which addresses the review feedback I got for (implicit)
v1. See https://lore.kernel.org/linux-kernel/20261116110853.3418077-2-u.kleine-koenig@baylibre.com
for the discussion about that previous submission.
 
The objective is to deny force binding a device to a driver that isn't
prepared for that. There are many drivers that run in a null pointer
exception when this happens and only very few drivers are supposed to be
used like that. So the first patch implements an explicit opt-in for
drivers and denies other matches; the remaining patches implement the
opt-in for drivers that rely on it. This makes it unnecessary to fix
individual drivers to explicitly refuse such bindings. See commit
1e50a0349012 ("iio: adc: mcp3564: reject devices without match data")
for an example of such a driver-specific fix.

Changes since (implicit) v1:
 
 - Rework parameter parsing to just use `allow_driver_override` on the
   kernel commandline
 - Add review tags
 - Add patches by Alex Williamson setting .support_driver_override in
   pci and vfio drivers
 - Add patches for uio, spidev and a few more drivers setting
   .support_driver_override
 - align wording in Documentation/admin-guide/tainted-kernels.rst with 
   tools/debugging/kernel-chktaint

It is sensible to merge the driver core change (patch #1) together with
the individual driver patches setting .support_driver_override because
with the driver core change the driver override doesn't work any more
for the unmodified drivers (unless the new kernel parameter is provided
and a taint is accepted). So I suggest (once there is agreement that the
patches are fine) to merge them all in one go and provide a stable
branch in case a driver was missed to be adapted. I can create such a
branch and ask Greg or Linus to pull it, or Greg can do that.

So if you're the maintainer of one of the drivers touched by patches #2
and later and assuming your ok with that patch, please provide your Ack
(plus the required coordination if applicable) for not merging via your
usual tree.

Best regards
Uwe

Alex Williamson (3):
  PCI: Allow untainted driver_override for PCI stub drivers
  vfio: Allow untainted use of driver_override
  s390/vfio: Allow untainted use of driver_override

Uwe Kleine-König (7):
  driver core: Disable driver overriding by default
  uio: Allow untainted use of driver_override
  spi: spidev: Allow untainted use of driver_override
  clk: imx: scu: Allow untainted use of driver_override
  remoteproc: Allow untainted use of driver_override
  slimbus: qcom-ngd-ctrl: Allow untainted use of driver_override
  ASoC: samsung: i2s: Allow untainted use of driver_override

 .../admin-guide/kernel-parameters.txt         |  6 +++
 Documentation/admin-guide/tainted-kernels.rst | 54 ++++++++++---------
 drivers/base/bus.c                            | 51 ++++++++++++++++++
 drivers/clk/imx/clk-scu.c                     |  1 +
 drivers/pci/pci-pf-stub.c                     |  1 +
 drivers/pci/pci-stub.c                        |  1 +
 drivers/rpmsg/rpmsg_ctrl.c                    |  1 +
 drivers/rpmsg/rpmsg_ns.c                      |  5 +-
 drivers/s390/cio/vfio_ccw_drv.c               |  1 +
 drivers/s390/crypto/vfio_ap_drv.c             |  1 +
 drivers/slimbus/qcom-ngd-ctrl.c               |  1 +
 drivers/spi/spidev.c                          |  1 +
 drivers/uio/uio_dmem_genirq.c                 |  1 +
 drivers/uio/uio_hv_generic.c                  |  1 +
 drivers/uio/uio_pci_generic.c                 |  1 +
 drivers/uio/uio_pdrv_genirq.c                 |  1 +
 drivers/vfio/cdx/main.c                       |  1 +
 drivers/vfio/fsl-mc/vfio_fsl_mc.c             |  1 +
 .../vfio/pci/hisilicon/hisi_acc_vfio_pci.c    |  3 +-
 drivers/vfio/pci/ism/main.c                   |  3 +-
 drivers/vfio/pci/mlx5/main.c                  |  3 +-
 drivers/vfio/pci/nvgrace-gpu/main.c           |  3 +-
 drivers/vfio/pci/pds/pci_drv.c                |  3 +-
 drivers/vfio/pci/qat/main.c                   |  3 +-
 drivers/vfio/pci/vfio_pci.c                   |  3 +-
 drivers/vfio/pci/virtio/main.c                |  3 +-
 drivers/vfio/pci/xe/main.c                    |  3 +-
 drivers/vfio/platform/vfio_amba.c             |  1 +
 drivers/vfio/platform/vfio_platform.c         |  1 +
 include/linux/device.h                        | 19 +------
 include/linux/device/driver.h                 |  2 +
 include/linux/panic.h                         |  3 +-
 include/trace/events/module.h                 |  3 +-
 kernel/panic.c                                |  3 +-
 sound/soc/samsung/i2s.c                       |  1 +
 tools/debugging/kernel-chktaint               |  9 ++++
 36 files changed, 144 insertions(+), 55 deletions(-)


base-commit: 7cfbf79c66c63e807ea452abf0546e6f6d6833a6
-- 
2.56.0.rc1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 09/10] slimbus: qcom-ngd-ctrl: Allow untainted use of driver_override
  2026-11-20 11:11 [PATCH v2 00/10] driver core: Disable driver overriding by default Uwe Kleine-König
@ 2026-11-20 11:11 ` Uwe Kleine-König
  2026-11-20 11:11 ` [PATCH v2 10/10] ASoC: samsung: i2s: " Uwe Kleine-König
  2026-11-21  1:16 ` [PATCH v2 00/10] driver core: Disable driver overriding by default Danilo Krummrich
  2 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2026-11-20 11:11 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Srinivas Kandagatla; +Cc: linux-arm-msm, linux-sound

The driver is expected to be bound to devices using a driver
override---see the respective use of device_set_driver_override()---and
so should be allowed to match via that mechanism.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
 drivers/slimbus/qcom-ngd-ctrl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index 8da75c4b50e5..f501740fa4a6 100644
--- a/drivers/slimbus/qcom-ngd-ctrl.c
+++ b/drivers/slimbus/qcom-ngd-ctrl.c
@@ -1837,6 +1837,7 @@ static struct platform_driver qcom_slim_ngd_driver = {
 	.driver	= {
 		.name = QCOM_SLIM_NGD_DRV_NAME,
 		.pm = &qcom_slim_ngd_dev_pm_ops,
+		.support_driver_override = true,
 	},
 };
 
-- 
2.56.0.rc1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 10/10] ASoC: samsung: i2s: Allow untainted use of driver_override
  2026-11-20 11:11 [PATCH v2 00/10] driver core: Disable driver overriding by default Uwe Kleine-König
  2026-11-20 11:11 ` [PATCH v2 09/10] slimbus: qcom-ngd-ctrl: Allow untainted use of driver_override Uwe Kleine-König
@ 2026-11-20 11:11 ` Uwe Kleine-König
  2026-11-21  1:16 ` [PATCH v2 00/10] driver core: Disable driver overriding by default Danilo Krummrich
  2 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2026-11-20 11:11 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Sylwester Nawrocki, Liam Girdwood, Mark Brown,
	Jaroslav Kysela
  Cc: Takashi Iwai, linux-sound

The driver is expected to be bound to devices using a driver
override---see the respective use of device_set_driver_override()---and
so should be allowed to match via that mechanism.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
 sound/soc/samsung/i2s.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index 8a938d0d79f9..fdddd3d4eb65 100644
--- a/sound/soc/samsung/i2s.c
+++ b/sound/soc/samsung/i2s.c
@@ -1740,6 +1740,7 @@ static struct platform_driver samsung_i2s_driver = {
 		.name = "samsung-i2s",
 		.of_match_table = of_match_ptr(exynos_i2s_match),
 		.pm = pm_ptr(&samsung_i2s_pm),
+		.support_driver_override = true,
 	},
 };
 
-- 
2.56.0.rc1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 00/10] driver core: Disable driver overriding by default
  2026-11-20 11:11 [PATCH v2 00/10] driver core: Disable driver overriding by default Uwe Kleine-König
  2026-11-20 11:11 ` [PATCH v2 09/10] slimbus: qcom-ngd-ctrl: Allow untainted use of driver_override Uwe Kleine-König
  2026-11-20 11:11 ` [PATCH v2 10/10] ASoC: samsung: i2s: " Uwe Kleine-König
@ 2026-11-21  1:16 ` Danilo Krummrich
  2 siblings, 0 replies; 4+ messages in thread
From: Danilo Krummrich @ 2026-11-21  1:16 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Greg Kroah-Hartman, Johan Hovold, Bjorn Helgaas, Nipun Gupta,
	Nikhil Agarwal, Ioana Ciornei, Longfang Liu, Julian Ruess,
	Ankit Agrawal, Brett Creeley, Giovanni Cabiddu,
	Michał Winiarski, Eric Auger, Eric Farman, Matthew Rosato,
	Tony Krowiak, Jason Herne, Harald Freudenberger, Holger Dengler,
	Haiyang Zhang, Wei Liu, Dexuan Cui, Michael S. Tsirkin,
	Mark Brown, Abel Vesa, Stephen Boyd, Brian Masney, Jerome Brunet,
	Bjorn Andersson, Mathieu Poirier, Srinivas Kandagatla,
	Sylwester Nawrocki, Liam Girdwood, Jaroslav Kysela,
	Jonathan Corbet, Rafael J. Wysocki, Steven Rostedt,
	Bradley Morgan, Armin Wolf, Masami Hiramatsu, linux-doc,
	driver-core, linux-kernel, linux-trace-kernel, linux-pci,
	Alex Williamson, Mostafa Saleh, kvm, qat-linux, virtualization,
	intel-xe, Vineeth Vijayan, Peter Oberparleiter, Heiko Carstens,
	Vasily Gorbik, Alexander Gordeev, linux-s390, linux-hyperv,
	linux-spi, Frank Li, Sascha Hauer, linux-clk, imx,
	linux-arm-kernel, linux-remoteproc, linux-arm-msm, linux-sound,
	Takashi Iwai

On Fri Nov 20, 2026 at 12:11 PM CET, Uwe Kleine-König wrote:
> It is sensible to merge the driver core change (patch #1) together with
> the individual driver patches setting .support_driver_override because
> with the driver core change the driver override doesn't work any more
> for the unmodified drivers (unless the new kernel parameter is provided
> and a taint is accepted). So I suggest (once there is agreement that the
> patches are fine) to merge them all in one go and provide a stable
> branch in case a driver was missed to be adapted. I can create such a
> branch and ask Greg or Linus to pull it, or Greg can do that.

I think it should be good enough to just take them all through driver-core. If
it turns out in linux-next that we missed a driver we can always add another
patch to the driver-core tree.

Those patches only set support_driver_override = true, so there shouldn't be
interactions with other trees.

So, let's keep it simple. I can pick this up once we have all the ACKs.

Thanks,
Danilo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-21  1:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 11:11 [PATCH v2 00/10] driver core: Disable driver overriding by default Uwe Kleine-König
2026-11-20 11:11 ` [PATCH v2 09/10] slimbus: qcom-ngd-ctrl: Allow untainted use of driver_override Uwe Kleine-König
2026-11-20 11:11 ` [PATCH v2 10/10] ASoC: samsung: i2s: " Uwe Kleine-König
2026-11-21  1:16 ` [PATCH v2 00/10] driver core: Disable driver overriding by default Danilo Krummrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox