* [PATCH] ASoC: cros_ec_codec: Use str_enable_disable() helper in wov_enable_put()
@ 2025-02-20 12:01 Thorsten Blum
2025-02-21 1:32 ` Tzung-Bi Shih
2025-02-25 13:38 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Thorsten Blum @ 2025-02-20 12:01 UTC (permalink / raw)
To: Cheng-Yi Chiang, Tzung-Bi Shih, Guenter Roeck, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Benson Leung
Cc: Thorsten Blum, chrome-platform, linux-sound, linux-kernel
Remove hard-coded strings by using the str_enable_disable() helper
function.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
sound/soc/codecs/cros_ec_codec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
index 11e7b3f6d410..571222ec520c 100644
--- a/sound/soc/codecs/cros_ec_codec.c
+++ b/sound/soc/codecs/cros_ec_codec.c
@@ -21,6 +21,7 @@
#include <linux/platform_data/cros_ec_commands.h>
#include <linux/platform_data/cros_ec_proto.h>
#include <linux/platform_device.h>
+#include <linux/string_choices.h>
#include <sound/pcm.h>
#include <sound/pcm_params.h>
#include <sound/soc.h>
@@ -657,7 +658,7 @@ static int wov_enable_put(struct snd_kcontrol *kcontrol,
(uint8_t *)&p, sizeof(p), NULL, 0);
if (ret) {
dev_err(priv->dev, "failed to %s wov\n",
- enabled ? "enable" : "disable");
+ str_enable_disable(enabled));
return ret;
}
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: cros_ec_codec: Use str_enable_disable() helper in wov_enable_put()
2025-02-20 12:01 [PATCH] ASoC: cros_ec_codec: Use str_enable_disable() helper in wov_enable_put() Thorsten Blum
@ 2025-02-21 1:32 ` Tzung-Bi Shih
2025-02-25 13:38 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Tzung-Bi Shih @ 2025-02-21 1:32 UTC (permalink / raw)
To: Thorsten Blum
Cc: Cheng-Yi Chiang, Guenter Roeck, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Benson Leung, chrome-platform,
linux-sound, linux-kernel
On Thu, Feb 20, 2025 at 01:01:01PM +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enable_disable() helper
> function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Acked-by: Tzung-Bi Shih <tzungbi@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: cros_ec_codec: Use str_enable_disable() helper in wov_enable_put()
2025-02-20 12:01 [PATCH] ASoC: cros_ec_codec: Use str_enable_disable() helper in wov_enable_put() Thorsten Blum
2025-02-21 1:32 ` Tzung-Bi Shih
@ 2025-02-25 13:38 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2025-02-25 13:38 UTC (permalink / raw)
To: Cheng-Yi Chiang, Tzung-Bi Shih, Guenter Roeck, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Benson Leung, Thorsten Blum
Cc: chrome-platform, linux-sound, linux-kernel
On Thu, 20 Feb 2025 13:01:01 +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enable_disable() helper
> function.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: cros_ec_codec: Use str_enable_disable() helper in wov_enable_put()
commit: 10efa807929084a8a1c38655942a3bf83bce587a
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-25 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-20 12:01 [PATCH] ASoC: cros_ec_codec: Use str_enable_disable() helper in wov_enable_put() Thorsten Blum
2025-02-21 1:32 ` Tzung-Bi Shih
2025-02-25 13:38 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox