* [bug report] ASoC: tas2764: Apply Apple quirks
@ 2025-04-16 11:12 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2025-04-16 11:12 UTC (permalink / raw)
To: Martin Povišer; +Cc: linux-sound
Hello Martin Povišer,
Commit f33b01e0947d ("ASoC: tas2764: Apply Apple quirks") from Apr 6,
2025 (linux-next), leads to the following Smatch static checker
warning:
sound/soc/codecs/tas2764.c:128 tas2764_update_pwr_ctrl()
warn: odd binop '0x3f & 0x80'
sound/soc/codecs/tas2764.c
116 static int tas2764_update_pwr_ctrl(struct tas2764_priv *tas2764)
117 {
118 struct snd_soc_component *component = tas2764->component;
119 unsigned int val;
120 int ret;
121
122 if (tas2764->dac_powered)
123 val = tas2764->unmuted ?
124 TAS2764_PWR_CTRL_ACTIVE : TAS2764_PWR_CTRL_MUTE;
125 else
126 val = TAS2764_PWR_CTRL_SHUTDOWN;
127
--> 128 if (ENABLED_APPLE_QUIRKS & TAS2764_SHUTDOWN_DANCE)
TAS2764_SHUTDOWN_DANCE isn't an ENABLED_APPLE_QUIRKS and there isn't
a way to enable it without editing the code.
129 return tas2764_do_quirky_pwr_ctrl_change(tas2764, val);
130
131 ret = snd_soc_component_update_bits(component, TAS2764_PWR_CTRL,
132 TAS2764_PWR_CTRL_MASK, val);
133 if (ret < 0)
134 return ret;
135
136 return 0;
137 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-04-16 11:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-16 11:12 [bug report] ASoC: tas2764: Apply Apple quirks Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox