From: Mark Brown <broonie@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: "Zhu Jun" <zhujun2@cmss.chinamobile.com>,
linux-sound@vger.kernel.org, "Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
LKML <linux-kernel@vger.kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Weidong Wang" <wangweidong.a@awinic.com>
Subject: Re: [PATCH v3?] ASoC: codecs: aw88399: Fix error handling in aw_dev_get_dsp_status()
Date: Wed, 9 Oct 2024 13:47:33 +0100 [thread overview]
Message-ID: <ZwZ7Zf0VCvert7Ya@finisterre.sirena.org.uk> (raw)
In-Reply-To: <fbbe290b-4dd4-4a65-acfb-8150b621a5c7@web.de>
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
On Wed, Oct 09, 2024 at 01:12:21PM +0200, Markus Elfring wrote:
> > Changed the error handling in aw_dev_get_dsp_status to return -EPERM directly
> > instead of setting it to a variable.
>
> * How do you think about to choose an imperative wording for an improved change description?
Feel free to ignore Markus, he has a long history of sending
unhelpful review comments and continues to ignore repeated requests
to stop.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-10-09 12:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 9:43 [PATCH v2] ASoC: codecs: Fix error handling in aw_dev_get_dsp_status() Zhu Jun
2024-10-09 11:12 ` [PATCH v3?] ASoC: codecs: aw88399: " Markus Elfring
2024-10-09 12:47 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwZ7Zf0VCvert7Ya@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heiko@sntech.de \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=wangweidong.a@awinic.com \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox